{"thread":{"id":"46429","subject":"[PATCH 1/6] RelNotes: mention \"log: add -P as a synonym for --perl-regexp\"","startedAt":"2017-07-20T14:19:50Z","lastAt":"2017-07-21T11:03:48Z","messageCount":12,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"324801","messageId":"20170720141927.18274-2-avarab@gmail.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"[PATCH 1/6] RelNotes: mention \"log: add -P as a synonym for --perl-regexp\"","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:22Z","receivedAt":"2017-07-20T14:19:50Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"To inform users that they can use the short form now. See\n7531a2dd87 (\"log: add -P as a synonym for --perl-regexp\", 2017-05-25).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/RelNotes/2.14.0.txt | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\nindex 2f3879fe96..9a4c2bb649 100644\n--- a/Documentation/RelNotes/2.14.0.txt\n+++ b/Documentation/RelNotes/2.14.0.txt\n@@ -117,6 +117,8 @@ UI, Workflows & Features\n * \"git pull --rebase --recurse-submodules\" learns to rebase the\n branch in the submodules to an updated base.\n \n+ * \"git log\" learned -P as a synonym for --perl-regexp, \"git grep\"\n+ already had such a synonym.\n \n Performance, Internal Implementation, Development Support etc.\n \n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324802","messageId":"20170720141927.18274-1-avarab@gmail.com","threadId":"46429","inReplyTo":"xmqq7ez6hk2y.fsf@gitster.mtv.corp.google.com","subject":"[PATCH 0/6] 2.14 RelNotes improvements","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:21Z","receivedAt":"2017-07-20T14:19:52Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"> Ævar Arnfjörð Bjarmason writes:\n>\n>> On Thu, Jul 13 2017, Junio C. Hamano jotted:\n>>\n>> Proposed improvements for the release notes (is this a good way to\n>> propose RelNotes changes?)\n>\n> Thanks. You could also throw a patch just like any bugfix/update\n> to documentation, I would think.\n\nHere's a few patches to improve the relnotes. I started just writing\n6/6 since I think (I don't care about the wording) that we should in\nsome way mention the items in the list in the 6/6 commit message.\n\nAlong the way I noticed a few more missing things.\n\nÆvar Arnfjörð Bjarmason (6):\n RelNotes: mention \"log: add -P as a synonym for --perl-regexp\"\n RelNotes: mention \"log: make --regexp-ignore-case work with\n --perl-regexp\"\n RelNotes: mention \"sha1dc: optionally use sha1collisiondetection as a\n submodule\"\n RelNotes: mention that PCRE v2 exposes the same syntax\n RelNotes: remove duplicate mention of PCRE v2\n RelNotes: add more notes about PCRE in 2.14\n\n Documentation/RelNotes/2.14.0.txt | 25 +++++++++++++++++++++++--\n 1 file changed, 23 insertions(+), 2 deletions(-)\n\n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324803","messageId":"20170720141927.18274-3-avarab@gmail.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"[PATCH 2/6] RelNotes: mention \"log: make --regexp-ignore-case work with --perl-regexp\"","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:23Z","receivedAt":"2017-07-20T14:19:53Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"To inform users that they can use --regexp-ignore-case now, and that\nexisting scripts which relied on that + PCRE may be buggy. See\n9e3cbc59d5 (\"log: make --regexp-ignore-case work with --perl-regexp\",\n2017-05-20).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/RelNotes/2.14.0.txt | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\nindex 9a4c2bb649..c125f8fd68 100644\n--- a/Documentation/RelNotes/2.14.0.txt\n+++ b/Documentation/RelNotes/2.14.0.txt\n@@ -120,6 +120,9 @@ UI, Workflows & Features\n * \"git log\" learned -P as a synonym for --perl-regexp, \"git grep\"\n already had such a synonym.\n \n+ * \"git log\" didn't understand --regexp-ignore-case when combined with\n+ --perl-regexp. This has been fixed.\n+\n Performance, Internal Implementation, Development Support etc.\n \n * The default packed-git limit value has been raised on larger\n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324804","messageId":"20170720141927.18274-4-avarab@gmail.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"[PATCH 3/6] RelNotes: mention \"sha1dc: optionally use sha1collisiondetection as a submodule\"","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:24Z","receivedAt":"2017-07-20T14:19:54Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"To note that merely cloning git.git without --recurse-submodules\ndoesn't get you a full copy of the code anymore. See\n5f6482d642 (\"RelNotes: mention \"log: make --regexp-ignore-case work\nwith --perl-regexp\"\", 2017-07-20).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/RelNotes/2.14.0.txt | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\nindex c125f8fd68..7ed93bca37 100644\n--- a/Documentation/RelNotes/2.14.0.txt\n+++ b/Documentation/RelNotes/2.14.0.txt\n@@ -235,6 +235,11 @@ Performance, Internal Implementation, Development Support etc.\n behaviour of the comparison function can be specified at the time a\n hashmap is initialized.\n \n+ * The \"collision detecting\" SHA-1 implementation shipped with 2.13 is\n+ now integrated into git.git as a submodule (the first submodule to\n+ ship with git.git). Clone git.git with --recurse-submodules to get\n+ it. For now a non-submodule copy of the same code is also shipped\n+ as part of the tree.\n \n Also contains various documentation updates and code clean-ups.\n \n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324805","messageId":"20170720141927.18274-6-avarab@gmail.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"[PATCH 5/6] RelNotes: remove duplicate mention of PCRE v2","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:26Z","receivedAt":"2017-07-20T14:19:56Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"That we can link to PCRE v2 is already covered above in \"Backward\ncompatibility notes and other notable changes\", no need to mention it\ntwice.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/RelNotes/2.14.0.txt | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\nindex 0e363f2af3..fb6a3dba31 100644\n--- a/Documentation/RelNotes/2.14.0.txt\n+++ b/Documentation/RelNotes/2.14.0.txt\n@@ -88,8 +88,7 @@ UI, Workflows & Features\n learned to say \"it's a pathspec\" a bit more often when the syntax\n looks like so.\n \n- * Update \"perl-compatible regular expression\" support to enable JIT\n- and also allow linking with the newer PCRE v2 library.\n+ * Update \"perl-compatible regular expression\" support to enable JIT.\n \n * \"filter-branch\" learned a pseudo filter \"--setup\" that can be used\n to define common functions/variables that can be used by other\n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324806","messageId":"20170720141927.18274-7-avarab@gmail.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"[PATCH 6/6] RelNotes: add more notes about PCRE in 2.14","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:27Z","receivedAt":"2017-07-20T14:19:58Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"We were missing any mention that:\n\n - PCRE is now faster with JIT\n - That it's now faster than the other regex backends\n - That therefore you might want to use it by default, but beware of\n the incompatible syntax.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/RelNotes/2.14.0.txt | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\nindex fb6a3dba31..a6a1cb963b 100644\n--- a/Documentation/RelNotes/2.14.0.txt\n+++ b/Documentation/RelNotes/2.14.0.txt\n@@ -88,7 +88,16 @@ UI, Workflows & Features\n learned to say \"it's a pathspec\" a bit more often when the syntax\n looks like so.\n \n- * Update \"perl-compatible regular expression\" support to enable JIT.\n+ * Update \"perl-compatible regular expression\" support to enable\n+ JIT.\n+\n+ This makes grep.patternType=perl (and -P and --perl-regexp) much\n+ faster for \"git grep\" and \"git log\", and is generally faster than\n+ the system's POSIX regular expression implementation. Users\n+ concerned with \"git grep\" performance or \"git log --grep\"\n+ performance might want to try setting grep.patternType=perl. Note\n+ that the syntax isn't compatible with git's default of\n+ grep.patternType=basic.\n \n * \"filter-branch\" learned a pseudo filter \"--setup\" that can be used\n to define common functions/variables that can be used by other\n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324807","messageId":"20170720141927.18274-5-avarab@gmail.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"[PATCH 4/6] RelNotes: mention that PCRE v2 exposes the same syntax","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-20T14:19:25Z","receivedAt":"2017-07-20T14:20:26Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"For someone not familiar with PCRE or having read its own\ndocumentation this isn't obvious, let's explicitly mention it so\npackage maintainers won't fear upgrading least they break things for\ntheir users.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/RelNotes/2.14.0.txt | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\nindex 7ed93bca37..0e363f2af3 100644\n--- a/Documentation/RelNotes/2.14.0.txt\n+++ b/Documentation/RelNotes/2.14.0.txt\n@@ -28,6 +28,9 @@ Backward compatibility notes and other notable changes.\n upstream PCRE maintainer has abandoned v1 maintenance for all but\n the most critical bug fixes, use of v2 is recommended.\n \n+ Version v2 of the library is fully backwards compatible with the\n+ Perl-compatible regular expression syntax exposed by git (sans a\n+ few obscure bugfixes).\n \n Updates since v2.13\n -------------------\n-- \n2.13.2.932.g7449e964c\n\n"},{"id":"324809","messageId":"xmqqzibzku6m.fsf@gitster.mtv.corp.google.com","threadId":"46429","inReplyTo":"20170720141927.18274-5-avarab@gmail.com","subject":"Re: [PATCH 4/6] RelNotes: mention that PCRE v2 exposes the same syntax","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-20T15:24:33Z","receivedAt":"2017-07-20T15:24:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> For someone not familiar with PCRE or having read its own\n> documentation this isn't obvious, let's explicitly mention it so\n> package maintainers won't fear upgrading least they break things for\n> their users.\n\nIf packagers trust our assessment on one external library's backward\ncompatibility, our using and recommending it is sufficient to them.\nIf the don't trust us but rather want to verify themselves, the new\nparagraph is not all that useful to them, and more importantly, we\nare not in the position or business of giving extended warranty to\nother people's library.\n\nFor these reasons, I'd feel a bit hesitant to add something like\nthis.\n\n>\n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> Documentation/RelNotes/2.14.0.txt | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\n> index 7ed93bca37..0e363f2af3 100644\n> --- a/Documentation/RelNotes/2.14.0.txt\n> +++ b/Documentation/RelNotes/2.14.0.txt\n> @@ -28,6 +28,9 @@ Backward compatibility notes and other notable changes.\n> upstream PCRE maintainer has abandoned v1 maintenance for all but\n> the most critical bug fixes, use of v2 is recommended.\n> \n> + Version v2 of the library is fully backwards compatible with the\n> + Perl-compatible regular expression syntax exposed by git (sans a\n> + few obscure bugfixes).\n> \n> Updates since v2.13\n> -------------------\n"},{"id":"324810","messageId":"xmqqvamnku3b.fsf@gitster.mtv.corp.google.com","threadId":"46429","inReplyTo":"20170720141927.18274-6-avarab@gmail.com","subject":"Re: [PATCH 5/6] RelNotes: remove duplicate mention of PCRE v2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-20T15:26:32Z","receivedAt":"2017-07-20T15:26:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> That we can link to PCRE v2 is already covered above in \"Backward\n> compatibility notes and other notable changes\", no need to mention it\n> twice.\n\nThis is actually deliberate, as I'd prefer to have a description\nthat is written at the same detail-level (i.e. \"just a bullet item,\nif you want to know more, go read the doc\") as the other items in\nthe list, whether a more detailed description is given elsewhere.\n\n\n\n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> Documentation/RelNotes/2.14.0.txt | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\n> index 0e363f2af3..fb6a3dba31 100644\n> --- a/Documentation/RelNotes/2.14.0.txt\n> +++ b/Documentation/RelNotes/2.14.0.txt\n> @@ -88,8 +88,7 @@ UI, Workflows & Features\n> learned to say \"it's a pathspec\" a bit more often when the syntax\n> looks like so.\n> \n> - * Update \"perl-compatible regular expression\" support to enable JIT\n> - and also allow linking with the newer PCRE v2 library.\n> + * Update \"perl-compatible regular expression\" support to enable JIT.\n> \n> * \"filter-branch\" learned a pseudo filter \"--setup\" that can be used\n> to define common functions/variables that can be used by other\n"},{"id":"324824","messageId":"xmqqbmoely9l.fsf@gitster.mtv.corp.google.com","threadId":"46429","inReplyTo":"20170720141927.18274-7-avarab@gmail.com","subject":"Re: [PATCH 6/6] RelNotes: add more notes about PCRE in 2.14","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-20T19:11:02Z","receivedAt":"2017-07-20T19:11:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> We were missing any mention that:\n>\n> - PCRE is now faster with JIT\n> - That it's now faster than the other regex backends\n> - That therefore you might want to use it by default, but beware of\n> the incompatible syntax.\n\nHmph. All of that has been more or less deliberate, as I want the\nrelease notes to be more like table of contents, one bullet per item\nwith short description, not a novelette with one paragraph per item.\n\nThese should already be in the documentation when they do want to\ndecide if they want to use JIT; somebody who downloads 2.15 or later\nand wants to decide if they want JIT shouldn't have to dig down to\nearlier release notes that introduced the option for the first time.\n\n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> Documentation/RelNotes/2.14.0.txt | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n>\n> diff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt\n> index fb6a3dba31..a6a1cb963b 100644\n> --- a/Documentation/RelNotes/2.14.0.txt\n> +++ b/Documentation/RelNotes/2.14.0.txt\n> @@ -88,7 +88,16 @@ UI, Workflows & Features\n> learned to say \"it's a pathspec\" a bit more often when the syntax\n> looks like so.\n> \n> - * Update \"perl-compatible regular expression\" support to enable JIT.\n> + * Update \"perl-compatible regular expression\" support to enable\n> + JIT.\n> +\n> + This makes grep.patternType=perl (and -P and --perl-regexp) much\n> + faster for \"git grep\" and \"git log\", and is generally faster than\n> + the system's POSIX regular expression implementation. Users\n> + concerned with \"git grep\" performance or \"git log --grep\"\n> + performance might want to try setting grep.patternType=perl. Note\n> + that the syntax isn't compatible with git's default of\n> + grep.patternType=basic.\n> \n> * \"filter-branch\" learned a pseudo filter \"--setup\" that can be used\n> to define common functions/variables that can be used by other\n"},{"id":"324835","messageId":"xmqqshhqkfrs.fsf@gitster.mtv.corp.google.com","threadId":"46429","inReplyTo":"20170720141927.18274-1-avarab@gmail.com","subject":"Re: [PATCH 0/6] 2.14 RelNotes improvements","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-20T20:35:51Z","receivedAt":"2017-07-20T20:36:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> Here's a few patches to improve the relnotes. I started just writing\n> 6/6 since I think (I don't care about the wording) that we should in\n> some way mention the items in the list in the 6/6 commit message.\n>\n> Along the way I noticed a few more missing things.\n>\n> Ævar Arnfjörð Bjarmason (6):\n> RelNotes: mention \"log: add -P as a synonym for --perl-regexp\"\n> RelNotes: mention \"log: make --regexp-ignore-case work with\n> --perl-regexp\"\n> RelNotes: mention \"sha1dc: optionally use sha1collisiondetection as a\n> submodule\"\n> RelNotes: mention that PCRE v2 exposes the same syntax\n> RelNotes: remove duplicate mention of PCRE v2\n> RelNotes: add more notes about PCRE in 2.14\n\nThanks. 1-3/6 went straight to 'master'. I am not outright\nrejecting the remainder, but I do not think these are release notes\nmaterial---if they need to be told, they should be in a part of the\nregular documentation, and I suspect that they already are in your\nseries.\n"},{"id":"324857","messageId":"87pocuoxv8.fsf@gmail.com","threadId":"46429","inReplyTo":"xmqqshhqkfrs.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 0/6] 2.14 RelNotes improvements","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-07-21T11:03:39Z","receivedAt":"2017-07-21T11:03:48Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Jul 20 2017, Junio C. Hamano jotted:\n\n> Ævar Arnfjörð Bjarmason writes:\n>\n>> Here's a few patches to improve the relnotes. I started just writing\n>> 6/6 since I think (I don't care about the wording) that we should in\n>> some way mention the items in the list in the 6/6 commit message.\n>>\n>> Along the way I noticed a few more missing things.\n>>\n>> Ævar Arnfjörð Bjarmason (6):\n>> RelNotes: mention \"log: add -P as a synonym for --perl-regexp\"\n>> RelNotes: mention \"log: make --regexp-ignore-case work with\n>> --perl-regexp\"\n>> RelNotes: mention \"sha1dc: optionally use sha1collisiondetection as a\n>> submodule\"\n>> RelNotes: mention that PCRE v2 exposes the same syntax\n>> RelNotes: remove duplicate mention of PCRE v2\n>> RelNotes: add more notes about PCRE in 2.14\n>\n> Thanks. 1-3/6 went straight to 'master'. I am not outright\n> rejecting the remainder, but I do not think these are release notes\n> material---if they need to be told, they should be in a part of the\n> regular documentation, and I suspect that they already are in your\n> series.\n\nThanks. I agree that 4-6 are better left to the docs. I wasn't very\nfamiliar with the format of the release notes / what you preferref to\nlist there & how.\n\nI'll integrate what 6/6 mentions with my nascent gitperformance.txt\nseries.\n"}]}