{"thread":{"id":"46408","subject":"[PATCH] doc: camelCase the i18n config variables to improve readability","startedAt":"2017-07-17T15:38:54Z","lastAt":"2017-07-17T22:12:46Z","messageCount":2,"participants":["Kaartic Sivaraam","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"324645","messageId":"20170717153900.16666-1-kaarticsivaraam91196@gmail.com","threadId":"46408","inReplyTo":null,"subject":"[PATCH] doc: camelCase the i18n config variables to improve readability","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-17T15:39:00Z","receivedAt":"2017-07-17T15:38:54Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"The i18n config variable used weren't readable as they were in\nthe crude form of how git stores/uses it's config variables.\n\nImprove it's readability by replacing them with camelCased versions\nof config variables as it doesn't have any impact on it's usage.\n\nSigned-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>\n---\n Documentation/i18n.txt | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/i18n.txt b/Documentation/i18n.txt\nindex 2dd79db5c..7e36e5b55 100644\n--- a/Documentation/i18n.txt\n+++ b/Documentation/i18n.txt\n@@ -42,11 +42,11 @@ mind.\n +\n ------------\n [i18n]\n-\tcommitencoding = ISO-8859-1\n+\tcommitEncoding = ISO-8859-1\n ------------\n +\n Commit objects created with the above setting record the value\n-of `i18n.commitencoding` in its `encoding` header.  This is to\n+of `i18n.commitEncoding` in its `encoding` header.  This is to\n help other people who look at them later.  Lack of this header\n implies that the commit log message is encoded in UTF-8.\n \n@@ -54,15 +54,15 @@ implies that the commit log message is encoded in UTF-8.\n   `encoding` header of a commit object, and try to re-code the\n   log message into UTF-8 unless otherwise specified.  You can\n   specify the desired output encoding with\n-  `i18n.logoutputencoding` in `.git/config` file, like this:\n+  `i18n.logOutputEncoding` in `.git/config` file, like this:\n +\n ------------\n [i18n]\n-\tlogoutputencoding = ISO-8859-1\n+\tlogOutputEncoding = ISO-8859-1\n ------------\n +\n If you do not have this configuration variable, the value of\n-`i18n.commitencoding` is used instead.\n+`i18n.commitEncoding` is used instead.\n \n Note that we deliberately chose not to re-code the commit log\n message when a commit is made to force UTF-8 at the commit\n-- \n2.13.3.973.gaaf39e6bd.dirty\n\n"},{"id":"324689","messageId":"xmqqiniqg1bc.fsf@gitster.mtv.corp.google.com","threadId":"46408","inReplyTo":"20170717153900.16666-1-kaarticsivaraam91196@gmail.com","subject":"Re: [PATCH] doc: camelCase the i18n config variables to improve readability","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-17T22:12:39Z","receivedAt":"2017-07-17T22:12:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:\n\n> The i18n config variable used weren't readable as they were in\n> the crude form of how git stores/uses it's config variables.\n>\n> Improve it's readability by replacing them with camelCased versions\n> of config variables as it doesn't have any impact on it's usage.\n>\n> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>\n> ---\n\nThanks; this makes sense.\n\n>  Documentation/i18n.txt | 10 +++++-----\n>  1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/Documentation/i18n.txt b/Documentation/i18n.txt\n> index 2dd79db5c..7e36e5b55 100644\n> --- a/Documentation/i18n.txt\n> +++ b/Documentation/i18n.txt\n> @@ -42,11 +42,11 @@ mind.\n>  +\n>  ------------\n>  [i18n]\n> -\tcommitencoding = ISO-8859-1\n> +\tcommitEncoding = ISO-8859-1\n>  ------------\n>  +\n>  Commit objects created with the above setting record the value\n> -of `i18n.commitencoding` in its `encoding` header.  This is to\n> +of `i18n.commitEncoding` in its `encoding` header.  This is to\n>  help other people who look at them later.  Lack of this header\n>  implies that the commit log message is encoded in UTF-8.\n>  \n> @@ -54,15 +54,15 @@ implies that the commit log message is encoded in UTF-8.\n>    `encoding` header of a commit object, and try to re-code the\n>    log message into UTF-8 unless otherwise specified.  You can\n>    specify the desired output encoding with\n> -  `i18n.logoutputencoding` in `.git/config` file, like this:\n> +  `i18n.logOutputEncoding` in `.git/config` file, like this:\n>  +\n>  ------------\n>  [i18n]\n> -\tlogoutputencoding = ISO-8859-1\n> +\tlogOutputEncoding = ISO-8859-1\n>  ------------\n>  +\n>  If you do not have this configuration variable, the value of\n> -`i18n.commitencoding` is used instead.\n> +`i18n.commitEncoding` is used instead.\n>  \n>  Note that we deliberately chose not to re-code the commit log\n>  message when a commit is made to force UTF-8 at the commit\n"}]}