{"thread":{"id":"46313","subject":"Requesting suggestions for a good sample \"prepare-commit-msg\" hook","startedAt":"2017-07-05T16:46:05Z","lastAt":"2017-07-06T03:28:16Z","messageCount":6,"participants":["Kaartic Sivaraam","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"323841","messageId":"1499273152.16389.2.camel@gmail.com","threadId":"46313","inReplyTo":null,"subject":"Requesting suggestions for a good sample \"prepare-commit-msg\" hook","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-05T16:45:52Z","receivedAt":"2017-07-05T16:46:05Z","isPatch":false,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"Hello all,\n\nThere's an attempt in progress to replace the part of the sample\n\"prepare-commit-msg\" hook that comments the \"Conflicts\" part of a merge\ncommit message. This is being done as the \"Conflicts\" portion is\ncommented by default for quite some time (since 2014) and thus the\nscript in the hook is useless.\n\nIt's worth noting that it was the only part of the sample hook that\n*wasn't* commented by default i.e., it was the only portion of the\nsample hook that could be used just by enabling it by renaming the\nhook. So, just removing that portion of the solution wouldn't be a\nsolution as it wouldn't be nice to have a whole sample hook to be\ncommented for various reasons. So, we're searching for scripts that\ncould both be helpful to users and could serve as a good sample to\nprove what could be done using the hooks.\n\nIn case anyone has any suggestions about what could prove to be an\nalternative please send them in!\n\n-- \nKaartic\n"},{"id":"323843","messageId":"xmqqwp7miztv.fsf@gitster.mtv.corp.google.com","threadId":"46313","inReplyTo":"1499273152.16389.2.camel@gmail.com","subject":"Re: Requesting suggestions for a good sample \"prepare-commit-msg\" hook","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-05T17:00:12Z","receivedAt":"2017-07-05T17:00:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kaartic Sivaraam writes:\n\n> So, we're searching for scripts that\n> could both be helpful to users and could serve as a good sample to\n> prove what could be done using the hooks.\n\nI am not so sure that we are searching for them, to be honest (who\nare we in this context anyway?) \n\nThis sounds like a solution looking for a problem to me. The\nsimplest option may be to remove the sample hook---perhaps it\noutlived its usefulness.\n"},{"id":"323848","messageId":"1499275601.16389.6.camel@gmail.com","threadId":"46313","inReplyTo":"xmqqwp7miztv.fsf@gitster.mtv.corp.google.com","subject":"Re: Requesting suggestions for a good sample \"prepare-commit-msg\" hook","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-05T17:26:41Z","receivedAt":"2017-07-05T17:26:55Z","isPatch":false,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"On Wed, 2017-07-05 at 10:00 -0700, Junio C Hamano wrote:\n> Kaartic Sivaraam writes:\n> \n> > So, we're searching for scripts that\n> > could both be  helpful to users and could serve as a good sample to\n> > prove what could be done using the hooks.\n> \n> I am not so sure that we are searching for them, to be honest (who\n> are we in this context anyway?)\nI think I misinterpreted your sentence in one of the other mails (found\nbelow),\n\n That sounds like a sample that is there not because it would be\n useful, but because we couldn't think of any useful example.\n\n\n> This sounds like a solution looking for a problem to me.  The\n> simplest option may be to remove the sample hook---perhaps it\n> outlived its usefulness.\nRemoving it is going to be done for sure. I thought it would be even\nbetter to replace it for the reasons I specified previously. Anyways,\nin case the last path I sent[1] seems not to be useful and not other\ninteresting alternatives turn up in this thread then the \"simplest\noption\" has to be chosen.\n\n\n[1]: http://public-inbox.org/git/20170705165114.20662-1-kaarticsivaraam91196@gmail.com/raw\n\n-- \nKaartic\n"},{"id":"323858","messageId":"1499278787.1791.2.camel@gmail.com","threadId":"46313","inReplyTo":"1499275601.16389.6.camel@gmail.com","subject":"Re: Requesting suggestions for a good sample \"prepare-commit-msg\" hook","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-05T18:19:47Z","receivedAt":"2017-07-05T18:19:49Z","isPatch":false,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"> On Wed, 2017-07-05 at 10:00 -0700, Junio C Hamano wrote:\n> > I am not so sure that we are searching for them, to be honest (who\n> > are we in this context anyway?)\n> \nImagining HTML could be used in plain-text,\n\n I think I misinterpreted your sentence in one of the other\nmails (found below), Sorry for that sloppy sentence. More\ncorrectly, the \"we\" in that context is the same as the \"we\" in the\ncontext of the text quoted below,\n\n>     That sounds like a sample that is there not because it would be\n>     useful, but because we couldn't think of any useful example.\n> \n\nLink to the post that has the quoted text,\nhttp://public-inbox.org/git/%3Cxmqqy3s7nbkm.fsf@gitster.mtv.corp.google.com%3E/\n"},{"id":"323862","messageId":"xmqqzicihesv.fsf@gitster.mtv.corp.google.com","threadId":"46313","inReplyTo":"1499278787.1791.2.camel@gmail.com","subject":"Re: Requesting suggestions for a good sample \"prepare-commit-msg\" hook","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-05T19:19:44Z","receivedAt":"2017-07-05T19:19:54Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kaartic Sivaraam writes:\n\n>> On Wed, 2017-07-05 at 10:00 -0700, Junio C Hamano wrote:\n>> > I am not so sure that we are searching for them, to be honest (who\n>> > are we in this context anyway?)\n>> \n> Imagining HTML could be used in plain-text,\n>\n> I think I misinterpreted your sentence in one of the other\n> mails (found below), Sorry for that sloppy sentence. More\n> correctly, the \"we\" in that context is the same as the \"we\" in the\n> context of the text quoted below,\n>\n>> That sounds like a sample that is there not because it would be\n>> useful, but because we couldn't think of any useful example.\n>> \n>\n> Link to the post that has the quoted text,\n> http://public-inbox.org/git/%3Cxmqqy3s7nbkm.fsf@gitster.mtv.corp.google.com%3E/\n\nI honestly do not see your point. Yes, I said that the change\nindicates that there is no useful example found (so far). That does\nnot necessarily mean that we must find a useful example so that we\ncan keep this sample script, which now became useless, alive. \n\nI am questioning the assumption that it helps users to have a sample\nfor prepare-commit-msg shipped with our source, and I suspect that\nit may no longer be true. If the sole purpose of finding a useful\nexample is to keep the sample script alive, when the sample script\nis no longer a useful thing to ship, then it does sound like \"a\nsolution looking for a problem\", no?\n\n"},{"id":"323883","messageId":"1499311692.1776.3.camel@gmail.com","threadId":"46313","inReplyTo":"xmqqzicihesv.fsf@gitster.mtv.corp.google.com","subject":"Re: Requesting suggestions for a good sample \"prepare-commit-msg\" hook","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-06T03:28:12Z","receivedAt":"2017-07-06T03:28:16Z","isPatch":false,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"On Wed, 2017-07-05 at 12:19 -0700, Junio C Hamano wrote:\n> I honestly do not see your point.  Yes, I said that the change\n> indicates that there is no useful example found (so far).  That does\n> not necessarily mean that we must find a useful example so that we\n> can keep this sample script, which now became useless, alive.  \n> \n> I am questioning the assumption that it helps users to have a sample\n> for prepare-commit-msg shipped with our source, and I suspect that\n> it may no longer be true.  If the sole purpose of finding a useful\n> example is to keep the sample script alive, when the sample script\n> is no longer a useful thing to ship, then it does sound like \"a\n> solution looking for a problem\", no?\n> \nAh, now I see your point. When you said \"it's no longer useful\", I\nthought you were mentioning only the part of the script that commented\nthe sign-off. Now I get that your point of not shipping the sample\nscript itself. Now that clears the confusion and sorry for the\nconfusion I may have caused.\n\n-- \nKaartic\n"}]}