{"thread":{"id":"46268","subject":"Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)","startedAt":"2017-06-27T13:31:32Z","lastAt":"2017-06-28T12:31:13Z","messageCount":4,"participants":["Robert Siemer","Junio C Hamano","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"323333","messageId":"0d924a0671b642d2b8ba79af8d4fa0d7@rohde-schwarz.com","threadId":"46268","inReplyTo":null,"subject":"Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)","fromName":"Robert Siemer","fromEmail":"robert.siemer@rohde-schwarz.com","sentAt":"2017-06-27T13:16:01Z","receivedAt":"2017-06-27T13:31:32Z","isPatch":false,"sender":{"key":"robert.siemer@rohde-schwarz.com","avatar":null},"body":"\nHello everyone,\n\n$ git submodule foreach cat .git\n\n...shows that the gitdir registered in the .git file of submodules is relative. But if you run \n\n$ git submodule foreach --recursive cat .git\n\n...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.\n\n1) Can you confirm that behavior?\n2) Am I right that this is a bug (at least because of inconsistency)?\n\n\nRegards,\nRobert\n"},{"id":"323336","messageId":"xmqqr2y531xv.fsf@gitster.mtv.corp.google.com","threadId":"46268","inReplyTo":"0d924a0671b642d2b8ba79af8d4fa0d7@rohde-schwarz.com","subject":"Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-27T15:06:20Z","receivedAt":"2017-06-27T15:07:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robert Siemer writes:\n\n> Hello everyone,\n>\n> $ git submodule foreach cat .git\n>\n> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run \n>\n> $ git submodule foreach --recursive cat .git\n>\n> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.\n>\n> 1) Can you confirm that behavior?\n\nNobody can without knowing which version of Git you are using. I\nsuspect that we had discussed and addressed something related to\nnested submodule's \"gitdir\" pointer in not-so-distant past.\n\n> 2) Am I right that this is a bug (at least because of inconsistency)?\n\n"},{"id":"323354","messageId":"CAGZ79kZmV9Aufrsmf1iohhP5qHzA4AZ3DDv8sn1GMaCZ+SbV5Q@mail.gmail.com","threadId":"46268","inReplyTo":"xmqqr2y531xv.fsf@gitster.mtv.corp.google.com","subject":"Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-06-27T17:35:15Z","receivedAt":"2017-06-27T17:35:21Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano wrote:\n> Robert Siemer writes:\n>\n>> Hello everyone,\n>>\n>> $ git submodule foreach cat .git\n>>\n>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run\n>>\n>> $ git submodule foreach --recursive cat .git\n>>\n>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.\n>>\n>> 1) Can you confirm that behavior?\n>\n> Nobody can without knowing which version of Git you are using. I\n> suspect that we had discussed and addressed something related to\n> nested submodule's \"gitdir\" pointer in not-so-distant past.\n\nYeah there was a period in time where we had this bug.\n(Or is it a different bug?)\nSee 90c0011619 (submodule: use absolute path for computing\nrelative path connecting, 2016-12-08), which is included in 2.12.\n"},{"id":"323422","messageId":"a8e69eac41e747f79f8aba335f995d69@rohde-schwarz.com","threadId":"46268","inReplyTo":"a882773a8f0f4632a204090baa0f182b@rohde-schwarz.com","subject":"Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)","fromName":"Robert Siemer","fromEmail":"robert.siemer@rohde-schwarz.com","sentAt":"2017-06-28T12:30:20Z","receivedAt":"2017-06-28T12:31:13Z","isPatch":false,"sender":{"key":"robert.siemer@rohde-schwarz.com","avatar":null},"body":"\nI had the problem with version 2.7.4.\n\nThe problem is fixed in self-compiled v2.13.2.533.ge0aaa1bed, v2.12.0, v2.11.0 and v2.9.3! Even the older version 2.1.4 does not have that problem.\n\nThank you for the input!\n\nRobert\n\n\n\n________________________________________\nFrom: Siemer Robert CSNPE\nSent: Wednesday, June 28, 2017 14:09\nTo: Stefan Beller; Junio C Hamano\nCc: git@vger.kernel.org\nSubject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)\n\n________________________________________\nFrom: Stefan Beller \nSent: Tuesday, June 27, 2017 19:35\nTo: Junio C Hamano\nCc: Siemer Robert CSNPE; git@vger.kernel.org\nSubject: Re: Bug: submodules of submodules use absolute gitdir in .git file (instead of relative)\n\nOn Tue, Jun 27, 2017 at 8:06 AM, Junio C Hamano wrote:\n> Robert Siemer writes:\n>\n>> Hello everyone,\n>>\n>> $ git submodule foreach cat .git\n>>\n>> ...shows that the gitdir registered in the .git file of submodules is relative. But if you run\n>>\n>> $ git submodule foreach --recursive cat .git\n>>\n>> ...shows that submodules of submodules (if you have any) have an absolute gitdir starting with a slash.\n>>\n>> 1) Can you confirm that behavior?\n>\n> Nobody can without knowing which version of Git you are using. I\n> suspect that we had discussed and addressed something related to\n> nested submodule's \"gitdir\" pointer in not-so-distant past.\n\nYeah there was a period in time where we had this bug.\n(Or is it a different bug?)\nSee 90c0011619 (submodule: use absolute path for computing\nrelative path connecting, 2016-12-08), which is included in 2.12.\n\n"}]}