{"thread":{"id":"46267","subject":"Solaris 11.3 SPARC grep problem with t1450-fsck.sh","startedAt":"2017-06-27T12:16:13Z","lastAt":"2017-06-28T17:15:28Z","messageCount":4,"participants":["Michael Kebe","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"323328","messageId":"CAKKM46uJLu+w-UUFZc1HRar3apAD6Db2KD+GjiNL5v+Q2Ni7hA@mail.gmail.com","threadId":"46267","inReplyTo":null,"subject":"Solaris 11.3 SPARC grep problem with t1450-fsck.sh","fromName":"Michael Kebe","fromEmail":"michael.kebe@gmail.com","sentAt":"2017-06-27T12:15:43Z","receivedAt":"2017-06-27T12:16:13Z","isPatch":false,"sender":{"key":"michael.kebe@gmail.com","avatar":null},"body":"Running the test suite on Solaris 11.3 SPARC fails on a test in t1450-fsck.sh.\n\nnot ok 60 - fsck --name-objects\n#\n#               rm -rf name-objects &&\n#               git init name-objects &&\n#               (\n#                       cd name-objects &&\n#                       test_commit julius caesar.t &&\n#                       test_commit augustus &&\n#                       test_commit caesar &&\n#                       remove_object $(git rev-parse julius:caesar.t) &&\n#                       test_must_fail git fsck --name-objects >out &&\n#                       tree=$(git rev-parse --verify julius:) &&\n#                       grep \"$tree (\\(refs/heads/master\\|HEAD\\)@{[0-9]*}:\" out\n#               )\n\nSolaris has /usr/bin/grep and /usr/bin/ggrep. grep is a solaris\nversion and ggrep is the GNU grep.\n\nReplacing grep with ggrep in t1450-fsck.sh script the fixes the problem.\n\nI chatted with Ævar and he thinks that the problem is that configure\nfinds the right grep but it is not properly passed to the tests.\n\n\nFurthermore I discovered that some tests in t3900-i18n-commit.sh are failing.\n\ne.g.: not ok 17 - ISO-2022-JP should be shown in UTF-8 now\n\nBut that's another topic, which I will open once this is fixed.\n\nGreetings\nMichael\n"},{"id":"323344","messageId":"xmqqa84t2yaa.fsf@gitster.mtv.corp.google.com","threadId":"46267","inReplyTo":"CAKKM46uJLu+w-UUFZc1HRar3apAD6Db2KD+GjiNL5v+Q2Ni7hA@mail.gmail.com","subject":"Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-27T16:25:17Z","receivedAt":"2017-06-27T16:25:24Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael Kebe <michael.kebe@gmail.com> writes:\n\n> Running the test suite on Solaris 11.3 SPARC fails on a test in t1450-fsck.sh.\n>\n> not ok 60 - fsck --name-objects\n> #\n> #               rm -rf name-objects &&\n> #               git init name-objects &&\n> #               (\n> #                       cd name-objects &&\n> #                       test_commit julius caesar.t &&\n> #                       test_commit augustus &&\n> #                       test_commit caesar &&\n> #                       remove_object $(git rev-parse julius:caesar.t) &&\n> #                       test_must_fail git fsck --name-objects >out &&\n> #                       tree=$(git rev-parse --verify julius:) &&\n> #                       grep \"$tree (\\(refs/heads/master\\|HEAD\\)@{[0-9]*}:\" out\n> #               )\n>\n> Solaris has /usr/bin/grep and /usr/bin/ggrep. grep is a solaris\n> version and ggrep is the GNU grep.\n\nWe do not need GNUism, but many tools that come in /usr/bin have\nbeen found unfit.  I thought that Solaris users were expected to set\nSANE_TOOL_PATH to point at /usr/xpg[46]/bin to avoid this problem.\n\nAh, wait, that particular grep may have GNUism.  If you changed it\nto\n\n    egrep \"$tree \\((refs/heads/master|HEAD)@{[0-9]*}:\" out\n\ndoes it make it pass for you?\n"},{"id":"323417","messageId":"CAKKM46ureAZNB-YjOrmi+H-_tf3hXGS7dA7o=dj8bnHc+8ABng@mail.gmail.com","threadId":"46267","inReplyTo":"xmqqa84t2yaa.fsf@gitster.mtv.corp.google.com","subject":"Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh","fromName":"Michael Kebe","fromEmail":"michael.kebe@gmail.com","sentAt":"2017-06-28T06:00:24Z","receivedAt":"2017-06-28T06:00:53Z","isPatch":false,"sender":{"key":"michael.kebe@gmail.com","avatar":null},"body":"2017-06-27 18:25 GMT+02:00 Junio C Hamano <gitster@pobox.com>:\n> Ah, wait, that particular grep may have GNUism.  If you changed it\n> to\n>\n>     egrep \"$tree \\((refs/heads/master|HEAD)@{[0-9]*}:\" out\n>\n> does it make it pass for you?\n\nYes, this is working.\n\nGreetings\nMichael\n"},{"id":"323433","messageId":"xmqqo9t8vxsm.fsf@gitster.mtv.corp.google.com","threadId":"46267","inReplyTo":"CAKKM46ureAZNB-YjOrmi+H-_tf3hXGS7dA7o=dj8bnHc+8ABng@mail.gmail.com","subject":"Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-28T17:15:21Z","receivedAt":"2017-06-28T17:15:28Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael Kebe <michael.kebe@gmail.com> writes:\n\n> 2017-06-27 18:25 GMT+02:00 Junio C Hamano <gitster@pobox.com>:\n>> Ah, wait, that particular grep may have GNUism.  If you changed it\n>> to\n>>\n>>     egrep \"$tree \\((refs/heads/master|HEAD)@{[0-9]*}:\" out\n>>\n>> does it make it pass for you?\n>\n> Yes, this is working.\n\nThanks.\n"}]}