{"thread":{"id":"46194","subject":"[PATCH v2] wildmatch test: cover a blind spot in \"/\" matching","startedAt":"2017-06-15T21:11:01Z","lastAt":"2017-06-15T22:01:20Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"322399","messageId":"20170615211041.22768-1-avarab@gmail.com","threadId":"46194","inReplyTo":"CAPc5daWy3eq-ODwDSbvhvRPH87QR0WMttZQUhmKfcZxs4qvdaQ@mail.gmail.com","subject":"[PATCH v2] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-06-15T21:10:41Z","receivedAt":"2017-06-15T21:11:01Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"A negated character class that does not include '/', e.g. [^a-z]:\n\n - Should match '/' when doing \"wildmatch\"\n - Should not match '/' when doing \"pathmatch\"\n\nAdd two tests to cover these cases.\n\nHelped-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nNow with updated commit message, no other changes. Sorry about the\ndelay.\n\n t/t3070-wildmatch.sh | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh\nindex 7ca69f4bed..8fd70d3aa2 100755\n--- a/t/t3070-wildmatch.sh\n+++ b/t/t3070-wildmatch.sh\n@@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'\n match 1 0 'foo/bar' 'foo/**/**/bar'\n match 0 0 'foo/bar' 'foo?bar'\n match 0 0 'foo/bar' 'foo[/]bar'\n+match 0 0 'foo/bar' 'foo[^a-z]bar'\n match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n match 1 0 'foo' '**/foo'\n@@ -225,6 +226,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'\n pathmatch 0 foo/bba/arr 'foo/**z'\n pathmatch 1 foo/bar 'foo?bar'\n pathmatch 1 foo/bar 'foo[/]bar'\n+pathmatch 1 foo/bar 'foo[^a-z]bar'\n pathmatch 0 foo '*/*/*'\n pathmatch 0 foo/bar '*/*/*'\n pathmatch 1 foo/bba/arr '*/*/*'\n-- \n2.13.1.508.gb3defc5cc\n\n"},{"id":"322407","messageId":"xmqq60fwzz9y.fsf@gitster.mtv.corp.google.com","threadId":"46194","inReplyTo":"20170615211041.22768-1-avarab@gmail.com","subject":"Re: [PATCH v2] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-15T22:01:13Z","receivedAt":"2017-06-15T22:01:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:\n\n> A negated character class that does not include '/', e.g. [^a-z]:\n>\n>  - Should match '/' when doing \"wildmatch\"\n>  - Should not match '/' when doing \"pathmatch\"\n>\n> Add two tests to cover these cases.\n>\n> Helped-by: Junio C Hamano <gitster@pobox.com>\n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n>\n> Now with updated commit message, no other changes. Sorry about the\n> delay.\n\nThanks.  I completely forgot about this topic ;-)\n\n>\n>  t/t3070-wildmatch.sh | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh\n> index 7ca69f4bed..8fd70d3aa2 100755\n> --- a/t/t3070-wildmatch.sh\n> +++ b/t/t3070-wildmatch.sh\n> @@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'\n>  match 1 0 'foo/bar' 'foo/**/**/bar'\n>  match 0 0 'foo/bar' 'foo?bar'\n>  match 0 0 'foo/bar' 'foo[/]bar'\n> +match 0 0 'foo/bar' 'foo[^a-z]bar'\n>  match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n>  match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n>  match 1 0 'foo' '**/foo'\n> @@ -225,6 +226,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'\n>  pathmatch 0 foo/bba/arr 'foo/**z'\n>  pathmatch 1 foo/bar 'foo?bar'\n>  pathmatch 1 foo/bar 'foo[/]bar'\n> +pathmatch 1 foo/bar 'foo[^a-z]bar'\n>  pathmatch 0 foo '*/*/*'\n>  pathmatch 0 foo/bar '*/*/*'\n>  pathmatch 1 foo/bba/arr '*/*/*'\n"}]}