{"thread":{"id":"46184","subject":"Subject: [PATCH] config: mark a file-local symbol as static","startedAt":"2017-06-15T01:20:28Z","lastAt":"2017-06-17T22:00:38Z","messageCount":3,"participants":["Ramsay Jones","Sahil Dua"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"322291","messageId":"7d11fa4e-232b-8741-504f-ab4e3e788130@ramsayjones.plus.com","threadId":"46184","inReplyTo":null,"subject":"Subject: [PATCH] config: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-06-15T01:20:20Z","receivedAt":"2017-06-15T01:20:28Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi Sahil,\n\nIf you need to re-roll your 'sd/branch-copy' branch, could you please\nsquash this into the relevant patch (commit 37af9c71b6, \"config: create\na function to format section headers\", 13-06-2017).\n\nAlso, I note that another patch in that branch (commit fd44da469c,\n\"branch: add a --copy (-c) option to go with --move (-m)\", 13-06-2017),\nadds a couple of external symbols which, currently, don't need to be\nexternally visible. Is it intended that git_config_copy_section_in_file()\nand refs_copy_existing_ref() be part of the public API?\n\nThanks!\n\nATB,\nRamsay Jones\n\n config.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/config.c b/config.c\nindex 2996e6d56..fbba17483 100644\n--- a/config.c\n+++ b/config.c\n@@ -2173,7 +2173,7 @@ static int write_error(const char *filename)\n \treturn 4;\n }\n \n-struct strbuf store_create_section(const char *key)\n+static struct strbuf store_create_section(const char *key)\n {\n \tconst char *dot;\n \tint i;\n-- \n2.13.0\n"},{"id":"322507","messageId":"CALiud+nZj4f1=puzXC6grfStg-tQLMGpr-dAdtNwphyvts5KmA@mail.gmail.com","threadId":"46184","inReplyTo":"7d11fa4e-232b-8741-504f-ab4e3e788130@ramsayjones.plus.com","subject":"Re: Subject: [PATCH] config: mark a file-local symbol as static","fromName":"Sahil Dua","fromEmail":"sahildua2305@gmail.com","sentAt":"2017-06-17T21:40:42Z","receivedAt":"2017-06-17T21:41:09Z","isPatch":true,"sender":{"key":"sahildua2305@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5206277?v=4"},"body":"Hi Ramsay,\n\nThanks for noticing. I will squash this into the relevant patch.\n\nAlso, git_config_copy_section_in_file() and refs_copy_existing_ref()\ndon't need to be available in public API.\nRegards\nSahil Dua\nGraduate Software Developer\nBooking.com\nConnect on LinkedIn\nwww.sahildua.com\n\n\nOn Thu, Jun 15, 2017 at 3:20 AM, Ramsay Jones\n wrote:\n>\n> Signed-off-by: Ramsay Jones \n> ---\n>\n> Hi Sahil,\n>\n> If you need to re-roll your 'sd/branch-copy' branch, could you please\n> squash this into the relevant patch (commit 37af9c71b6, \"config: create\n> a function to format section headers\", 13-06-2017).\n>\n> Also, I note that another patch in that branch (commit fd44da469c,\n> \"branch: add a --copy (-c) option to go with --move (-m)\", 13-06-2017),\n> adds a couple of external symbols which, currently, don't need to be\n> externally visible. Is it intended that git_config_copy_section_in_file()\n> and refs_copy_existing_ref() be part of the public API?\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n>\n> config.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/config.c b/config.c\n> index 2996e6d56..fbba17483 100644\n> --- a/config.c\n> +++ b/config.c\n> @@ -2173,7 +2173,7 @@ static int write_error(const char *filename)\n> return 4;\n> }\n>\n> -struct strbuf store_create_section(const char *key)\n> +static struct strbuf store_create_section(const char *key)\n> {\n> const char *dot;\n> int i;\n> --\n> 2.13.0\n"},{"id":"322508","messageId":"CALiud+moeCUV5HibQDK9+cgMUWBQfrAGZ6i0Jcs1SNMjzXkkiQ@mail.gmail.com","threadId":"46184","inReplyTo":"CALiud+nZj4f1=puzXC6grfStg-tQLMGpr-dAdtNwphyvts5KmA@mail.gmail.com","subject":"Re: Subject: [PATCH] config: mark a file-local symbol as static","fromName":"Sahil Dua","fromEmail":"sahildua2305@gmail.com","sentAt":"2017-06-17T22:00:12Z","receivedAt":"2017-06-17T22:00:38Z","isPatch":true,"sender":{"key":"sahildua2305@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5206277?v=4"},"body":"On Sat, Jun 17, 2017 at 11:40 PM, Sahil Dua wrote:\n> Hi Ramsay,\n>\n> Thanks for noticing. I will squash this into the relevant patch.\n>\n> Also, git_config_copy_section_in_file() and refs_copy_existing_ref()\n> don't need to be available in public API.\nI noticed that git_config_copy_section_in_file() is declared in\ncache.h already. I made it this way to keep it consistent with\nexisting git_config_rename_section_in_file().\n\nSimilarly with refs_copy_existing_ref(), it's similar to\nrefs_rename_ref() (both of these are declared in refs.h).\n>\n>\n> On Thu, Jun 15, 2017 at 3:20 AM, Ramsay Jones\n> wrote:\n>>\n>> Signed-off-by: Ramsay Jones \n>> ---\n>>\n>> Hi Sahil,\n>>\n>> If you need to re-roll your 'sd/branch-copy' branch, could you please\n>> squash this into the relevant patch (commit 37af9c71b6, \"config: create\n>> a function to format section headers\", 13-06-2017).\n>>\n>> Also, I note that another patch in that branch (commit fd44da469c,\n>> \"branch: add a --copy (-c) option to go with --move (-m)\", 13-06-2017),\n>> adds a couple of external symbols which, currently, don't need to be\n>> externally visible. Is it intended that git_config_copy_section_in_file()\n>> and refs_copy_existing_ref() be part of the public API?\n>>\n>> Thanks!\n>>\n>> ATB,\n>> Ramsay Jones\n>>\n>> config.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/config.c b/config.c\n>> index 2996e6d56..fbba17483 100644\n>> --- a/config.c\n>> +++ b/config.c\n>> @@ -2173,7 +2173,7 @@ static int write_error(const char *filename)\n>> return 4;\n>> }\n>>\n>> -struct strbuf store_create_section(const char *key)\n>> +static struct strbuf store_create_section(const char *key)\n>> {\n>> const char *dot;\n>> int i;\n>> --\n>> 2.13.0\n"}]}