{"thread":{"id":"46174","subject":"[PATCH v3] Configure Git contribution guidelines for github.com","startedAt":"2017-06-14T07:35:44Z","lastAt":"2017-06-14T17:46:58Z","messageCount":3,"participants":["Lars Schneider","Jeff King","Jonathan Nieder"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"322199","messageId":"20170614073536.45498-1-larsxschneider@gmail.com","threadId":"46174","inReplyTo":null,"subject":"[PATCH v3] Configure Git contribution guidelines for github.com","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2017-06-14T07:35:36Z","receivedAt":"2017-06-14T07:35:44Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"Many open source projects use github.com for their contribution process.\nAlthough we mirror the Git core repository to github.com [1] we do not\nuse any other github.com service. This is unknown/unexpected to a\nnumber of (potential) contributors and consequently they create Pull\nRequests against our mirror with their contributions. These Pull\nRequests become stale. This is frustrating to them as they think we\nignore them and it is also unsatisfactory for us as we miss potential\ncode improvements and/or new contributors.\n\nGitHub contribution guidelines and a GitHub Pull Request template that\nis visible to every Pull Request creator can be configured with special\nfiles in a Git repository [2]. Let's make use of this!\n\n[1] https://github.com/git/git\n[2] https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/\n\nSigned-off-by: Lars Schneider \n---\n\nHi,\n\nchanges since v2:\n* removed mailing list address, added link with mailing list explanations\n* fixed grammar nits\n\nYou can see a preview here:\nhttps://github.com/larsxschneider/git/compare/master...larsxschneider-patch-1?quick_pull=1\n\nThanks,\nLars\n\n\nNotes:\n Base Ref: master\n Web-Diff: https://github.com/larsxschneider/git/commit/ba3e711f9e\n Checkout: git fetch https://github.com/larsxschneider/git contrib-guide-v3 && git checkout ba3e711f9e\n\n Interdiff (v2..v3):\n\n diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md\n index fc397bb8fc..5a0fb679b1 100644\n --- a/.github/CONTRIBUTING.md\n +++ b/.github/CONTRIBUTING.md\n @@ -1,8 +1,8 @@\n ## Contributing to Git\n\n -Thanks for taking the time to contribute to Git! Please be advised, that the\n +Thanks for taking the time to contribute to Git! Please be advised that the\n Git community does not use github.com for their contributions. Instead, we use\n -a mailing list (git@vger.kernel.org) for code submissions, code\n +a [mailing list](https://git-scm.com/community/) for code submissions, code\n reviews, and bug reports.\n\n Nevertheless, you can use [submitGit](http://submitgit.herokuapp.com/) to\n diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md\n index 2b617f4c25..c81bfb343f 100644\n --- a/.github/PULL_REQUEST_TEMPLATE.md\n +++ b/.github/PULL_REQUEST_TEMPLATE.md\n @@ -1,7 +1,7 @@\n -Thanks for taking the time to contribute to Git! Please be advised, that the\n -Git community does not use github.com for their contributions. Instead, we use\n -a mailing list (git@vger.kernel.org) for code submissions, code reviews, and\n -bug reports. Nevertheless, you can use submitGit to conveniently send your Pull\n -Requests commits to our mailing list.\n +Thanks for taking the time to contribute to Git! Please be advised that the\n +Git community does not use github.com for their contributions. Instead,\n +we use a mailing list for code submissions, code reviews, and bug reports.\n +Nevertheless, you can use submitGit to conveniently send your Pull Requests\n +commits to our mailing list.\n\n Please read the \"guidelines for contributing\" linked above!\n\n\n .github/CONTRIBUTING.md | 19 +++++++++++++++++++\n .github/PULL_REQUEST_TEMPLATE.md | 7 +++++++\n 2 files changed, 26 insertions(+)\n create mode 100644 .github/CONTRIBUTING.md\n create mode 100644 .github/PULL_REQUEST_TEMPLATE.md\n\ndiff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md\nnew file mode 100644\nindex 0000000000..5a0fb679b1\n--- /dev/null\n+++ b/.github/CONTRIBUTING.md\n@@ -0,0 +1,19 @@\n+## Contributing to Git\n+\n+Thanks for taking the time to contribute to Git! Please be advised that the\n+Git community does not use github.com for their contributions. Instead, we use\n+a [mailing list](https://git-scm.com/community/) for code submissions, code\n+reviews, and bug reports.\n+\n+Nevertheless, you can use [submitGit](http://submitgit.herokuapp.com/) to\n+conveniently send your Pull Requests commits to our mailing list.\n+\n+Please read [\"A note from the maintainer\"](https://git.kernel.org/pub/scm/git/git.git/plain/MaintNotes?h=todo)\n+to learn how the Git project is managed, and how you can work with it.\n+In addition, we highly recommend you to read [our submission guidelines](../Documentation/SubmittingPatches).\n+\n+If you prefer video, then [this talk](https://www.youtube.com/watch?v=Q7i_qQW__q4&feature=youtu.be&t=6m4s)\n+might be useful to you as the presenter walks you through the contribution\n+process by example.\n+\n+Your friendly Git community!\ndiff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md\nnew file mode 100644\nindex 0000000000..c81bfb343f\n--- /dev/null\n+++ b/.github/PULL_REQUEST_TEMPLATE.md\n@@ -0,0 +1,7 @@\n+Thanks for taking the time to contribute to Git! Please be advised that the\n+Git community does not use github.com for their contributions. Instead,\n+we use a mailing list for code submissions, code reviews, and bug reports.\n+Nevertheless, you can use submitGit to conveniently send your Pull Requests\n+commits to our mailing list.\n+\n+Please read the \"guidelines for contributing\" linked above!\n\nbase-commit: 8d1b10321b20bd2a73a5b561cfc3cf2e8051b70b\n--\n2.13.0\n\n"},{"id":"322200","messageId":"20170614073706.htw4nwzlcejwt6g7@sigill.intra.peff.net","threadId":"46174","inReplyTo":"20170614073536.45498-1-larsxschneider@gmail.com","subject":"Re: [PATCH v3] Configure Git contribution guidelines for github.com","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-06-14T07:37:07Z","receivedAt":"2017-06-14T07:37:13Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jun 14, 2017 at 09:35:36AM +0200, Lars Schneider wrote:\n\n> changes since v2:\n> * removed mailing list address, added link with mailing list explanations\n> * fixed grammar nits\n\nThanks, this one looks good to me.\n\n-Peff\n"},{"id":"322269","messageId":"20170614174647.GV133952@aiede.mtv.corp.google.com","threadId":"46174","inReplyTo":"20170614073536.45498-1-larsxschneider@gmail.com","subject":"Re: [PATCH v3] Configure Git contribution guidelines for github.com","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-06-14T17:46:47Z","receivedAt":"2017-06-14T17:46:58Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Lars Schneider wrote:\n\n> Many open source projects use github.com for their contribution process.\n> Although we mirror the Git core repository to github.com [1] we do not\n> use any other github.com service. This is unknown/unexpected to a\n> number of (potential) contributors and consequently they create Pull\n> Requests against our mirror with their contributions. These Pull\n> Requests become stale. This is frustrating to them as they think we\n> ignore them and it is also unsatisfactory for us as we miss potential\n> code improvements and/or new contributors.\n>\n> GitHub contribution guidelines and a GitHub Pull Request template that\n> is visible to every Pull Request creator can be configured with special\n> files in a Git repository [2]. Let's make use of this!\n>\n> [1] https://github.com/git/git\n> [2] https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/\n>\n> Signed-off-by: Lars Schneider \n> ---\n> .github/CONTRIBUTING.md | 19 +++++++++++++++++++\n> .github/PULL_REQUEST_TEMPLATE.md | 7 +++++++\n> 2 files changed, 26 insertions(+)\n> create mode 100644 .github/CONTRIBUTING.md\n> create mode 100644 .github/PULL_REQUEST_TEMPLATE.md\n\nReviewed-by: Jonathan Nieder \n\nThanks.\n"}]}