{"thread":{"id":"46100","subject":"git-gui ignores core.hooksPath","startedAt":"2017-06-02T13:48:11Z","lastAt":"2018-07-10T15:30:41Z","messageCount":20,"participants":["Philipp Gortan","Samuel Lijin","Ævar Arnfjörð Bjarmason","Philip Oakley","Johannes Schindelin","Chris Maes","Junio C Hamano","Bert Wesarg","Stefan Beller","Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"321404","messageId":"953845c2-4326-608a-c342-2d2141da561c@gortan.org","threadId":"46100","inReplyTo":null,"subject":"git-gui ignores core.hooksPath","fromName":"Philipp Gortan","fromEmail":"philipp@gortan.org","sentAt":"2017-06-02T13:41:06Z","receivedAt":"2017-06-02T13:48:11Z","isPatch":false,"sender":{"key":"philipp@gortan.org","avatar":"https://gravatar.com/avatar/5f4bda0bdd4eba9541d0867858ac3453e20f03a1280d78d9c459cb793975962a?d=mp&s=160"},"body":"Hi git devs,\n\nFirst off, thanks for your awesome work!\n\nI've been unhappy for quite a while that I had to configure the hooks\nmanually for each of my repos - until I found out recently that there is\nthe core.hooksPath config variable that (when set globally) allows me to\nspecify a hooks directory to be used for all my repositories.\n\nNow I was happy - for a few minutes, until I tested this feature in\ngit-gui, and realized that it doesn't work there.\n\nThis seems to be caused by \"proc githook_read\", which says \"set pchook\n[gitdir hooks $hook_name]\" instead of querying \"git config\ncore.hooksPath\" first - cf\nhttps://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627\n\nWould be great if this could get fixed...\n\nThanks, Philipp\n\n"},{"id":"321405","messageId":"CAJZjrdUjAkmZY2mKuVjE58u_0C=o7BN0=Zh2egegSiN+j8jytA@mail.gmail.com","threadId":"46100","inReplyTo":"953845c2-4326-608a-c342-2d2141da561c@gortan.org","subject":"Re: git-gui ignores core.hooksPath","fromName":"Samuel Lijin","fromEmail":"sxlijin@gmail.com","sentAt":"2017-06-02T14:21:25Z","receivedAt":"2017-06-02T14:22:13Z","isPatch":false,"sender":{"key":"sxlijin@gmail.com","avatar":"https://gravatar.com/avatar/01777bf1eae64e2b4dca97dcac182a6abbcf6fd8cb4d5b8fa33edf9f8cc21746?d=mp&s=160"},"body":"On Fri, Jun 2, 2017 at 9:41 AM, Philipp Gortan wrote:\n> Hi git devs,\n>\n> First off, thanks for your awesome work!\n>\n> I've been unhappy for quite a while that I had to configure the hooks\n> manually for each of my repos - until I found out recently that there is\n> the core.hooksPath config variable that (when set globally) allows me to\n> specify a hooks directory to be used for all my repositories.\n\nOT but you may also want to look into using Git templates.\n\n> Now I was happy - for a few minutes, until I tested this feature in\n> git-gui, and realized that it doesn't work there.\n>\n> This seems to be caused by \"proc githook_read\", which says \"set pchook\n> [gitdir hooks $hook_name]\" instead of querying \"git config\n> core.hooksPath\" first - cf\n> https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627\n>\n> Would be great if this could get fixed...\n>\n> Thanks, Philipp\n>\n"},{"id":"321408","messageId":"CACBZZX6H4wxQ7hrO1Y1u6Qyr5gpK9GeCxpv-x2q3Eq2WCbkK8Q@mail.gmail.com","threadId":"46100","inReplyTo":"953845c2-4326-608a-c342-2d2141da561c@gortan.org","subject":"Re: git-gui ignores core.hooksPath","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-06-02T16:38:12Z","receivedAt":"2017-06-02T16:38:45Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan wrote:\n> Hi git devs,\n>\n> First off, thanks for your awesome work!\n>\n> I've been unhappy for quite a while that I had to configure the hooks\n> manually for each of my repos - until I found out recently that there is\n> the core.hooksPath config variable that (when set globally) allows me to\n> specify a hooks directory to be used for all my repositories.\n>\n> Now I was happy - for a few minutes, until I tested this feature in\n> git-gui, and realized that it doesn't work there.\n>\n> This seems to be caused by \"proc githook_read\", which says \"set pchook\n> [gitdir hooks $hook_name]\" instead of querying \"git config\n> core.hooksPath\" first - cf\n> https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627\n>\n> Would be great if this could get fixed...\n\nHi. I added core.hooksPath, glad to see it's useful to other people.\n\nThis indeed is something that should be fixed, but git-gui development\nis managed outside of git.git, it's just occasionally pulled in. I'm\nnot what the best place to contact is, but I've CC'd\nPhilip Oakley who's been making recent commits to git-gui.git at\nhttp://repo.or.cz/git-gui.git/\n"},{"id":"321438","messageId":"20170602202301.6413-1-philipp@gortan.org","threadId":"46100","inReplyTo":"CACBZZX6H4wxQ7hrO1Y1u6Qyr5gpK9GeCxpv-x2q3Eq2WCbkK8Q@mail.gmail.com","subject":"[PATCH] respect core.hooksPath, falling back to .git/hooks","fromName":"Philipp Gortan","fromEmail":"philipp@gortan.org","sentAt":"2017-06-02T20:23:01Z","receivedAt":"2017-06-02T20:23:15Z","isPatch":true,"sender":{"key":"philipp@gortan.org","avatar":"https://gravatar.com/avatar/5f4bda0bdd4eba9541d0867858ac3453e20f03a1280d78d9c459cb793975962a?d=mp&s=160"},"body":"Signed-off-by: Philipp Gortan \n---\n\nThe following patch tries to fix git-gui to respect the core.hooksPath config\nvariable, falling back to the old behavior.\n\ngit-gui.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 5bc21b8..a5335b1 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -624,7 +624,10 @@ proc git_write {args} {\n }\n \n proc githook_read {hook_name args} {\n-\tset pchook [gitdir hooks $hook_name]\n+\tif {[catch {set hooksdir [git config core.hooksPath]}]} {\n+\t\tset hooksdir [gitdir hooks]\n+\t}\n+\tset pchook [file join $hooksdir $hook_name]\n \tlappend args 2>@1\n \n \t# On Windows [file executable] might lie so we need to ask\n-- \n2.13.0\n\n"},{"id":"321442","messageId":"4d3ff7fd-06c1-b609-e872-c1145589e180@gortan.org","threadId":"46100","inReplyTo":"20170602202301.6413-1-philipp@gortan.org","subject":"Re: [PATCH] respect core.hooksPath, falling back to .git/hooks","fromName":"Philipp Gortan","fromEmail":"philipp@gortan.org","sentAt":"2017-06-02T20:39:09Z","receivedAt":"2017-06-02T20:39:22Z","isPatch":true,"sender":{"key":"philipp@gortan.org","avatar":"https://gravatar.com/avatar/5f4bda0bdd4eba9541d0867858ac3453e20f03a1280d78d9c459cb793975962a?d=mp&s=160"},"body":"Dear Philip,\n\nthe previous mail contains a patch against the master of\nhttp://repo.or.cz/git-gui.git\n\nCould you please review it? I am not a TCL developer, so please take\nextra care!\n\nThanks,\nPhilipp\n\n"},{"id":"321455","messageId":"7B6DC5C9C2354BD9BB08DD84FF6628D1@PhilipOakley","threadId":"46100","inReplyTo":"CACBZZX6H4wxQ7hrO1Y1u6Qyr5gpK9GeCxpv-x2q3Eq2WCbkK8Q@mail.gmail.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.org","sentAt":"2017-06-02T23:00:40Z","receivedAt":"2017-06-02T22:59:15Z","isPatch":false,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: \"Ævar Arnfjörð Bjarmason\" \n> On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan wrote:\n>> Hi git devs,\n>>\n>> First off, thanks for your awesome work!\n>>\n>> I've been unhappy for quite a while that I had to configure the hooks\n>> manually for each of my repos - until I found out recently that there is\n>> the core.hooksPath config variable that (when set globally) allows me to\n>> specify a hooks directory to be used for all my repositories.\n>>\n>> Now I was happy - for a few minutes, until I tested this feature in\n>> git-gui, and realized that it doesn't work there.\n>>\n>> This seems to be caused by \"proc githook_read\", which says \"set pchook\n>> [gitdir hooks $hook_name]\" instead of querying \"git config\n>> core.hooksPath\" first - cf\n>> https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627\n>>\n>> Would be great if this could get fixed...\n>\n> Hi. I added core.hooksPath, glad to see it's useful to other people.\n>\n> This indeed is something that should be fixed, but git-gui development\n> is managed outside of git.git, it's just occasionally pulled in. I'm\n> not what the best place to contact is, but I've CC'd\n> Philip Oakley who's been making recent commits to git-gui.git at\n> http://repo.or.cz/git-gui.git/\n\nThe proper maintainer for the git-gui is Pat Thoyts (cc'd) who now has a \nrepo at https://github.com/patthoyts/git-gui where Pull requests can be \nmade, with patches posted here initially for wider review.\n\nI'm just another contributor, but I have managed (with a bit of help from \ngoogle and formative years using FORTH;-) to get a few git-gui patches \ntested and incorporated. tcl/tk isn't that hard, its just interpreted \ncode.., the main part, for me, was working out how to ru the code in the \nGit-for-Windows SDK environment (with help).\n--\nPhilip \n\n"},{"id":"321457","messageId":"a651b597-60a4-0fcf-6912-c0f103ae2d0b@gortan.org","threadId":"46100","inReplyTo":"7B6DC5C9C2354BD9BB08DD84FF6628D1@PhilipOakley","subject":"Re: git-gui ignores core.hooksPath","fromName":"Philipp Gortan","fromEmail":"philipp@gortan.org","sentAt":"2017-06-02T23:21:57Z","receivedAt":"2017-06-02T23:22:09Z","isPatch":false,"sender":{"key":"philipp@gortan.org","avatar":"https://gravatar.com/avatar/5f4bda0bdd4eba9541d0867858ac3453e20f03a1280d78d9c459cb793975962a?d=mp&s=160"},"body":"Thanks Philip,\n\nI've created a pull request there -\nhttps://github.com/patthoyts/git-gui/pull/12\n\n"},{"id":"322259","messageId":"alpine.DEB.2.21.1.1706141457500.171564@virtualbox","threadId":"46100","inReplyTo":"CACBZZX6H4wxQ7hrO1Y1u6Qyr5gpK9GeCxpv-x2q3Eq2WCbkK8Q@mail.gmail.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-06-14T13:15:55Z","receivedAt":"2017-06-14T13:16:07Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 2 Jun 2017, Ævar Arnfjörð Bjarmason wrote:\n\n> On Fri, Jun 2, 2017 at 3:41 PM, Philipp Gortan wrote:\n>\n> > I've been unhappy for quite a while that I had to configure the hooks\n> > manually for each of my repos - until I found out recently that there\n> > is the core.hooksPath config variable that (when set globally) allows\n> > me to specify a hooks directory to be used for all my repositories.\n> >\n> > Now I was happy - for a few minutes, until I tested this feature in\n> > git-gui, and realized that it doesn't work there.\n> >\n> > This seems to be caused by \"proc githook_read\", which says \"set pchook\n> > [gitdir hooks $hook_name]\" instead of querying \"git config\n> > core.hooksPath\" first - cf\n> > https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/git-gui/git-gui.sh#L627\n> >\n> > Would be great if this could get fixed...\n\nIndeed. Why don't you give it a try?\n\n> This indeed is something that should be fixed, but git-gui development\n> is managed outside of git.git, it's just occasionally pulled in. I'm\n> not what the best place to contact is, but I've CC'd\n> Philip Oakley who's been making recent commits to git-gui.git at\n> http://repo.or.cz/git-gui.git/\n\nPhilip is in the same spot as I am: we both worked on Git GUI to improve\nit for Git for Windows users, but Pat has been silent for over half a year\non all of our PRs.\n\nIn the meantime, I managed to get a couple of changes into git.git via\nJunio, but the situation is far from ideal.\n\nSo what I settled on is to carry a couple of Git GUI patches in Git for\nWindows' fork, until the time when the patches finally get accepted into\nhttps://github.com/patthoyts/git-gui.\n\nIn this particular instance, the only question is whether to use `git\nrev-parse --git-path hooks` or re-roll the core.hookspath logic in\ngit-gui.\n\nBoth approaches have their downsides:\n\n- rev-parse --git-path was broken in subdirectories for a *really* long\n time. Since Git GUI is supposed to be relatively independent from the\n version of the installed git executable, that would imply a couple of\n ugly extra code just to make sure that it works correctly.\n\n- duplicating the core.hookspath logic is prone to become stale over time,\n as Git may change the behavior (as it did with the core.hookspath\n setting).\n\nThe subdirectory problem of --git-path is actually not that bad, as Git\nGUI cd's to the top-level directory anyway. So that bug does not affect\nus. The only caveat is that --git-path was only introduced into v2.5.0,\nand Git GUI has conditional code to even support pre-1.6.3 versions.\n\nHappily, pre-1.6.3 versions are not supposed to handle core.hookspath in\nthe way v2.9.0 and later handle it.\n\nSo something like this *may* work:\n\n-- snip --\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 37c1c5d227b..3067a3b000a 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -624,7 +624,11 @@ proc git_write {args} {\n }\n \n proc githook_read {hook_name args} {\n-\tset pchook [gitdir hooks $hook_name]\n+\tif {[package vcompare $::_git_version 2.5.0] >= 0} {\n+\t\tset pchook [git rev-parse --git-path \"hooks/$hook_name\"]\n+\t} else {\n+\t\tset pchook [gitdir hooks $hook_name]\n+\t}\n \tlappend args 2>@1\n \n \t# On Windows [file executable] might lie so we need to ask\n-- snap --\n\nPhilipp, this is as far as I will go with this. If you truly desire this\nto be fixed, please take it from here (read: test, fix and submit with a\ngood commit message).\n\nCiao,\nJohannes"},{"id":"322260","messageId":"alpine.DEB.2.21.1.1706141516540.171564@virtualbox","threadId":"46100","inReplyTo":"20170602202301.6413-1-philipp@gortan.org","subject":"Re: [PATCH] respect core.hooksPath, falling back to .git/hooks","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-06-14T13:24:02Z","receivedAt":"2017-06-14T13:24:13Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Philipp,\n\nOn Fri, 2 Jun 2017, Philipp Gortan wrote:\n\n> Signed-off-by: Philipp Gortan \n\nI just saw this. I made sure that the thread to which I just replied did\nnot have any news from you, but you simply started a new thread ;-)\n\nThis commit message needs a little bit of love. Something along the lines:\n\n\tSince v2.9.0, Git knows about the config variable core.hookspath\n\tthat allows overriding the path to the directory containing the\n\tGit hooks.\n\n\tSince v2.10.0, the `--git-path` option respects that config\n\tvariable, too, so we may just as well use that command.\n\n\tFor Git versions older than v2.5.0 (which was the first version to\n\tsupport the `--git-path` option for the `rev-parse` command), we\n\tsimply fall back to the previous code.\n\n(This assumes that you'll go with the approach I outlined in the other\nthread, comparing the Git version to 2.5.0 and going with --git-path if\navailable.)\n\n> ---\n> \n> The following patch tries to fix git-gui to respect the core.hooksPath config\n> variable, falling back to the old behavior.\n\nThat would also have been a decent commit message, if a bit short. But you\nneed to put this text before the `---` line, even before the\n`Signed-off-by:` footer.\n\n> diff --git a/git-gui.sh b/git-gui.sh\n> index 5bc21b8..a5335b1 100755\n> --- a/git-gui.sh\n> +++ b/git-gui.sh\n> @@ -624,7 +624,10 @@ proc git_write {args} {\n> }\n> \n> proc githook_read {hook_name args} {\n> -\tset pchook [gitdir hooks $hook_name]\n> +\tif {[catch {set hooksdir [git config core.hooksPath]}]} {\n\nDid you not mean [get_config core.hookspath] here, i.e. get_config and the\nkey all lower-case?\n\n> +\t\tset hooksdir [gitdir hooks]\n> +\t}\n> +\tset pchook [file join $hooksdir $hook_name]\n> \tlappend args 2>@1\n> \n\nThe problem I see with that is, as I mentioned in the other thread, that\nit duplicates the logic in config.c that may change at any stage.\n\nEven worse: it is inconsistent with the way Git handles core.hooksPath, if\nthe installed `git` executable predates v2.9.0. Git GUI explicitly allows\nfor being used with a large range of Git versions.\n\nIn short: I think it would be better to go with the approach I outlined in\nthe other thread. I'll reproduce the patch (completely untested) here:\n\n-- snipsnap --\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 37c1c5d227b..3067a3b000a 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -624,7 +624,11 @@ proc git_write {args} {\n }\n \n proc githook_read {hook_name args} {\n-\tset pchook [gitdir hooks $hook_name]\n+\tif {[package vcompare $::_git_version 2.5.0] >= 0} {\n+\t\tset pchook [git rev-parse --git-path \"hooks/$hook_name\"]\n+\t} else {\n+\t\tset pchook [gitdir hooks $hook_name]\n+\t}\n \tlappend args 2>@1\n \n \t# On Windows [file executable] might lie so we need to ask\n"},{"id":"322261","messageId":"74c84bda-4f3d-b2d3-91cf-e80e84fe46b1@gortan.org","threadId":"46100","inReplyTo":"alpine.DEB.2.21.1.1706141457500.171564@virtualbox","subject":"Re: git-gui ignores core.hooksPath","fromName":"Philipp Gortan","fromEmail":"philipp@gortan.org","sentAt":"2017-06-14T13:25:42Z","receivedAt":"2017-06-14T13:26:15Z","isPatch":false,"sender":{"key":"philipp@gortan.org","avatar":"https://gravatar.com/avatar/5f4bda0bdd4eba9541d0867858ac3453e20f03a1280d78d9c459cb793975962a?d=mp&s=160"},"body":"Dear Johannes,\n\nthanks for following up,\n\n> Indeed. Why don't you give it a try?\n\nActually, I already did: https://github.com/patthoyts/git-gui/pull/12\n\nYou might want to post your analysis and patch there as well...\n\ncu, Philipp\n\n\n"},{"id":"344351","messageId":"3a3eb88e-0d7b-e689-c4e4-207569ebd667@macq.eu","threadId":"46100","inReplyTo":"74c84bda-4f3d-b2d3-91cf-e80e84fe46b1@gortan.org","subject":"Re: git-gui ignores core.hooksPath","fromName":"Chris Maes","fromEmail":"chris.maes@macq.eu","sentAt":"2018-04-10T15:00:20Z","receivedAt":"2018-04-10T15:00:32Z","isPatch":false,"sender":{"key":"chris.maes@macq.eu","avatar":null},"body":"Hello,\n\nusing git 2.16 the same problem is still present. I see that the pull \nrequest https://github.com/patthoyts/git-gui/pull/12 (along with 15 \nother pull requests) are lying around since about one year without any \nsign of life from patthoyts.\n\nIs there any hope from here that anyone will pick up this / these \nchanges? Will anyone else be assigned the main responsible for this \ngit-gui repository?\n\nJust hoping to revive the discussion here, since the \nhttps://github.com/patthoyts/git-gui/ repository seems quite dead.\n\nsincerely,\n\nChris Maes.\n\n-- \nMacq nv\nLuchtschipstraat, 2 - 1140 Brussel - België\nT +32 (0) 2 610 15 57\nchris.maes@macq.eu - www.macq.eu\n\n"},{"id":"344413","messageId":"nycvar.QRO.7.76.6.1804110001350.56@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz","threadId":"46100","inReplyTo":"3a3eb88e-0d7b-e689-c4e4-207569ebd667@macq.eu","subject":"Re: git-gui ignores core.hooksPath","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-04-10T22:06:24Z","receivedAt":"2018-04-10T22:06:50Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Chris,\n\nOn Tue, 10 Apr 2018, Chris Maes wrote:\n\n> using git 2.16 the same problem is still present.\n\nAnd probably 2.17, too.\n\n> I see that the pull request https://github.com/patthoyts/git-gui/pull/12\n> (along with 15 other pull requests) are lying around since about one\n> year without any sign of life from patthoyts.\n\nYes, this is very sad. I hope he is alive and doing well.\n\nAs to Git GUI: if you know your way around Tcl/Tk reasonably well, how\nabout stepping up and reviewing those PRs? Even if the PRs are not merged,\na review would do those PRs pretty good and we could then take things from\nthere.\n\n> Is there any hope from here that anyone will pick up this / these\n> changes? Will anyone else be assigned the main responsible for this\n> git-gui repository?\n\nThere is no \"assigning\" here, not really. What is missing is a volunteer\nwho earned the trust of the Git developers. Reviewing those PRs would go a\nlong way to earn that trust.\n\n> Just hoping to revive the discussion here, since the\n> https://github.com/patthoyts/git-gui/ repository seems quite dead.\n\nThank you for doing this.\n\nI also hope that somebody with reasonable understanding of Tcl/Tk and a\nvested interest in Git GUI takes up the responsibility of maintaining it.\nJudging by the rate the PRs trickled into\nhttps://github.com/patthoyts/git-gui, I think it would be a minor time\ncommitment.\n\nCiao,\nJohannes\n"},{"id":"344420","messageId":"xmqqd0z61xsv.fsf@gitster-ct.c.googlers.com","threadId":"46100","inReplyTo":"3a3eb88e-0d7b-e689-c4e4-207569ebd667@macq.eu","subject":"Re: git-gui ignores core.hooksPath","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-04-10T22:50:08Z","receivedAt":"2018-04-10T22:50:28Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Chris Maes writes:\n\n> Is there any hope from here that anyone will pick up this / these\n> changes? Will anyone else be assigned the main responsible for this\n> git-gui repository?\n>\n> Just hoping to revive the discussion here, since the\n> https://github.com/patthoyts/git-gui/ repository seems quite dead.\n\nIt indeed does.\n\nI've played a patch-monkey in the past for git-gui and have a few\ntopics queued still in my tree, but that serves merely as a bookmark\nthat is slightly better than a pointer to the mailing list archive.\n\nWe need a volunteer to take over this part of the subsystem;\nsomebody who actually uses it, passionate about improving it, and\ncan speak tcl/tk somewhat fluently (I qualify none of these three\ncriteria myself).\n\nAny takers?\n"},{"id":"344423","messageId":"87muyabpuz.fsf@evledraar.gmail.com","threadId":"46100","inReplyTo":"xmqqd0z61xsv.fsf@gitster-ct.c.googlers.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-04-10T23:31:32Z","receivedAt":"2018-04-10T23:31:40Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Tue, Apr 10 2018, Junio C. Hamano wrote:\n\n> Chris Maes writes:\n>\n>> Is there any hope from here that anyone will pick up this / these\n>> changes? Will anyone else be assigned the main responsible for this\n>> git-gui repository?\n>>\n>> Just hoping to revive the discussion here, since the\n>> https://github.com/patthoyts/git-gui/ repository seems quite dead.\n>\n> It indeed does.\n>\n> I've played a patch-monkey in the past for git-gui and have a few\n> topics queued still in my tree, but that serves merely as a bookmark\n> that is slightly better than a pointer to the mailing list archive.\n>\n> We need a volunteer to take over this part of the subsystem;\n> somebody who actually uses it, passionate about improving it, and\n> can speak tcl/tk somewhat fluently (I qualify none of these three\n> criteria myself).\n>\n> Any takers?\n\nIsn't everyone involved much better solved if we come up with some plan\nto split these off from git.git? I.e. I think if if git-gui, gitk and\ngitweb were proposed for inclusion in-tree today I don't think we'd\nbite, and instead point to things like [1] or [2].\n\nOf the three gitweb is a bit more glued to the rest of the codebase\n(test & custom test lib), but gitk and git-gui already have their own\nexternal projects.\n\nIt looks like if they started making tagged releases, along with some\nsmall Makefile changes like generating their manpages from ASCIIDOC,\ndownstream packagers of git-gui and gitk could simply start pointing to\nthose as the authoritative source instead of whatever gets shipped with\ngit.\n\n1. https://git-scm.com/downloads/guis/\n2. https://git.wiki.kernel.org/index.php/Interfaces,_frontends,_and_tools#Web_Interfaces\n"},{"id":"344424","messageId":"xmqqy3huzi58.fsf@gitster-ct.c.googlers.com","threadId":"46100","inReplyTo":"87muyabpuz.fsf@evledraar.gmail.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-04-11T00:44:19Z","receivedAt":"2018-04-11T00:44:28Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> Isn't everyone involved much better solved if we come up with some plan\n> to split these off from git.git? I.e. I think if if git-gui, gitk and\n> gitweb were proposed for inclusion in-tree today I don't think we'd\n> bite, and instead point to things like [1] or [2].\n\nIt is actually the other way around. gitk and git-gui had active\nmaintainers and they (not Linus nor I) wanted to have their own\nrelease schedule and versioning; they started as eparate projects.\n\nThe arrangement was pleasant to work with while the subsystem was\nactively managed. People can send patches to it just like to other\nparts of the system (and the change rarely if ever needs to touch\nboth core and GUI at the same time---otherwise it would be\nimpractical to split them out as a separate projects), reviewers\nwould give comments on the list, and subsystem maintainers would\npick them up just like I pick up patches to the core part. Then\nfrom time to time, subsystem maintainers would give me a pull\nrequest to complete the cycle. I do \"pull -Xsubtree=git-gui/\".\n\nIt breaks down when subsystem maintainers go quiet. Even if I were\nto play a patch monkey backed by volunteer reviewers, I'd still have\nto pretend that these are separate projects that are occasionally\nsubtree merged, with my own pull requests to subsystem repositories\nthat may never be responded, just in case the separate subsystem\nprojects will become active again.\n\nIf you split git-gui off, it would just die, unless somebody steps\nup and takes it over. And if somebody steps up and takes it over,\nwe can keep merging from their repositories without any problem.\n"},{"id":"349317","messageId":"CAKPyHN0j0VPcMCN4huVP2Dqsg0g3WmOw304S8dcRbWVtZTphHQ@mail.gmail.com","threadId":"46100","inReplyTo":"xmqqd0z61xsv.fsf@gitster-ct.c.googlers.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2018-06-05T05:48:51Z","receivedAt":"2018-06-05T05:48:55Z","isPatch":false,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Wed, Apr 11, 2018 at 12:50 AM, Junio C Hamano wrote:\n> Chris Maes writes:\n>\n>> Is there any hope from here that anyone will pick up this / these\n>> changes? Will anyone else be assigned the main responsible for this\n>> git-gui repository?\n>>\n>> Just hoping to revive the discussion here, since the\n>> https://github.com/patthoyts/git-gui/ repository seems quite dead.\n>\n> It indeed does.\n>\n> I've played a patch-monkey in the past for git-gui and have a few\n> topics queued still in my tree, but that serves merely as a bookmark\n> that is slightly better than a pointer to the mailing list archive.\n>\n> We need a volunteer to take over this part of the subsystem;\n> somebody who actually uses it, passionate about improving it, and\n> can speak tcl/tk somewhat fluently (I qualify none of these three\n> criteria myself).\n>\n> Any takers?\n\nthe last time this topic came up, Stefan (in Cc) offered to volunteer.\nStefan, is this offer still open? I would support this.\n\nBest,\n"},{"id":"349949","messageId":"CAGZ79kazAU-=Z0Q+X6_TimMbkyDQZ4c3mAVuGH0rrR_HenqPPw@mail.gmail.com","threadId":"46100","inReplyTo":"CAKPyHN0j0VPcMCN4huVP2Dqsg0g3WmOw304S8dcRbWVtZTphHQ@mail.gmail.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2018-06-11T21:58:15Z","receivedAt":"2018-06-11T21:58:30Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Mon, Jun 4, 2018 at 10:48 PM Bert Wesarg wrote:\n>\n> On Wed, Apr 11, 2018 at 12:50 AM, Junio C Hamano wrote:\n> > Chris Maes writes:\n> >\n> >> Is there any hope from here that anyone will pick up this / these\n> >> changes? Will anyone else be assigned the main responsible for this\n> >> git-gui repository?\n> >>\n> >> Just hoping to revive the discussion here, since the\n> >> https://github.com/patthoyts/git-gui/ repository seems quite dead.\n> >\n> > It indeed does.\n> >\n> > I've played a patch-monkey in the past for git-gui and have a few\n> > topics queued still in my tree, but that serves merely as a bookmark\n> > that is slightly better than a pointer to the mailing list archive.\n> >\n> > We need a volunteer to take over this part of the subsystem;\n> > somebody who actually uses it, passionate about improving it, and\n> > can speak tcl/tk somewhat fluently (I qualify none of these three\n> > criteria myself).\n> >\n> > Any takers?\n>\n> the last time this topic came up, Stefan (in Cc) offered to volunteer.\n> Stefan, is this offer still open? I would support this.\n\nAfter I made this offer, I started looking at the code base more and trying\nto add a feature just to discover I do not qualify as fluent in tcl/tk.\nAlso I have some issues managing my time, so I retract that offer.\nThough I'd still review the code in this area.\n"},{"id":"349969","messageId":"2e64dc3a-f0e9-6ff4-4cff-d50bb350da86@kdbg.org","threadId":"46100","inReplyTo":"CAGZ79kazAU-=Z0Q+X6_TimMbkyDQZ4c3mAVuGH0rrR_HenqPPw@mail.gmail.com","subject":"Re: git-gui ignores core.hooksPath","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2018-06-12T06:09:36Z","receivedAt":"2018-06-12T06:09:43Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 11.06.2018 um 23:58 schrieb Stefan Beller:\n> On Mon, Jun 4, 2018 at 10:48 PM Bert Wesarg wrote:\n>> the last time this topic came up, Stefan (in Cc) offered to volunteer.\n>> Stefan, is this offer still open? I would support this.\n> \n> After I made this offer, I started looking at the code base more and trying\n> to add a feature just to discover I do not qualify as fluent in tcl/tk.\n> Also I have some issues managing my time, so I retract that offer.\n> Though I'd still review the code in this area.\n\nMaybe it's of interest to somebody: My current pet fun project is this \none: https://github.com/j6t/git-gui-ng -- rewrite to C++ using Tk as GUI \ntoolkit.\n\nI use git gui (the original) daily, but no, I don't volunteer to keep it \ngoing. Tcl is just too exotic.\n\n-- Hannes\n"},{"id":"352087","messageId":"nycvar.QRO.7.76.6.1807101405570.75@tvgsbejvaqbjf.bet","threadId":"46100","inReplyTo":"74c84bda-4f3d-b2d3-91cf-e80e84fe46b1@gortan.org","subject":"Re: git-gui ignores core.hooksPath","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2018-07-10T12:08:47Z","receivedAt":"2018-07-10T12:08:53Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Phillip,\n\nOn Wed, 14 Jun 2017, Philipp Gortan wrote:\n\n> thanks for following up,\n> \n> > Indeed. Why don't you give it a try?\n> \n> Actually, I already did: https://github.com/patthoyts/git-gui/pull/12\n> \n> You might want to post your analysis and patch there as well...\n\nI wonder what good posting my analysis did, if nothing changed as a\nconsequence.\n\nFWIW I opened this PR with Git for Windows to fix it properly:\n\n\thttps://github.com/git-for-windows/git/pull/1757\n\nI plan on consolidating all of the PRs at\nhttps://github.com/patthoyts/git-gui, too, and to try to get them into\ngit.git. I guess that means that I just volunteered as interim maintainer\nof the git-gui repository. However, I will really act as maintainer, not\nas \"cleaner upper\".\n\nCiao,\nJohannes\n"},{"id":"352114","messageId":"2314380CD5BB4E75AD989D7CAC2EB93B@PhilipOakley","threadId":"46100","inReplyTo":"nycvar.QRO.7.76.6.1807101405570.75@tvgsbejvaqbjf.bet","subject":"Re: git-gui ignores core.hooksPath","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.org","sentAt":"2018-07-10T15:18:46Z","receivedAt":"2018-07-10T15:30:41Z","isPatch":false,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: \"Johannes Schindelin\" \n> Hi Phillip,\n>\n> On Wed, 14 Jun 2017, Philipp Gortan wrote:\n>\n>> thanks for following up,\n>>\n>> > Indeed. Why don't you give it a try?\n>>\n>> Actually, I already did: https://github.com/patthoyts/git-gui/pull/12\n>>\n>> You might want to post your analysis and patch there as well...\n>\n> I wonder what good posting my analysis did, if nothing changed as a\n> consequence.\n>\n> FWIW I opened this PR with Git for Windows to fix it properly:\n>\n> https://github.com/git-for-windows/git/pull/1757\n>\n> I plan on consolidating all of the PRs at\n> https://github.com/patthoyts/git-gui, too, and to try to get them into\n> git.git.\n\n\n> I guess that means that I just volunteered as interim maintainer\n> of the git-gui repository. However, I will really act as maintainer, not\n> as \"cleaner upper\".\n\n\"Curator\" is a useful intermediate level concept between active maintenance \nand passive benign neglect, if that term is a help...\n\n--\nPhilip \n\n"}]}