{"thread":{"id":"46092","subject":"[PATCH 0/6] Some more git config completions","startedAt":"2017-06-01T21:41:52Z","lastAt":"2017-06-04T18:41:24Z","messageCount":10,"participants":["Rikard Falkeborn","Ævar Arnfjörð Bjarmason","Junio C Hamano","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"321336","messageId":"20170527062552.13996-1-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":null,"subject":"[PATCH 0/6] Some more git config completions","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:46Z","receivedAt":"2017-06-01T21:41:52Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Some more completions (from what I could tell, there are probably more\nmissing). Please let me know if you prefer them in smaller (or larger)\nbatches (or if the patches aren't wanted at all).\n\nPatches are based on master. \n\nRikard Falkeborn (6):\n completion: Add git config gc completions\n completion: Add git config core completions\n completion: Add git config am.threeWay completion\n completion: Add git config advice completions\n completion: Add git config credential completions\n completion: Add git config credentialCache.ignoreSIGHUP\n\n contrib/completion/git-completion.bash | 29 ++++++++++++++++++++++++++++-\n 1 file changed, 28 insertions(+), 1 deletion(-)\n\n-- \n2.13.0\n\n"},{"id":"321337","messageId":"20170527062552.13996-3-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"[PATCH 2/6] completion: Add git config core completions","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:48Z","receivedAt":"2017-06-01T21:41:56Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Add missing completions for git config core:\n\n* core.checkStat\n* core.commentChar\n* core.hideDotFiles\n* core.hooksPath\n* core.packedRefsTimeout\n* core.precomposeUnicode\n* core.protectHFS\n* core.protectNTFS\n* core.splitIndex\n* core.sshCommand\n\nNote that some configs are only used for some platforms\n(hideDotFiles on Windows and precomposeUnicode on Mac).\n\nSigned-off-by: Rikard Falkeborn \n---\n contrib/completion/git-completion.bash | 10 ++++++++++\n 1 file changed, 10 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 4e5e2eaae..de9306173 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2403,6 +2403,8 @@ _git_config ()\n \t\tcore.autocrlf\n \t\tcore.bare\n \t\tcore.bigFileThreshold\n+\t\tcore.checkStat\n+\t\tcore.commentChar\n \t\tcore.compression\n \t\tcore.createObject\n \t\tcore.deltaBaseCacheLimit\n@@ -2412,6 +2414,8 @@ _git_config ()\n \t\tcore.fileMode\n \t\tcore.fsyncobjectfiles\n \t\tcore.gitProxy\n+\t\tcore.hideDotFiles\n+\t\tcore.hooksPath\n \t\tcore.ignoreStat\n \t\tcore.ignorecase\n \t\tcore.logAllRefUpdates\n@@ -2419,14 +2423,20 @@ _git_config ()\n \t\tcore.notesRef\n \t\tcore.packedGitLimit\n \t\tcore.packedGitWindowSize\n+\t\tcore.packedRefsTimeout\n \t\tcore.pager\n+\t\tcore.precomposeUnicode\n \t\tcore.preferSymlinkRefs\n \t\tcore.preloadindex\n+\t\tcore.protectHFS\n+\t\tcore.protectNTFS\n \t\tcore.quotepath\n \t\tcore.repositoryFormatVersion\n \t\tcore.safecrlf\n \t\tcore.sharedRepository\n \t\tcore.sparseCheckout\n+\t\tcore.splitIndex\n+\t\tcore.sshCommand\n \t\tcore.symlinks\n \t\tcore.trustctime\n \t\tcore.untrackedCache\n-- \n2.13.0\n\n"},{"id":"321338","messageId":"20170527062552.13996-2-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"[PATCH 1/6] completion: Add git config gc completions","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:47Z","receivedAt":"2017-06-01T21:41:57Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Add missing completion for git config gc options:\n\n* gc.aggressiveDepth\n* gc.autoDetach\n* gc.logExpiry\n* gc.worktreePruneExpire\n\nSigned-off-by: Rikard Falkeborn \n---\n contrib/completion/git-completion.bash | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 45a78a095..4e5e2eaae 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2464,15 +2464,19 @@ _git_config ()\n \t\tformat.thread\n \t\tformat.to\n \t\tgc.\n+\t\tgc.aggressiveDepth\n \t\tgc.aggressiveWindow\n \t\tgc.auto\n+\t\tgc.autoDetach\n \t\tgc.autopacklimit\n+\t\tgc.logExpiry\n \t\tgc.packrefs\n \t\tgc.pruneexpire\n \t\tgc.reflogexpire\n \t\tgc.reflogexpireunreachable\n \t\tgc.rerereresolved\n \t\tgc.rerereunresolved\n+\t\tgc.worktreePruneExpire\n \t\tgitcvs.allbinary\n \t\tgitcvs.commitmsgannotation\n \t\tgitcvs.dbTableNamePrefix\n-- \n2.13.0\n\n"},{"id":"321339","messageId":"20170527062552.13996-5-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"[PATCH 4/6] completion: Add git config advice completions","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:50Z","receivedAt":"2017-06-01T21:42:03Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Add missing completions for git config advice:\n\n* advice.amWorkDir\n* advice.pushAlreadyExists\n* advice.pushFetchFirst\n* advice.pushNeedsForce\n* advice.pushNonFFCurrent\n* advice.pushNonFFMatching\n* advice.pushUpdateRejected\n* advice.rmHints\n* advice.statusUoption\n\nRemove completion for git config advice.pushNonFastForward,\nsince it was renamed to pushUpdateRejected in 1184564eac8e.\nThe config still works, but is no longer part of the documentation.\n\nSigned-off-by: Rikard Falkeborn \n---\n contrib/completion/git-completion.bash | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 3a630a230..7efcb2a79 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2336,12 +2336,20 @@ _git_config ()\n \tesac\n \t__gitcomp \"\n \t\tadd.ignoreErrors\n+\t\tadvice.amWorkDir\n \t\tadvice.commitBeforeMerge\n \t\tadvice.detachedHead\n \t\tadvice.implicitIdentity\n-\t\tadvice.pushNonFastForward\n+\t\tadvice.pushAlreadyExists\n+\t\tadvice.pushFetchFirst\n+\t\tadvice.pushNeedsForce\n+\t\tadvice.pushNonFFCurrent\n+\t\tadvice.pushNonFFMatching\n+\t\tadvice.pushUpdateRejected\n \t\tadvice.resolveConflict\n+\t\tadvice.rmHints\n \t\tadvice.statusHints\n+\t\tadvice.statusUoption\n \t\talias.\n \t\tam.keepcr\n \t\tam.threeWay\n-- \n2.13.0\n\n"},{"id":"321340","messageId":"20170527062552.13996-7-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"[PATCH 6/6] completion: Add git config credentialCache.ignoreSIGHUP","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:52Z","receivedAt":"2017-06-01T21:42:13Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Signed-off-by: Rikard Falkeborn \n---\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 98f3e76ee..6de0dda6c 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2455,6 +2455,7 @@ _git_config ()\n \t\tcredential.helper\n \t\tcredential.useHttpPath\n \t\tcredential.username\n+\t\tcredentialCache.ignoreSIGHUP\n \t\tdiff.autorefreshindex\n \t\tdiff.external\n \t\tdiff.ignoreSubmodules\n-- \n2.13.0\n\n"},{"id":"321341","messageId":"20170527062552.13996-4-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"[PATCH 3/6] completion: Add git config am.threeWay completion","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:49Z","receivedAt":"2017-06-01T21:42:14Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Signed-off-by: Rikard Falkeborn \n---\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex de9306173..3a630a230 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2344,6 +2344,7 @@ _git_config ()\n \t\tadvice.statusHints\n \t\talias.\n \t\tam.keepcr\n+\t\tam.threeWay\n \t\tapply.ignorewhitespace\n \t\tapply.whitespace\n \t\tbranch.autosetupmerge\n-- \n2.13.0\n\n"},{"id":"321342","messageId":"20170527062552.13996-6-rikard.falkeborn@gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"[PATCH 5/6] completion: Add git config credential completions","fromName":"Rikard Falkeborn","fromEmail":"rikard.falkeborn@gmail.com","sentAt":"2017-05-27T06:25:51Z","receivedAt":"2017-06-01T21:42:16Z","isPatch":true,"sender":{"key":"rikard.falkeborn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4839044?v=4"},"body":"Add missing completions for git config credential:\n\n* credential.helper\n* credential.useHttpPath\n* credential.username\n\nSigned-off-by: Rikard Falkeborn \n---\n contrib/completion/git-completion.bash | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 7efcb2a79..98f3e76ee 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2452,6 +2452,9 @@ _git_config ()\n \t\tcore.warnAmbiguousRefs\n \t\tcore.whitespace\n \t\tcore.worktree\n+\t\tcredential.helper\n+\t\tcredential.useHttpPath\n+\t\tcredential.username\n \t\tdiff.autorefreshindex\n \t\tdiff.external\n \t\tdiff.ignoreSubmodules\n-- \n2.13.0\n\n"},{"id":"321345","messageId":"CACBZZX6aGkBaQtjKNx09-XEbhXNubOnhJdVXYkNq419wetDvqg@mail.gmail.com","threadId":"46092","inReplyTo":"20170527062552.13996-1-rikard.falkeborn@gmail.com","subject":"Re: [PATCH 0/6] Some more git config completions","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-06-01T22:02:01Z","receivedAt":"2017-06-01T22:02:27Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, May 27, 2017 at 8:25 AM, Rikard Falkeborn\n wrote:\n> Some more completions (from what I could tell, there are probably more\n> missing). Please let me know if you prefer them in smaller (or larger)\n> batches (or if the patches aren't wanted at all).\n\nThis all looks good to me, and I think it would be fine to have\nchanges like these in bigger batches, they're easy to review.\n\nAs an aside from this series, has anyone ever proposed some method of\nsemi-automatically keeping this up-to-date? Seems we're in a continual\ncycle of adding flags/config, forgetting to update this, then updating\nit. At least the command-line flags should be easy to parse out in\nsome test, ditto config variables from config.txt maybe...\n"},{"id":"321364","messageId":"xmqqy3tb2poy.fsf@gitster.mtv.corp.google.com","threadId":"46092","inReplyTo":"CACBZZX6aGkBaQtjKNx09-XEbhXNubOnhJdVXYkNq419wetDvqg@mail.gmail.com","subject":"Re: [PATCH 0/6] Some more git config completions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-02T00:33:49Z","receivedAt":"2017-06-02T00:33:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> As an aside from this series, has anyone ever proposed some method of\n> semi-automatically keeping this up-to-date? Seems we're in a continual\n> cycle of adding flags/config, forgetting to update this, then updating\n> it. At least the command-line flags should be easy to parse out in\n> some test, ditto config variables from config.txt maybe...\n\nIn theory, yes, and if it is harder to automate it, at some point we\nmay want to see if we can devise a way to make it easier by\nextending parse-options and config API.\n\nSuch an automation however needs to take into account the fact that\nhistorically we tried not to blindly add everything under the sun to\ncompletion (iow, there needs a way to allow us mark some things not\nto be auto completed in the mechanism).\n"},{"id":"321511","messageId":"20170604184110.26804-1-szeder.dev@gmail.com","threadId":"46092","inReplyTo":"CACBZZX6aGkBaQtjKNx09-XEbhXNubOnhJdVXYkNq419wetDvqg@mail.gmail.com","subject":"Re: [PATCH 0/6] Some more git config completions","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2017-06-04T18:41:10Z","receivedAt":"2017-06-04T18:41:24Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"\n> As an aside from this series, has anyone ever proposed some method of\n> semi-automatically keeping this up-to-date?\n\nFor configuration variables, not that I know of.\nFor command line options, there was an attempt to enhance\nparse-options to dump all command line options and use this in the\ncompletion script on-demand to lazy-initialize command-specific\nvariables holding the list of options:\n\n http://public-inbox.org/git/1334140165-24958-1-git-send-email-bebarino@gmail.com/T/#u\n\n> Seems we're in a continual\n> cycle of adding flags/config, forgetting to update this, then updating\n> it. At least the command-line flags should be easy to parse out in\n> some test, ditto config variables from config.txt maybe...\n\nA couple of thoughts concerning configuration variables:\n\n - config.txt includes other files listing configuration variables,\n too.\n - There are many config variables with subsections, e.g.\n 'branch..description'. That '' is not good for\n completion, of course.\n - Some config variables are not listed with their full names, see\n 'advice.*' (this is easy to fix).\n - Perhaps there are config variables that are only mentioned in the\n docs of the relevant command, but not in config.txt (or in the\n included files).\n - There are definitely config variables that are not mentioned in the\n docs at all, e.g. the 'bash.*' variables controlling __git_ps1().\n - The completion script is currently self-contained and ready to be\n used as-is. I think that's quite nice. This wouldn't be the case\n if we want to include an automatically generated list of config\n variables extracted from config.txt during the build process.\n\n"}]}