{"thread":{"id":"4603","subject":"gitk lower pane (commit and files view) scrollbar extends past gitk window","startedAt":"2006-06-21T12:42:24Z","lastAt":"2006-06-22T13:19:14Z","messageCount":14,"participants":["Jakub Narebski","Edgar Toernig","Junio C Hamano","Alex Riesen","Santi Béjar"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"22202","messageId":"e7ber7$qh9$1@sea.gmane.org","threadId":"4603","inReplyTo":null,"subject":"gitk lower pane (commit and files view) scrollbar extends past gitk window","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-21T12:42:24Z","receivedAt":"2006-06-21T12:42:24Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"In gitk from the current 'next' branch, post git version 1.4.0 \n(blob ba4644f) scrollbar for lower pane, i.e. for commitdiff and files\n(Comments) views extends past the bottom of the gitk window. Therefore \nI cannnot see lower part of commit diff if it is larger than window height.\n\ngitk window has height lower than 700.\n\nThe upper pane, i.e. history graph scrollbar is correct, and works as it\nshould.\n\nThis is regression from git 1.3.0, where gitk works correctly.\n\n\nBelow ascii art trying to describe situation.\n\n _ _ _\n ^ .. upper scrollbar arrow .... ^ ^\n # # |\n # .... position indicator ..... # |\n | | |\n | | scrolling past window edge -> #\n | bottom of gitk window --> = =\n v <-- no lower scrollbar arrow\n = <-- bottom of gitk window\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22228","messageId":"20060622023546.28cb4291.froese@gmx.de","threadId":"4603","inReplyTo":"e7ber7$qh9$1@sea.gmane.org","subject":"Re: gitk lower pane (commit and files view) scrollbar extends past gitk window","fromName":"Edgar Toernig","fromEmail":"froese@gmx.de","sentAt":"2006-06-22T00:35:46Z","receivedAt":"2006-06-22T00:35:46Z","isPatch":false,"sender":{"key":"froese@gmx.de","avatar":null},"body":"Jakub Narebski wrote:\n>\n> In gitk from the current 'next' branch, post git version 1.4.0 \n> (blob ba4644f) scrollbar for lower pane, i.e. for commitdiff and files\n> (Comments) views extends past the bottom of the gitk window. Therefore \n> I cannnot see lower part of commit diff if it is larger than window height.\n\nYes, and the search field at the bottom is invisible too. Removing\nline 431:\n\n .ctop conf -width $geometry(width) -height $geometry(height)\n\nseems to fix it and the window still gets the right size.\n\nCiao, ET.\n"},{"id":"22235","messageId":"11509591773212-git-send-email-jnareb@gmail.com","threadId":"4603","inReplyTo":"20060622023546.28cb4291.froese@gmx.de","subject":"[PATCH] gitweb: whitespace cleanup around '='","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T06:52:57Z","receivedAt":"2006-06-22T06:52:57Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski \n\n\n---\n\n gitweb/gitweb.cgi | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\n82c8812870e9c40fd495e9c3e2eae0eb78ac2759\ndiff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi\nindex e044c61..adc4a42 100755\n--- a/gitweb/gitweb.cgi\n+++ b/gitweb/gitweb.cgi\n@@ -326,7 +326,7 @@ EOF\n \t\t} elsif (defined $hash) {\n \t\t\t$search_hash = $hash;\n \t\t} else {\n-\t\t\t$search_hash = \"HEAD\";\n+\t\t\t$search_hash = \"HEAD\";\n \t\t}\n \t\t$cgi->param(\"a\", \"search\");\n \t\t$cgi->param(\"h\", $search_hash);\n@@ -1766,8 +1766,8 @@ sub git_opml {\n \t\t}\n \n \t\tmy $path = esc_html(chop_str($proj{'path'}, 25, 5));\n-\t\tmy $rss = \"$my_url?p=$proj{'path'};a=rss\";\n-\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n+\t\tmy $rss = \"$my_url?p=$proj{'path'};a=rss\";\n+\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n \t\tprint \"\\n\";\n \t}\n \tprint \"\\n\".\n@@ -1942,7 +1942,7 @@ sub git_commit {\n \t \"\" . $cgi->a({-href => \"$my_uri?\" . esc_param(\"p=$project;a=tree;h=$co{'tree'};hb=$hash\")}, \"tree\") .\n \t \"\" .\n \t \"\\n\";\n-\tmy $parents = $co{'parents'};\n+\tmy $parents = $co{'parents'};\n \tforeach my $par (@$parents) {\n \t\tprint \"\" .\n \t\t \"parent\" .\n-- \n1.3.0\n"},{"id":"22237","messageId":"e7df7b$vso$2@sea.gmane.org","threadId":"4603","inReplyTo":"11509591773212-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T07:01:11Z","receivedAt":"2006-06-22T07:01:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"I'm sorry, wrong In-Reply-To given to git-send-email.\nIt should be reply to <7vu06exfym.fsf@assigned-by-dhcp.cox.net>\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22238","messageId":"7vejxhwts4.fsf@assigned-by-dhcp.cox.net","threadId":"4603","inReplyTo":"11509591773212-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-22T07:09:47Z","receivedAt":"2006-06-22T07:09:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> @@ -326,7 +326,7 @@ EOF\n> \t\t} elsif (defined $hash) {\n> \t\t\t$search_hash = $hash;\n> \t\t} else {\n> -\t\t\t$search_hash = \"HEAD\";\n> +\t\t\t$search_hash = \"HEAD\";\n> \t\t}\n> \t\t$cgi->param(\"a\", \"search\");\n> \t\t$cgi->param(\"h\", $search_hash);\n\nMy copy from \"next\" has this part like the following:\n\n\t\tif (!defined $searchtext) {\n\t\t\t$searchtext = \"\";\n\t\t}\n\t\tmy $search_hash;\n\t\tif (defined $hash) {\n\t\t\t$search_hash = $hash;\n\t\t} else {\n\t\t\t$search_hash = \"HEAD\";\n\t\t}\n\nI thought we were both reasonably sure that we are now in\nsync... I could apply it by hand but once I start doing that\nI'm afraid we will never converge.\n\nIt's quite frustrating.\n\n> @@ -1766,8 +1766,8 @@ sub git_opml {\n> \t\t}\n> \n> \t\tmy $path = esc_html(chop_str($proj{'path'}, 25, 5));\n> -\t\tmy $rss = \"$my_url?p=$proj{'path'};a=rss\";\n> -\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n> +\t\tmy $rss = \"$my_url?p=$proj{'path'};a=rss\";\n> +\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n> \t\tprint \"\\n\";\n> \t}\n> \tprint \"\\n\".\n\nAre you sure you want to do \"my $rss two-spaces equal space\"?\n\nI've fixed up the whitespace you missed and will be applying the\nfollowing on top of what is in \"next\" tonight.\n\n-- >8 --\ngitweb: do not align assignment = with extra whitespaces\n\n---\ndiff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi\nindex f2e5046..e2ed6db 100755\n--- a/gitweb/gitweb.cgi\n+++ b/gitweb/gitweb.cgi\n@@ -55,7 +55,7 @@ my $projects_list = \"index/index.aux\";\n \n # default blob_plain mimetype and default charset for text/plain blob\n my $default_blob_plain_mimetype = 'text/plain';\n-my $default_text_plain_charset = undef;\n+my $default_text_plain_charset = undef;\n \n # file to use for guessing MIME types before trying /etc/mime.types\n # (relative to the current git repository)\n@@ -325,7 +325,7 @@ EOF\n \t\tif (defined $hash) {\n \t\t\t$search_hash = $hash;\n \t\t} else {\n-\t\t\t$search_hash = \"HEAD\";\n+\t\t\t$search_hash = \"HEAD\";\n \t\t}\n \t\t$cgi->param(\"a\", \"search\");\n \t\t$cgi->param(\"h\", $search_hash);\n@@ -1283,21 +1283,21 @@ HTML\n \n \t\tif ($line =~ m/^([0-9a-fA-F]{40})\\t\\(\\s*([^\\t]+)\\t(\\d+) \\+\\d\\d\\d\\d\\t(\\d+)\\)(.*)$/) {\n \t\t\t$long_rev = $1;\n-\t\t\t$author = $2;\n-\t\t\t$time = $3;\n-\t\t\t$lineno = $4;\n-\t\t\t$data = $5;\n+\t\t\t$author = $2;\n+\t\t\t$time = $3;\n+\t\t\t$lineno = $4;\n+\t\t\t$data = $5;\n \t\t} else {\n \t\t\tprint qq( Unable to parse: $line\\n);\n \t\t\tnext;\n \t\t}\n-\t\t$short_rev = substr ($long_rev, 0, 8);\n-\t\t$age = time () - $time;\n-\t\t$age_str = age_string ($age);\n-\t\t$age_str =~ s/ / /g;\n-\t\t$age_class = age_class($age);\n-\t\t$author = esc_html ($author);\n-\t\t$author =~ s/ / /g;\n+\t\t$short_rev = substr ($long_rev, 0, 8);\n+\t\t$age = time () - $time;\n+\t\t$age_str = age_string ($age);\n+\t\t$age_str =~ s/ / /g;\n+\t\t$age_class = age_class($age);\n+\t\t$author = esc_html ($author);\n+\t\t$author =~ s/ / /g;\n \t\t# escape tabs\n \t\twhile ((my $pos = index($data, \"\\t\")) != -1) {\n \t\t\tif (my $count = (8 - ($pos % 8))) {\n@@ -1765,8 +1765,8 @@ sub git_opml {\n \t\t}\n \n \t\tmy $path = esc_html(chop_str($proj{'path'}, 25, 5));\n-\t\tmy $rss = \"$my_url?p=$proj{'path'};a=rss\";\n-\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n+\t\tmy $rss = \"$my_url?p=$proj{'path'};a=rss\";\n+\t\tmy $html = \"$my_url?p=$proj{'path'};a=summary\";\n \t\tprint \"\\n\";\n \t}\n \tprint \"\\n\".\n@@ -1941,7 +1941,7 @@ sub git_commit {\n \t \"\" . $cgi->a({-href => \"$my_uri?\" . esc_param(\"p=$project;a=tree;h=$co{'tree'};hb=$hash\")}, \"tree\") .\n \t \"\" .\n \t \"\\n\";\n-\tmy $parents = $co{'parents'};\n+\tmy $parents = $co{'parents'};\n \tforeach my $par (@$parents) {\n \t\tprint \"\" .\n \t\t \"parent\" .\n"},{"id":"22239","messageId":"81b0412b0606220010p6c2e62ffv3914abafd95e4bb2@mail.gmail.com","threadId":"4603","inReplyTo":"20060622023546.28cb4291.froese@gmx.de","subject":"Re: gitk lower pane (commit and files view) scrollbar extends past gitk window","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-06-22T07:10:24Z","receivedAt":"2006-06-22T07:10:24Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 6/22/06, Edgar Toernig wrote:\n> Jakub Narebski wrote:\n> >\n> > In gitk from the current 'next' branch, post git version 1.4.0\n> > (blob ba4644f) scrollbar for lower pane, i.e. for commitdiff and files\n> > (Comments) views extends past the bottom of the gitk window. Therefore\n> > I cannnot see lower part of commit diff if it is larger than window height.\n>\n> Yes, and the search field at the bottom is invisible too. Removing\n> line 431:\n>\n> .ctop conf -width $geometry(width) -height $geometry(height)\n>\n> seems to fix it and the window still gets the right size.\n>\n\nNo, it does not. It gets the default geometry, not the one it had last time.\n"},{"id":"22242","messageId":"e7dh1c$61n$1@sea.gmane.org","threadId":"4603","inReplyTo":"7vejxhwts4.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T07:32:09Z","receivedAt":"2006-06-22T07:32:09Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub Narebski writes:\n> \n>> @@ -326,7 +326,7 @@ EOF\n>> } elsif (defined $hash) {\n>> $search_hash = $hash;\n>> } else {\n>> - $search_hash = \"HEAD\";\n>> + $search_hash = \"HEAD\";\n>> }\n>> $cgi->param(\"a\", \"search\");\n>> $cgi->param(\"h\", $search_hash);\n> \n> My copy from \"next\" has this part like the following:\n> \n> if (!defined $searchtext) {\n> $searchtext = \"\";\n> }\n> my $search_hash;\n> if (defined $hash) {\n> $search_hash = $hash;\n> } else {\n> $search_hash = \"HEAD\";\n> }\n> \n> I thought we were both reasonably sure that we are now in\n> sync... I could apply it by hand but once I start doing that\n> I'm afraid we will never converge.\n> \n> It's quite frustrating.\n\nI'm very sorry, I forgot that I applied Timo Hirvonen patch\n\n \"[PATCH] gitweb: Start search from HEAD\"\n (<20060620152515.23e59396.tihirvon@gmail.com>)\n http://permalink.gmane.org/gmane.comp.version-control.git/22197>\n\non top of 'next'.\n\nThis patch fixes search quite nicely, reducing significantly number of error\nmessages during search (e.g. starting search from blob or file view).\n\nAny reason not to apply it?\n\n>> my $path = esc_html(chop_str($proj{'path'}, 25, 5));\n>> - my $rss = \"$my_url?p=$proj{'path'};a=rss\";\n>> - my $html = \"$my_url?p=$proj{'path'};a=summary\";\n>> + my $rss = \"$my_url?p=$proj{'path'};a=rss\";\n>> + my $html = \"$my_url?p=$proj{'path'};a=summary\";\n> \n> Are you sure you want to do \"my $rss two-spaces equal space\"?\n> \n> I've fixed up the whitespace you missed and will be applying the\n> following on top of what is in \"next\" tonight.\n> \n> -- >8 --\n> gitweb: do not align assignment = with extra whitespaces\n\nMy idea for coding style is to align assignment = with extra whitespaces,\nbut only where aligned assignments statements are one after another.\n\nThe above \"my $rss\" example was mistyped as \" = \" instead of \" = \",\nbut I think it was meant to be aligned at '='. IMHO aligning at assign \nmakes code more readable.\n\nBut that is just my opinion.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22244","messageId":"e7di0n$7hh$1@sea.gmane.org","threadId":"4603","inReplyTo":"81b0412b0606220010p6c2e62ffv3914abafd95e4bb2@mail.gmail.com","subject":"[WORKAROUND] gitk lower pane scrollbar extends past gitk window","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T07:48:52Z","receivedAt":"2006-06-22T07:48:52Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Alex Riesen wrote:\n\n> On 6/22/06, Edgar Toernig wrote:\n>> Jakub Narebski wrote:\n>>>\n>>> In gitk from the current 'next' branch, post git version 1.4.0\n>>> (blob ba4644f) scrollbar for lower pane, i.e. for commitdiff and files\n>>> (Comments) views extends past the bottom of the gitk window. Therefore\n>>> I cannnot see lower part of commit diff if it is larger than \n>>> window height. \n>>\n>> Yes, and the search field at the bottom is invisible too. Removing\n>> line 431:\n>>\n>> .ctop conf -width $geometry(width) -height $geometry(height)\n>>\n>> seems to fix it and the window still gets the right size.\n>>\n> \n> No, it does not. It gets the default geometry, not the one it had last time.\n\nNow I see. It is the case when I used gitk from a computer with a desktop\nwith larger screen height, then on computer with screen height smaller than \ngitk height was I had mentioned problem.\n\nWorkaround for now is to delete old geometry info from ~/.gitk file \n(or just delete whole file).\n\nI don't know Tcl/Tk to make proper fix, i.e. check if restored size is not\nlarger than available screen size, and use min(saved size, screen size).\nAnother improvement would be to save the fact that gitk window is maximized\nas a symbol, e.g. as equivalent of \n\n set geometry(height) screen(height)\n\nin ~/.gitk\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22253","messageId":"7vodwlsfek.fsf@assigned-by-dhcp.cox.net","threadId":"4603","inReplyTo":"e7dh1c$61n$1@sea.gmane.org","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-22T09:33:55Z","receivedAt":"2006-06-22T09:33:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> Junio C Hamano wrote:\n>\n>> I thought we were both reasonably sure that we are now in\n>> sync... I could apply it by hand but once I start doing that\n>> I'm afraid we will never converge.\n>> \n>> It's quite frustrating.\n>\n> I'm very sorry, I forgot that I applied Timo Hirvonen patch\n>\n> \"[PATCH] gitweb: Start search from HEAD\"\n> (<20060620152515.23e59396.tihirvon@gmail.com>)\n> http://permalink.gmane.org/gmane.comp.version-control.git/22197>\n>\n> on top of 'next'.\n\nI remember discussing things with Timo and was putting it on\nhold since I knew you were also actively futzing on gitweb.\n\nBut I think what you have is this one instead:\n\nMessage-ID: <20060620164105.7276a45f.tihirvon@gmail.com>\n\nI applied it in jn/gitweb topic and then applied your whitespace\nfixes on top of the result, after discarding the whitespace\ncleanup I sent out earlier. So let's make sure we are resync'ed\nand continue from here. I'll push out the updated \"next\"\nsoonish.\n"},{"id":"22254","messageId":"e7doc6$sg7$1@sea.gmane.org","threadId":"4603","inReplyTo":"7vodwlsfek.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T09:37:09Z","receivedAt":"2006-06-22T09:37:09Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> I remember discussing things with Timo and was putting it on\n> hold since I knew you were also actively futzing on gitweb.\n\nSo when I apply someone else patches should I reply to the post\nwith patch I have applied with\n\n Acked-by: Jakub Narebski \n\nto notify of that fact?\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22255","messageId":"e7dp9m$v48$1@sea.gmane.org","threadId":"4603","inReplyTo":"7vodwlsfek.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T09:52:53Z","receivedAt":"2006-06-22T09:52:53Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub Narebski writes:\n\n>> I'm very sorry, I forgot that I applied Timo Hirvonen patch\n>>\n>> \"[PATCH] gitweb: Start search from HEAD\"\n>> Message-ID: <20060620152515.23e59396.tihirvon@gmail.com>\n> \n> But I think what you have is this one instead:\n> \n> Message-ID: <20060620164105.7276a45f.tihirvon@gmail.com>\n\nIs the 'note' extension to commit header implemented yet? It it is,then it\nwould be nice if git-am recorded original email message-ids in the note\nheader. Usually it is of no interest to user, so it should be hidden by\ndefault.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22257","messageId":"87psh1ze51.fsf@gmail.com","threadId":"4603","inReplyTo":"e7dp9m$v48$1@sea.gmane.org","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Santi Béjar","fromEmail":"sbejar@gmail.com","sentAt":"2006-06-22T10:19:22Z","receivedAt":"2006-06-22T10:19:22Z","isPatch":true,"sender":{"key":"santi@agolina.net","avatar":null},"body":"Jakub Narebski writes:\n\n> Junio C Hamano wrote:\n>\n>> Jakub Narebski writes:\n>\n>>> I'm very sorry, I forgot that I applied Timo Hirvonen patch\n>>>\n>>> \"[PATCH] gitweb: Start search from HEAD\"\n>>> Message-ID: <20060620152515.23e59396.tihirvon@gmail.com>\n>> \n>> But I think what you have is this one instead:\n>> \n>> Message-ID: <20060620164105.7276a45f.tihirvon@gmail.com>\n>\n> Is the 'note' extension to commit header implemented yet? It it is,then it\n> would be nice if git-am recorded original email message-ids in the note\n> header. Usually it is of no interest to user, so it should be hidden by\n> default.\n\nI put it at the end of the commit message, like the Signed-of-by\nlines. And, yes, it would be nice if git-am would add it (--message-id\nflag?). If more people is interested I'll try to send a patch.\n\n Santi\n"},{"id":"22258","messageId":"7v64itsd86.fsf@assigned-by-dhcp.cox.net","threadId":"4603","inReplyTo":"e7doc6$sg7$1@sea.gmane.org","subject":"Re: [PATCH] gitweb: whitespace cleanup around '='","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-22T10:20:57Z","receivedAt":"2006-06-22T10:20:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> Junio C Hamano wrote:\n>\n>> I remember discussing things with Timo and was putting it on\n>> hold since I knew you were also actively futzing on gitweb.\n>\n> So when I apply someone else patches should I reply to the post\n> with patch I have applied with\n>\n> Acked-by: Jakub Narebski \n>\n> to notify of that fact?\n\nAcked-by does not mean you've applied it to your tree, and even\nif it did, it is unfair to expect me to remember that fact when\nI review your patch later. In this particular case, a note in\nthe patch to say it depends on such and such that _I_ do not\nseem to have yet would have been more appropriate.\n\nAcked-by would also be helpful when a de-facto owner of the code\nwants to push acceptance of others' patches, but that is\nindependent from stating what a patch's prerequisites are.\n\nAnyhow, I've reviewed Timo's patch (which made sense to me too),\nand your whitespace fixes and pushed out the result, which\nhopefully will be propagating to the mirrors soon. Overall, I\nwould say that the clean-up on gitweb so far is reasonably\nstraightforward. I have been running \"next\" version of gitweb\non my private machine and haven't found regression.\n\nI'll go to bed now. Thanks for the patches.\n"},{"id":"22271","messageId":"e7e5ci$ath$1@sea.gmane.org","threadId":"4603","inReplyTo":"e7di0n$7hh$1@sea.gmane.org","subject":"Re: [WORKAROUND] gitk lower pane scrollbar extends past gitk window","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-22T13:19:14Z","receivedAt":"2006-06-22T13:19:14Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"It looks like gitk incorrectly saves the geometry in ~/.gitk\nI have to remove it before running gitk (well, it would be \nenough to remove geometry section).\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}