{"thread":{"id":"46012","subject":"[PATCH] diff: mark some file local symbols as static","startedAt":"2017-05-20T23:37:54Z","lastAt":"2017-05-22T16:43:35Z","messageCount":2,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"320360","messageId":"578bfb5b-bdd1-a418-98f2-d26e1bff0be2@ramsayjones.plus.com","threadId":"46012","inReplyTo":null,"subject":"[PATCH] diff: mark some file local symbols as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-05-20T23:37:45Z","receivedAt":"2017-05-20T23:37:54Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll your 'sb/diff-color-move' branch, could you\nplease squash this into to the relevant patches. (Each hunk would\nbe squashed into a separate commit, thus:\n  - commit 9b68d54c11, \"diff: buffer all output if asked to\"\n  - commit 4b71ba47ab, \"submodule.c: convert show_submodule_summary to use emit_line_fmt\"\n  - commit 703d25581d, \"diff.c: convert show_stats to use emit_line_*\"\n).\n\nThanks!\n\nATB,\nRamsay Jones\n\n diff.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex ba23c5862..15f389676 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -810,10 +810,10 @@ static void append_buffered_patch_line(struct diff_options *o,\n \tf->line = e->line ? xmemdupz(e->line, e->len) : NULL;\n }\n \n-void emit_line(struct diff_options *o,\n-\t       const char *set, const char *reset,\n-\t       int add_line_prefix, int markup_ws,\n-\t       int sign, const char *line, int len)\n+static void emit_line(struct diff_options *o,\n+\t\t      const char *set, const char *reset,\n+\t\t      int add_line_prefix, int markup_ws,\n+\t\t      int sign, const char *line, int len)\n {\n \tstruct buffered_patch_line e = {set, reset, line,\n \t\tlen, sign, add_line_prefix,\n@@ -825,10 +825,10 @@ void emit_line(struct diff_options *o,\n \t\temit_buffered_patch_line(o, &e);\n }\n \n-void emit_line_fmt(struct diff_options *o,\n-\t\t   const char *set, const char *reset,\n-\t\t   int add_line_prefix,\n-\t\t   const char *fmt, ...)\n+static void emit_line_fmt(struct diff_options *o,\n+\t\t\t  const char *set, const char *reset,\n+\t\t\t  int add_line_prefix,\n+\t\t\t  const char *fmt, ...)\n {\n \tstruct strbuf sb = STRBUF_INIT;\n \tva_list ap;\n@@ -1862,8 +1862,8 @@ static void fill_print_name(struct diffstat_file *file)\n \tfile->print_name = pname;\n }\n \n-void print_stat_summary_0(struct diff_options *options, int files,\n-\t\t\t  int insertions, int deletions)\n+static void print_stat_summary_0(struct diff_options *options, int files,\n+\t\t\t\t int insertions, int deletions)\n {\n \tstruct strbuf sb = STRBUF_INIT;\n \n-- \n2.13.0\n"},{"id":"320451","messageId":"CAGZ79kZsiMT3-KuPBz4WKJ7VHypGM49kwGNALVTL771iEb3w6A@mail.gmail.com","threadId":"46012","inReplyTo":"578bfb5b-bdd1-a418-98f2-d26e1bff0be2@ramsayjones.plus.com","subject":"Re: [PATCH] diff: mark some file local symbols as static","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-05-22T16:42:57Z","receivedAt":"2017-05-22T16:43:35Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Sat, May 20, 2017 at 4:37 PM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll your 'sb/diff-color-move' branch, could you\n> please squash this into to the relevant patches. (Each hunk would\n> be squashed into a separate commit, thus:\n>   - commit 9b68d54c11, \"diff: buffer all output if asked to\"\n>   - commit 4b71ba47ab, \"submodule.c: convert show_submodule_summary to use emit_line_fmt\"\n>   - commit 703d25581d, \"diff.c: convert show_stats to use emit_line_*\"\n> ).\n>\n> Thanks!\n\nWill do, thanks!\nStefan\n"}]}