{"thread":{"id":"46010","subject":"[PATCH] name-rev: use larger timestamp for is_better_name","startedAt":"2017-05-20T20:36:58Z","lastAt":"2017-05-20T23:21:43Z","messageCount":3,"participants":["Eric Wong","Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"320322","messageId":"20170520203649.GA13079@untitled","threadId":"46010","inReplyTo":null,"subject":"[PATCH] name-rev: use larger timestamp for is_better_name","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2017-05-20T20:36:49Z","receivedAt":"2017-05-20T20:36:58Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"This fixes t4202 for me at \"44 - log --graph with full output\"\non 32-bit x86.\n\nSigned-off-by: Eric Wong <e@80x24.org>\n---\n This is for pu, I'm still using the machine I used git with in 2005 :)\n\n builtin/name-rev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/name-rev.c b/builtin/name-rev.c\nindex f06498524..35409c03b 100644\n--- a/builtin/name-rev.c\n+++ b/builtin/name-rev.c\n@@ -27,7 +27,7 @@ static const char *prio_names[] = {\n \n static int is_better_name(struct rev_name *name,\n \t\t\t  const char *tip_name,\n-\t\t\t  unsigned long taggerdate,\n+\t\t\t  timestamp_t taggerdate,\n \t\t\t  int generation,\n \t\t\t  int distance,\n \t\t\t  int from_tag)\n-- \nEW\n"},{"id":"320323","messageId":"fe9ca677-1f38-4b61-a610-9f8ab014daff@ramsayjones.plus.com","threadId":"46010","inReplyTo":"20170520203649.GA13079@untitled","subject":"Re: [PATCH] name-rev: use larger timestamp for is_better_name","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-05-20T21:16:10Z","receivedAt":"2017-05-20T21:16:19Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 20/05/17 21:36, Eric Wong wrote:\n> This fixes t4202 for me at \"44 - log --graph with full output\"\n> on 32-bit x86.\n> \n> Signed-off-by: Eric Wong <e@80x24.org>\n> ---\n>  This is for pu, I'm still using the machine I used git with in 2005 :)\n> \n>  builtin/name-rev.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/builtin/name-rev.c b/builtin/name-rev.c\n> index f06498524..35409c03b 100644\n> --- a/builtin/name-rev.c\n> +++ b/builtin/name-rev.c\n> @@ -27,7 +27,7 @@ static const char *prio_names[] = {\n>  \n>  static int is_better_name(struct rev_name *name,\n>  \t\t\t  const char *tip_name,\n> -\t\t\t  unsigned long taggerdate,\n> +\t\t\t  timestamp_t taggerdate,\n>  \t\t\t  int generation,\n>  \t\t\t  int distance,\n>  \t\t\t  int from_tag)\n> \n\nHeh, you seem to be a little ahead of me. :-D\n\nI test on 32-bit Linux from time to time, and tonight's 'pu'\nbranch fails t4202.44, t6007.2,5-6,12-13,16, t6012.2-11,\nt6111.2-65. I bisected the t4202 failure to a merge commit\n(99d31e1378, merge branch 'jc/name-rev-lw-tag') and I spotted\nthe 'unsigned long' taggerdate parameter to the is_better_name()\nfunction.\n\nI was just about to try the patch above and retest, when I saw\nyour email! (so I can leave that for tonight).\n\nThanks!\n\nATB,\nRamsay Jones\n\n"},{"id":"320359","messageId":"xmqqh90fru68.fsf@gitster.mtv.corp.google.com","threadId":"46010","inReplyTo":"fe9ca677-1f38-4b61-a610-9f8ab014daff@ramsayjones.plus.com","subject":"Re: [PATCH] name-rev: use larger timestamp for is_better_name","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-05-20T23:21:35Z","receivedAt":"2017-05-20T23:21:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> I test on 32-bit Linux from time to time, and tonight's 'pu'\n> branch fails t4202.44, t6007.2,5-6,12-13,16, t6012.2-11,\n> t6111.2-65. I bisected the t4202 failure to a merge commit\n> (99d31e1378, merge branch 'jc/name-rev-lw-tag') and I spotted\n> the 'unsigned long' taggerdate parameter to the is_better_name()\n> function.\n\nThanks.  My earlier \"oh, cutoff that was long also is a timestamp\"\npatch was what I did while making this exact \"evil merge\" change,\nand then when I re-integrated everything, I forgot about it.\n\nI'll teach my rerere database about this.  Thanks.\n"}]}