{"thread":{"id":"45984","subject":"[PATCH] completion: add git stash push","startedAt":"2017-05-16T19:59:24Z","lastAt":"2017-05-17T03:16:19Z","messageCount":3,"participants":["Thomas Gummerer","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"319957","messageId":"20170516195945.745-1-t.gummerer@gmail.com","threadId":"45984","inReplyTo":null,"subject":"[PATCH] completion: add git stash push","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-05-16T19:59:45Z","receivedAt":"2017-05-16T19:59:24Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"When introducing git stash push in f5727e26e4 (\"stash: introduce push\nverb\", 2017-02-19), I forgot to add it to the completion code. Add it\nnow.\n\nSigned-off-by: Thomas Gummerer <t.gummerer@gmail.com>\n---\n contrib/completion/git-completion.bash | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex af658995d5..3f01249116 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2810,7 +2810,7 @@ _git_show_branch ()\n _git_stash ()\n {\n \tlocal save_opts='--all --keep-index --no-keep-index --quiet --patch --include-untracked'\n-\tlocal subcommands='save list show apply clear drop pop create branch'\n+\tlocal subcommands='push save list show apply clear drop pop create branch'\n \tlocal subcommand=\"$(__git_find_on_cmdline \"$subcommands\")\"\n \tif [ -z \"$subcommand\" ]; then\n \t\tcase \"$cur\" in\n@@ -2825,6 +2825,9 @@ _git_stash ()\n \t\tesac\n \telse\n \t\tcase \"$subcommand,$cur\" in\n+\t\tpush,--*)\n+\t\t\t__gitcomp \"$save_opts --message\"\n+\t\t\t;;\n \t\tsave,--*)\n \t\t\t__gitcomp \"$save_opts\"\n \t\t\t;;\n-- \n2.13.0.rc2.279.g813ba54fc\n\n"},{"id":"319958","messageId":"20170516201211.GQ27400@aiede.svl.corp.google.com","threadId":"45984","inReplyTo":"20170516195945.745-1-t.gummerer@gmail.com","subject":"Re: [PATCH] completion: add git stash push","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-05-16T20:12:11Z","receivedAt":"2017-05-16T20:12:20Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Thomas Gummerer wrote:\n\n> When introducing git stash push in f5727e26e4 (\"stash: introduce push\n> verb\", 2017-02-19), I forgot to add it to the completion code. Add it\n> now.\n>\n> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>\n> ---\n>  contrib/completion/git-completion.bash | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks.\n"},{"id":"320014","messageId":"xmqqy3twxjer.fsf@gitster.mtv.corp.google.com","threadId":"45984","inReplyTo":"20170516201211.GQ27400@aiede.svl.corp.google.com","subject":"Re: [PATCH] completion: add git stash push","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-05-17T03:16:12Z","receivedAt":"2017-05-17T03:16:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Thomas Gummerer wrote:\n>\n>> When introducing git stash push in f5727e26e4 (\"stash: introduce push\n>> verb\", 2017-02-19), I forgot to add it to the completion code. Add it\n>> now.\n>>\n>> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>\n>> ---\n>>  contrib/completion/git-completion.bash | 5 ++++-\n>>  1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks, both.  Will queue.\n"}]}