{"thread":{"id":"45807","subject":"[PATCH v1] travis-ci: printf $STATUS as string","startedAt":"2017-04-26T19:39:41Z","lastAt":"2017-04-26T19:49:51Z","messageCount":2,"participants":["Lars Schneider","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"317965","messageId":"20170426193933.28961-1-larsxschneider@gmail.com","threadId":"45807","inReplyTo":null,"subject":"[PATCH v1] travis-ci: printf $STATUS as string","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2017-04-26T19:39:33Z","receivedAt":"2017-04-26T19:39:41Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"If the $STATUS variable contains a \"%\" character then printf will\ninterpret that as invalid format string. Fix this by formatting $STATUS\nas string.\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\n---\n\nNotes:\n    Base Ref: master\n    Web-Diff: https://github.com/larsxschneider/git/commit/f08d4dc6a0\n    Checkout: git fetch https://github.com/larsxschneider/git travisci/win-fix-v1 && git checkout f08d4dc6a0\n\n ci/run-windows-build.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/ci/run-windows-build.sh b/ci/run-windows-build.sh\nindex 4e3a50b60e..e043440799 100755\n--- a/ci/run-windows-build.sh\n+++ b/ci/run-windows-build.sh\n@@ -55,7 +55,7 @@ while true\n do\n \tLAST_STATUS=$STATUS\n \tSTATUS=$(gfwci \"action=status&buildId=$BUILD_ID\")\n-\ttest \"$STATUS\" = \"$LAST_STATUS\" || printf \"\\nStatus: $STATUS \"\n+\ttest \"$STATUS\" = \"$LAST_STATUS\" || printf \"\\nStatus: %s \" \"$STATUS\"\n \tprintf \".\"\n \n \tcase \"$STATUS\" in\n\nbase-commit: e2cb6ab84c94f147f1259260961513b40c36108a\n-- \n2.12.2\n\n"},{"id":"317967","messageId":"alpine.DEB.2.20.1704262147550.3480@virtualbox","threadId":"45807","inReplyTo":"20170426193933.28961-1-larsxschneider@gmail.com","subject":"Re: [PATCH v1] travis-ci: printf $STATUS as string","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-04-26T19:49:28Z","receivedAt":"2017-04-26T19:49:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 26 Apr 2017, Lars Schneider wrote:\n\n> If the $STATUS variable contains a \"%\" character then printf will\n> interpret that as invalid format string. Fix this by formatting $STATUS\n> as string.\n> \n> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>\n\nACK.\n\nFor reference, the status should always be a single all-ASCII word, but\nsometimes it looks as if there is a server error that returns a full-blown\nHTML error page (including a style that contains something like 'width:\n10%;' which would be misinterpreted by printf as a format string).\n\nCiao,\nDscho\n"}]}