{"thread":{"id":"45796","subject":"[PATCH] Add --indent-heuristic to bash completion.","startedAt":"2017-04-25T11:38:48Z","lastAt":"2017-04-27T20:48:56Z","messageCount":5,"participants":["Martin Liška","Stefan Beller","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"317803","messageId":"bbcbdf11-5065-8fcb-d78e-74db03814781@suse.cz","threadId":"45796","inReplyTo":null,"subject":"[PATCH] Add --indent-heuristic to bash completion.","fromName":"Martin Liška","fromEmail":"mliska@suse.cz","sentAt":"2017-04-25T11:37:59Z","receivedAt":"2017-04-25T11:38:48Z","isPatch":true,"sender":{"key":"mliska@suse.cz","avatar":null},"body":"Hello.\n\nThe patch adds BASH completion for a newly added option.\n\nThanks,\nMartin\n\n\nFrom 316355276a9772cdfdd24a81f19400f176944df2 Mon Sep 17 00:00:00 2001\nFrom: marxin \nDate: Tue, 25 Apr 2017 13:35:17 +0200\nSubject: [PATCH] Add --indent-heuristic to bash completion.\n\nSigned-off-by: Martin Liska \n---\n contrib/completion/git-completion.bash | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 1150164d5..8fb25594c 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1395,7 +1395,7 @@ __git_diff_common_options=\"--stat --numstat --shortstat --summary\n \t\t\t--quiet --ext-diff --no-ext-diff\n \t\t\t--no-prefix --src-prefix= --dst-prefix=\n \t\t\t--inter-hunk-context=\n-\t\t\t--patience --histogram --minimal\n+\t\t\t--patience --histogram --indent-heuristic --minimal\n \t\t\t--raw --word-diff --word-diff-regex=\n \t\t\t--dirstat --dirstat= --dirstat-by-file\n \t\t\t--dirstat-by-file= --cumulative\n@@ -1482,6 +1482,7 @@ __git_format_patch_options=\"\n \t--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n \t--inline --suffix= --ignore-if-in-upstream --subject-prefix=\n \t--output-directory --reroll-count --to= --quiet --notes\n+\t--indent-heuristic\n \"\n \n _git_format_patch ()\n@@ -1681,6 +1682,7 @@ __git_log_common_options=\"\n \t--min-age= --until= --before=\n \t--min-parents= --max-parents=\n \t--no-min-parents --no-max-parents\n+\t--indent-heuristic\n \"\n # Options that go well for log and gitk (not shortlog)\n __git_log_gitk_options=\"\n-- \n2.12.2\n\n"},{"id":"317964","messageId":"CAGZ79kY2dmec17qdbpTqOx7Uro7X_UAyo0be5a08bdZyykA2nw@mail.gmail.com","threadId":"45796","inReplyTo":"bbcbdf11-5065-8fcb-d78e-74db03814781@suse.cz","subject":"Re: [PATCH] Add --indent-heuristic to bash completion.","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-04-26T19:38:54Z","receivedAt":"2017-04-26T19:39:01Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Apr 25, 2017 at 4:37 AM, Martin Liška wrote:\n> Hello.\n>\n> The patch adds BASH completion for a newly added option.\n>\n\nThe looks good, though the format is unusual. (We prefer the\nformat to be inline instead of an attachment)\n\nThanks,\nStefan\n"},{"id":"318063","messageId":"71692231-0a76-99f7-3577-9076b0f2e8ad@suse.cz","threadId":"45796","inReplyTo":"CAGZ79kY2dmec17qdbpTqOx7Uro7X_UAyo0be5a08bdZyykA2nw@mail.gmail.com","subject":"Re: [PATCH] Add --indent-heuristic to bash completion.","fromName":"Martin Liška","fromEmail":"mliska@suse.cz","sentAt":"2017-04-27T09:09:17Z","receivedAt":"2017-04-27T09:09:26Z","isPatch":true,"sender":{"key":"mliska@suse.cz","avatar":null},"body":"On 04/26/2017 09:38 PM, Stefan Beller wrote:\n> On Tue, Apr 25, 2017 at 4:37 AM, Martin Liška wrote:\n>> Hello.\n>>\n>> The patch adds BASH completion for a newly added option.\n>>\n> \n> The looks good, though the format is unusual. (We prefer the\n> format to be inline instead of an attachment)\n\nGood, adding inline version.\nI've read Documentation/SubmittingPatches, can you please help me which\nmaintainer should I CC?\n\nMartin\n---\n contrib/completion/git-completion.bash | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 1150164d5..8fb25594c 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1395,7 +1395,7 @@ __git_diff_common_options=\"--stat --numstat --shortstat --summary\n \t\t\t--quiet --ext-diff --no-ext-diff\n \t\t\t--no-prefix --src-prefix= --dst-prefix=\n \t\t\t--inter-hunk-context=\n-\t\t\t--patience --histogram --minimal\n+\t\t\t--patience --histogram --indent-heuristic --minimal\n \t\t\t--raw --word-diff --word-diff-regex=\n \t\t\t--dirstat --dirstat= --dirstat-by-file\n \t\t\t--dirstat-by-file= --cumulative\n@@ -1482,6 +1482,7 @@ __git_format_patch_options=\"\n \t--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n \t--inline --suffix= --ignore-if-in-upstream --subject-prefix=\n \t--output-directory --reroll-count --to= --quiet --notes\n+\t--indent-heuristic\n \"\n \n _git_format_patch ()\n@@ -1681,6 +1682,7 @@ __git_log_common_options=\"\n \t--min-age= --until= --before=\n \t--min-parents= --max-parents=\n \t--no-min-parents --no-max-parents\n+\t--indent-heuristic\n \"\n # Options that go well for log and gitk (not shortlog)\n __git_log_gitk_options=\"\n-- \n2.12.2\n"},{"id":"318072","messageId":"CAGZ79kZ7eHO+Uv1xk1UXpO39uqCEGkpnxOCMARqJP9hAtqC1gg@mail.gmail.com","threadId":"45796","inReplyTo":"71692231-0a76-99f7-3577-9076b0f2e8ad@suse.cz","subject":"Re: [PATCH] Add --indent-heuristic to bash completion.","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-04-27T16:37:11Z","receivedAt":"2017-04-27T16:37:41Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Apr 27, 2017 at 2:09 AM, Martin Liška wrote:\n> On 04/26/2017 09:38 PM, Stefan Beller wrote:\n>> On Tue, Apr 25, 2017 at 4:37 AM, Martin Liška wrote:\n>>> Hello.\n>>>\n>>> The patch adds BASH completion for a newly added option.\n>>>\n>>\n>> The looks good, though the format is unusual. (We prefer the\n>> format to be inline instead of an attachment)\n>\n> Good, adding inline version.\n> I've read Documentation/SubmittingPatches, can you please help me which\n> maintainer should I CC?\n\ncc'd Junio (the only maintainer in Git, are you a kernel developer, where\nyou have hundreds of maintainers?)\n\nThanks,\nStefan\n\n>\n> Martin\n> ---\n> contrib/completion/git-completion.bash | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 1150164d5..8fb25594c 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1395,7 +1395,7 @@ __git_diff_common_options=\"--stat --numstat --shortstat --summary\n> --quiet --ext-diff --no-ext-diff\n> --no-prefix --src-prefix= --dst-prefix=\n> --inter-hunk-context=\n> - --patience --histogram --minimal\n> + --patience --histogram --indent-heuristic --minimal\n> --raw --word-diff --word-diff-regex=\n> --dirstat --dirstat= --dirstat-by-file\n> --dirstat-by-file= --cumulative\n> @@ -1482,6 +1482,7 @@ __git_format_patch_options=\"\n> --not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n> --inline --suffix= --ignore-if-in-upstream --subject-prefix=\n> --output-directory --reroll-count --to= --quiet --notes\n> + --indent-heuristic\n> \"\n>\n> _git_format_patch ()\n> @@ -1681,6 +1682,7 @@ __git_log_common_options=\"\n> --min-age= --until= --before=\n> --min-parents= --max-parents=\n> --no-min-parents --no-max-parents\n> + --indent-heuristic\n> \"\n> # Options that go well for log and gitk (not shortlog)\n> __git_log_gitk_options=\"\n> --\n> 2.12.2\n"},{"id":"318090","messageId":"20170427204836.14129-1-szeder.dev@gmail.com","threadId":"45796","inReplyTo":"bbcbdf11-5065-8fcb-d78e-74db03814781@suse.cz","subject":"Re: [PATCH] Add --indent-heuristic to bash completion.","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2017-04-27T20:48:36Z","receivedAt":"2017-04-27T20:48:56Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"\n> The patch adds BASH completion for a newly added option.\n\nThere is a '--no-indent-heuristic' option, too, and a\n'diff.indentHeuristic' config variable as well.\n\nI'm not sure it's worth it, though. As far as I remember the future\nplans for indent heuristics, this option and config variable are only\ntemporary, and this heuristic will become the default after a few\nreleases of testing anyway (assuming that nothing prohibitive pops up\nin the meantime).\n\n\n> --------------5BA49415AE751679784E55AA\n> Content-Type: text/x-patch;\n> name=\"0001-Add-indent-heuristic-to-bash-completion.patch\"\n> Content-Transfer-Encoding: 7bit\n> Content-Disposition: attachment;\n> filename=\"0001-Add-indent-heuristic-to-bash-completion.patch\"\n> \n> >From 316355276a9772cdfdd24a81f19400f176944df2 Mon Sep 17 00:00:00 2001\n> From: marxin \n> Date: Tue, 25 Apr 2017 13:35:17 +0200\n> Subject: [PATCH] Add --indent-heuristic to bash completion.\n> \n> Signed-off-by: Martin Liska \n> ---\n> contrib/completion/git-completion.bash | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 1150164d5..8fb25594c 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1395,7 +1395,7 @@ __git_diff_common_options=\"--stat --numstat --shortstat --summary\n> \t\t\t--quiet --ext-diff --no-ext-diff\n> \t\t\t--no-prefix --src-prefix= --dst-prefix=\n> \t\t\t--inter-hunk-context=\n> -\t\t\t--patience --histogram --minimal\n> +\t\t\t--patience --histogram --indent-heuristic --minimal\n> \t\t\t--raw --word-diff --word-diff-regex=\n> \t\t\t--dirstat --dirstat= --dirstat-by-file\n> \t\t\t--dirstat-by-file= --cumulative\n> @@ -1482,6 +1482,7 @@ __git_format_patch_options=\"\n> \t--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n> \t--inline --suffix= --ignore-if-in-upstream --subject-prefix=\n> \t--output-directory --reroll-count --to= --quiet --notes\n> +\t--indent-heuristic\n> \"\n> \n> _git_format_patch ()\n> @@ -1681,6 +1682,7 @@ __git_log_common_options=\"\n> \t--min-age= --until= --before=\n> \t--min-parents= --max-parents=\n> \t--no-min-parents --no-max-parents\n> +\t--indent-heuristic\n> \"\n> # Options that go well for log and gitk (not shortlog)\n> __git_log_gitk_options=\"\n> -- \n> 2.12.2\n"}]}