{"thread":{"id":"45705","subject":"[PATCH] t1400: use consistent style for test_expect_success calls","startedAt":"2017-04-16T02:31:16Z","lastAt":"2017-04-16T04:28:17Z","messageCount":2,"participants":["Kyle Meyer","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"316903","messageId":"20170416023102.25387-1-kyle@kyleam.com","threadId":"45705","inReplyTo":null,"subject":"[PATCH] t1400: use consistent style for test_expect_success calls","fromName":"Kyle Meyer","fromEmail":"kyle@kyleam.com","sentAt":"2017-04-16T02:31:02Z","receivedAt":"2017-04-16T02:31:16Z","isPatch":true,"sender":{"key":"kyle@kyleam.com","avatar":"https://avatars.githubusercontent.com/u/1297788?v=4"},"body":"Structure calls as\n\n    test_expect_success 'description' '\n    \tbody\n    '\n\nUse double quotes for the description if it requires parameter\nexpansion or contains a single quote.\n\nSigned-off-by: Kyle Meyer <kyle@kyleam.com>\n---\nThis patch follows up on a recent t1400 series:\nhttps://public-inbox.org/git/xmqq8tnysekm.fsf@gitster.mtv.corp.google.com/\n\n t/t1400-update-ref.sh | 335 +++++++++++++++++++++++++-------------------------\n 1 file changed, 167 insertions(+), 168 deletions(-)\n\ndiff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh\nindex a23cd7b57..dc98b4bc6 100755\n--- a/t/t1400-update-ref.sh\n+++ b/t/t1400-update-ref.sh\n@@ -35,14 +35,14 @@ test_expect_success setup '\n \tcd -\n '\n \n-test_expect_success \\\n-\t\"create $m\" \\\n-\t\"git update-ref $m $A &&\n-\t test $A\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"create $m with oldvalue verification\" \\\n-\t\"git update-ref $m $B $A &&\n-\t test $B\"' = $(cat .git/'\"$m\"')'\n+test_expect_success \"create $m\" '\n+\tgit update-ref $m $A &&\n+\ttest $A = $(cat .git/$m)\n+'\n+test_expect_success \"create $m with oldvalue verification\" '\n+\tgit update-ref $m $B $A &&\n+\ttest $B = $(cat .git/$m)\n+'\n test_expect_success \"fail to delete $m with stale ref\" '\n \ttest_must_fail git update-ref -d $m $A &&\n \ttest $B = \"$(cat .git/$m)\"\n@@ -67,14 +67,14 @@ test_expect_success \"fail to create $n\" '\n \ttest_must_fail git update-ref $n $A\n '\n \n-test_expect_success \\\n-\t\"create $m (by HEAD)\" \\\n-\t\"git update-ref HEAD $A &&\n-\t test $A\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"create $m (by HEAD) with oldvalue verification\" \\\n-\t\"git update-ref HEAD $B $A &&\n-\t test $B\"' = $(cat .git/'\"$m\"')'\n+test_expect_success \"create $m (by HEAD)\" '\n+\tgit update-ref HEAD $A &&\n+\ttest $A = $(cat .git/$m)\n+'\n+test_expect_success \"create $m (by HEAD) with oldvalue verification\" '\n+\tgit update-ref HEAD $B $A &&\n+\ttest $B = $(cat .git/$m)\n+'\n test_expect_success \"fail to delete $m (by HEAD) with stale ref\" '\n \ttest_must_fail git update-ref -d HEAD $A &&\n \ttest $B = $(cat .git/$m)\n@@ -176,17 +176,17 @@ test_expect_success '--no-create-reflog overrides core.logAllRefUpdates=always'\n \ttest_must_fail git reflog exists $outside\n '\n \n-test_expect_success \\\n-\t\"create $m (by HEAD)\" \\\n-\t\"git update-ref HEAD $A &&\n-\t test $A\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"pack refs\" \\\n-\t\"git pack-refs --all\"\n-test_expect_success \\\n-\t\"move $m (by HEAD)\" \\\n-\t\"git update-ref HEAD $B $A &&\n-\t test $B\"' = $(cat .git/'\"$m\"')'\n+test_expect_success \"create $m (by HEAD)\" '\n+\tgit update-ref HEAD $A &&\n+\ttest $A = $(cat .git/$m)\n+'\n+test_expect_success 'pack refs' '\n+\tgit pack-refs --all\n+'\n+test_expect_success \"move $m (by HEAD)\" '\n+\tgit update-ref HEAD $B $A &&\n+\ttest $B = $(cat .git/$m)\n+'\n test_expect_success \"delete $m (by HEAD) should remove both packed and loose $m\" '\n \ttest_when_finished \"rm -f .git/$m\" &&\n \tgit update-ref -d HEAD $B &&\n@@ -195,13 +195,13 @@ test_expect_success \"delete $m (by HEAD) should remove both packed and loose $m\"\n '\n \n cp -f .git/HEAD .git/HEAD.orig\n-test_expect_success \"delete symref without dereference\" '\n+test_expect_success 'delete symref without dereference' '\n \ttest_when_finished \"cp -f .git/HEAD.orig .git/HEAD\" &&\n \tgit update-ref --no-deref -d HEAD &&\n \ttest_path_is_missing .git/HEAD\n '\n \n-test_expect_success \"delete symref without dereference when the referred ref is packed\" '\n+test_expect_success 'delete symref without dereference when the referred ref is packed' '\n \ttest_when_finished \"cp -f .git/HEAD.orig .git/HEAD\" &&\n \techo foo >foo.c &&\n \tgit add foo.c &&\n@@ -239,46 +239,46 @@ test_expect_success 'update-ref --no-deref -d can delete reference to bad ref' '\n \ttest_path_is_missing .git/refs/heads/ref-to-bad\n '\n \n-test_expect_success '(not) create HEAD with old sha1' \"\n+test_expect_success '(not) create HEAD with old sha1' '\n \ttest_must_fail git update-ref HEAD $A $B\n-\"\n+'\n test_expect_success \"(not) prior created .git/$m\" '\n \ttest_when_finished \"rm -f .git/$m\" &&\n \ttest_path_is_missing .git/$m\n '\n \n-test_expect_success \\\n-\t\"create HEAD\" \\\n-\t\"git update-ref HEAD $A\"\n-test_expect_success '(not) change HEAD with wrong SHA1' \"\n+test_expect_success 'create HEAD' '\n+\tgit update-ref HEAD $A\n+'\n+test_expect_success '(not) change HEAD with wrong SHA1' '\n \ttest_must_fail git update-ref HEAD $B $Z\n-\"\n+'\n test_expect_success \"(not) changed .git/$m\" '\n \ttest_when_finished \"rm -f .git/$m\" &&\n \t! test $B = $(cat .git/$m)\n '\n \n rm -f .git/logs/refs/heads/master\n-test_expect_success \\\n-\t\"create $m (logged by touch)\" \\\n-\t'test_config core.logAllRefUpdates false &&\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:30\" \\\n-\t git update-ref --create-reflog HEAD '\"$A\"' -m \"Initial Creation\" &&\n-\t test '\"$A\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"update $m (logged by touch)\" \\\n-\t'test_config core.logAllRefUpdates false &&\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:31\" \\\n-\t git update-ref HEAD'\" $B $A \"'-m \"Switch\" &&\n-\t test '\"$B\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"set $m (logged by touch)\" \\\n-\t'test_config core.logAllRefUpdates false &&\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:41\" \\\n-\t git update-ref HEAD'\" $A &&\n-\t test $A\"' = $(cat .git/'\"$m\"')'\n-\n-test_expect_success \"empty directory removal\" '\n+test_expect_success \"create $m (logged by touch)\" '\n+\ttest_config core.logAllRefUpdates false &&\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:30\" \\\n+\tgit update-ref --create-reflog HEAD $A -m \"Initial Creation\" &&\n+\ttest $A = $(cat .git/$m)\n+'\n+test_expect_success \"update $m (logged by touch)\" '\n+\ttest_config core.logAllRefUpdates false &&\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:31\" \\\n+\tgit update-ref HEAD $B $A -m \"Switch\" &&\n+\ttest $B = $(cat .git/$m)\n+'\n+test_expect_success \"set $m (logged by touch)\" '\n+\ttest_config core.logAllRefUpdates false &&\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:41\" \\\n+\tgit update-ref HEAD $A &&\n+\ttest $A = $(cat .git/$m)\n+'\n+\n+test_expect_success 'empty directory removal' '\n \tgit branch d1/d2/r1 HEAD &&\n \tgit branch d1/r2 HEAD &&\n \ttest_path_is_file .git/refs/heads/d1/d2/r1 &&\n@@ -290,7 +290,7 @@ test_expect_success \"empty directory removal\" '\n \ttest_path_is_file .git/logs/refs/heads/d1/r2\n '\n \n-test_expect_success \"symref empty directory removal\" '\n+test_expect_success 'symref empty directory removal' '\n \tgit branch e1/e2/r1 HEAD &&\n \tgit branch e1/r2 HEAD &&\n \tgit checkout e1/e2/r1 &&\n@@ -315,34 +315,34 @@ test_expect_success \"verifying $m's log (logged by touch)\" '\n \ttest_cmp expect .git/logs/$m\n '\n \n-test_expect_success \\\n-\t\"create $m (logged by config)\" \\\n-\t'test_config core.logAllRefUpdates true &&\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:32\" \\\n-\t git update-ref HEAD'\" $A \"'-m \"Initial Creation\" &&\n-\t test '\"$A\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"update $m (logged by config)\" \\\n-\t'test_config core.logAllRefUpdates true &&\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:33\" \\\n-\t git update-ref HEAD'\" $B $A \"'-m \"Switch\" &&\n-\t test '\"$B\"' = $(cat .git/'\"$m\"')'\n-test_expect_success \\\n-\t\"set $m (logged by config)\" \\\n-\t'test_config core.logAllRefUpdates true &&\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:43\" \\\n-\t git update-ref HEAD '\"$A &&\n-\t test $A\"' = $(cat .git/'\"$m\"')'\n+test_expect_success \"create $m (logged by config)\" '\n+\ttest_config core.logAllRefUpdates true &&\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:32\" \\\n+\tgit update-ref HEAD $A -m \"Initial Creation\" &&\n+\ttest $A = $(cat .git/$m)\n+'\n+test_expect_success \"update $m (logged by config)\" '\n+\ttest_config core.logAllRefUpdates true &&\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:33\" \\\n+\tgit update-ref HEAD'\" $B $A \"'-m \"Switch\" &&\n+\ttest $B = $(cat .git/$m)\n+'\n+test_expect_success \"set $m (logged by config)\" '\n+\ttest_config core.logAllRefUpdates true &&\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:43\" \\\n+\tgit update-ref HEAD $A &&\n+\ttest $A = $(cat .git/$m)\n+'\n \n cat >expect <<EOF\n $Z $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150320 +0000\tInitial Creation\n $A $B $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150380 +0000\tSwitch\n $B $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150980 +0000\n EOF\n-test_expect_success \\\n-\t\"verifying $m's log (logged by config)\" \\\n-\t'test_when_finished \"rm -f .git/$m .git/logs/$m expect\" &&\n-\t test_cmp expect .git/logs/$m'\n+test_expect_success \"verifying $m's log (logged by config)\" '\n+\ttest_when_finished \"rm -f .git/$m .git/logs/$m expect\" &&\n+\ttest_cmp expect .git/logs/$m\n+'\n \n git update-ref $m $D\n cat >.git/logs/$m <<EOF\n@@ -356,86 +356,85 @@ EOF\n ed=\"Thu, 26 May 2005 18:32:00 -0500\"\n gd=\"Thu, 26 May 2005 18:33:00 -0500\"\n ld=\"Thu, 26 May 2005 18:43:00 -0500\"\n-test_expect_success \\\n-\t'Query \"master@{May 25 2005}\" (before history)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{May 25 2005}\" >o 2>e &&\n-\t test '\"$C\"' = $(cat o) &&\n-\t test \"warning: Log for '\\'master\\'' only goes back to $ed.\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t\"Query master@{2005-05-25} (before history)\" \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify master@{2005-05-25} >o 2>e &&\n-\t test '\"$C\"' = $(cat o) &&\n-\t echo test \"warning: Log for '\\'master\\'' only goes back to $ed.\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{May 26 2005 23:31:59}\" (1 second before history)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{May 26 2005 23:31:59}\" >o 2>e &&\n-\t test '\"$C\"' = $(cat o) &&\n-\t test \"warning: Log for '\\''master'\\'' only goes back to $ed.\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{May 26 2005 23:32:00}\" (exactly history start)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{May 26 2005 23:32:00}\" >o 2>e &&\n-\t test '\"$C\"' = $(cat o) &&\n-\t test \"\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{May 26 2005 23:32:30}\" (first non-creation change)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{May 26 2005 23:32:30}\" >o 2>e &&\n-\t test '\"$A\"' = $(cat o) &&\n-\t test \"\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{2005-05-26 23:33:01}\" (middle of history with gap)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{2005-05-26 23:33:01}\" >o 2>e &&\n-\t test '\"$B\"' = $(cat o) &&\n-\t test \"warning: Log for ref '\"$m has gap after $gd\"'.\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{2005-05-26 23:38:00}\" (middle of history)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{2005-05-26 23:38:00}\" >o 2>e &&\n-\t test '\"$Z\"' = $(cat o) &&\n-\t test \"\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{2005-05-26 23:43:00}\" (exact end of history)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{2005-05-26 23:43:00}\" >o 2>e &&\n-\t test '\"$E\"' = $(cat o) &&\n-\t test \"\" = \"$(cat e)\"'\n-test_expect_success \\\n-\t'Query \"master@{2005-05-28}\" (past end of history)' \\\n-\t'test_when_finished \"rm -f o e\" &&\n-\t git rev-parse --verify \"master@{2005-05-28}\" >o 2>e &&\n-\t test '\"$D\"' = $(cat o) &&\n-\t test \"warning: Log for ref '\"$m unexpectedly ended on $ld\"'.\" = \"$(cat e)\"'\n-\n+test_expect_success 'Query \"master@{May 25 2005}\" (before history)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{May 25 2005}\" >o 2>e &&\n+\ttest $C = $(cat o) &&\n+\ttest \"warning: Log for '\\''master'\\'' only goes back to $ed.\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query master@{2005-05-25} (before history)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify master@{2005-05-25} >o 2>e &&\n+\ttest $C = $(cat o) &&\n+\techo test \"warning: Log for '\\''master'\\'' only goes back to $ed.\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{May 26 2005 23:31:59}\" (1 second before history)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{May 26 2005 23:31:59}\" >o 2>e &&\n+\ttest $C = $(cat o) &&\n+\ttest \"warning: Log for '\\''master'\\'' only goes back to $ed.\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{May 26 2005 23:32:00}\" (exactly history start)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{May 26 2005 23:32:00}\" >o 2>e &&\n+\ttest $C = $(cat o) &&\n+\ttest \"\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{May 26 2005 23:32:30}\" (first non-creation change)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{May 26 2005 23:32:30}\" >o 2>e &&\n+\ttest $A = $(cat o) &&\n+\ttest \"\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{2005-05-26 23:33:01}\" (middle of history with gap)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{2005-05-26 23:33:01}\" >o 2>e &&\n+\ttest $B = $(cat o) &&\n+\ttest \"warning: Log for ref $m has gap after $gd.\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{2005-05-26 23:38:00}\" (middle of history)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{2005-05-26 23:38:00}\" >o 2>e &&\n+\ttest $Z = $(cat o) &&\n+\ttest \"\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{2005-05-26 23:43:00}\" (exact end of history)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{2005-05-26 23:43:00}\" >o 2>e &&\n+\ttest $E = $(cat o) &&\n+\ttest \"\" = \"$(cat e)\"\n+'\n+test_expect_success 'Query \"master@{2005-05-28}\" (past end of history)' '\n+\ttest_when_finished \"rm -f o e\" &&\n+\tgit rev-parse --verify \"master@{2005-05-28}\" >o 2>e &&\n+\ttest $D = $(cat o) &&\n+\ttest \"warning: Log for ref $m unexpectedly ended on $ld.\" = \"$(cat e)\"\n+'\n \n rm -f .git/$m .git/logs/$m expect\n \n-test_expect_success \\\n-    'creating initial files' \\\n-    'test_when_finished rm -f M &&\n-     echo TEST >F &&\n-     git add F &&\n-\t GIT_AUTHOR_DATE=\"2005-05-26 23:30\" \\\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:30\" git commit -m add -a &&\n-\t h_TEST=$(git rev-parse --verify HEAD) &&\n-\t echo The other day this did not work. >M &&\n-\t echo And then Bob told me how to fix it. >>M &&\n-\t echo OTHER >F &&\n-\t GIT_AUTHOR_DATE=\"2005-05-26 23:41\" \\\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:41\" git commit -F M -a &&\n-\t h_OTHER=$(git rev-parse --verify HEAD) &&\n-\t GIT_AUTHOR_DATE=\"2005-05-26 23:44\" \\\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:44\" git commit --amend &&\n-\t h_FIXED=$(git rev-parse --verify HEAD) &&\n-\t echo Merged initial commit and a later commit. >M &&\n-\t echo $h_TEST >.git/MERGE_HEAD &&\n-\t GIT_AUTHOR_DATE=\"2005-05-26 23:45\" \\\n-\t GIT_COMMITTER_DATE=\"2005-05-26 23:45\" git commit -F M &&\n-\t h_MERGED=$(git rev-parse --verify HEAD)'\n+test_expect_success 'creating initial files' '\n+\ttest_when_finished rm -f M &&\n+\techo TEST >F &&\n+\tgit add F &&\n+\tGIT_AUTHOR_DATE=\"2005-05-26 23:30\" \\\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:30\" git commit -m add -a &&\n+\th_TEST=$(git rev-parse --verify HEAD) &&\n+\techo The other day this did not work. >M &&\n+\techo And then Bob told me how to fix it. >>M &&\n+\techo OTHER >F &&\n+\tGIT_AUTHOR_DATE=\"2005-05-26 23:41\" \\\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:41\" git commit -F M -a &&\n+\th_OTHER=$(git rev-parse --verify HEAD) &&\n+\tGIT_AUTHOR_DATE=\"2005-05-26 23:44\" \\\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:44\" git commit --amend &&\n+\th_FIXED=$(git rev-parse --verify HEAD) &&\n+\techo Merged initial commit and a later commit. >M &&\n+\techo $h_TEST >.git/MERGE_HEAD &&\n+\tGIT_AUTHOR_DATE=\"2005-05-26 23:45\" \\\n+\tGIT_COMMITTER_DATE=\"2005-05-26 23:45\" git commit -F M &&\n+\th_MERGED=$(git rev-parse --verify HEAD)\n+'\n \n cat >expect <<EOF\n $Z $h_TEST $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150200 +0000\tcommit (initial): add\n@@ -443,20 +442,20 @@ $h_TEST $h_OTHER $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150860 +0000\tcom\n $h_OTHER $h_FIXED $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117151040 +0000\tcommit (amend): The other day this did not work.\n $h_FIXED $h_MERGED $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117151100 +0000\tcommit (merge): Merged initial commit and a later commit.\n EOF\n-test_expect_success \\\n-\t'git commit logged updates' \\\n-\t\"test_cmp expect .git/logs/$m\"\n+test_expect_success 'git commit logged updates' '\n+\ttest_cmp expect .git/logs/$m\n+'\n unset h_TEST h_OTHER h_FIXED h_MERGED\n \n-test_expect_success \\\n-\t'git cat-file blob master:F (expect OTHER)' \\\n-\t'test OTHER = $(git cat-file blob master:F)'\n-test_expect_success \\\n-\t'git cat-file blob master@{2005-05-26 23:30}:F (expect TEST)' \\\n-\t'test TEST = $(git cat-file blob \"master@{2005-05-26 23:30}:F\")'\n-test_expect_success \\\n-\t'git cat-file blob master@{2005-05-26 23:42}:F (expect OTHER)' \\\n-\t'test OTHER = $(git cat-file blob \"master@{2005-05-26 23:42}:F\")'\n+test_expect_success 'git cat-file blob master:F (expect OTHER)' '\n+\ttest OTHER = $(git cat-file blob master:F)\n+'\n+test_expect_success 'git cat-file blob master@{2005-05-26 23:30}:F (expect TEST)' '\n+\ttest TEST = $(git cat-file blob \"master@{2005-05-26 23:30}:F\")\n+'\n+test_expect_success 'git cat-file blob master@{2005-05-26 23:42}:F (expect OTHER)' '\n+\ttest OTHER = $(git cat-file blob \"master@{2005-05-26 23:42}:F\")\n+'\n \n a=refs/heads/a\n b=refs/heads/b\n-- \n2.12.2\n\n"},{"id":"316907","messageId":"20170416042810.yrofz2nazsiyshmf@sigill.intra.peff.net","threadId":"45705","inReplyTo":"20170416023102.25387-1-kyle@kyleam.com","subject":"Re: [PATCH] t1400: use consistent style for test_expect_success calls","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-04-16T04:28:10Z","receivedAt":"2017-04-16T04:28:17Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Apr 15, 2017 at 10:31:02PM -0400, Kyle Meyer wrote:\n\n> Structure calls as\n> \n>     test_expect_success 'description' '\n>     \tbody\n>     '\n> \n> Use double quotes for the description if it requires parameter\n> expansion or contains a single quote.\n> \n> Signed-off-by: Kyle Meyer <kyle@kyleam.com>\n\nLooks good to me.\n\n> -test_expect_success \\\n> -    'creating initial files' \\\n> -    'test_when_finished rm -f M &&\n> -     echo TEST >F &&\n> -     git add F &&\n> -\t GIT_AUTHOR_DATE=\"2005-05-26 23:30\" \\\n> -\t GIT_COMMITTER_DATE=\"2005-05-26 23:30\" git commit -m add -a &&\n\nNot even sure what's going on with the indentation here in the original.\nI don't see any reason this \"git add\" should start an indented block.\nThis and the other whitespace fixes all look improvements to me.\n\n-Peff\n"}]}