{"thread":{"id":"4569","subject":"[PATCH] Make CSS file gitweb/gitweb.css more readable","startedAt":"2006-06-19T18:27:59Z","lastAt":"2006-06-20T03:48:36Z","messageCount":5,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"22070","messageId":"e76qbi$tt9$1@sea.gmane.org","threadId":"4569","inReplyTo":null,"subject":"[PATCH] Make CSS file gitweb/gitweb.css more readable","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-19T18:27:59Z","receivedAt":"2006-06-19T18:27:59Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Taken from git://git.xmms.se/xmms2/gitweb-xmms2.git\ncommit  561262030d58a6325f500b36d836dbe02a5abc68\n\"Make CSS readable\" by Daniel Svensson, with extra\nparts removed and consistent whitespace usage.\n---\n\n gitweb/gitweb.css |  273 +++++++++++++++++++++++++++++++++++++++++++----------\n 1 files changed, 223 insertions(+), 50 deletions(-)\n\n72888c0a080d95117d54dc9578dc2a0de7b19abd\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 5900916..9d91426 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -1,58 +1,231 @@\n body {\n-       font-family: sans-serif; font-size: 12px; border:solid #d9d8d1; border-width:1px;\n-       margin:10px; background-color:#ffffff; color:#000000;\n-}\n-a { color:#0000cc; }\n-a:hover, a:visited, a:active { color:#880000; }\n-div.page_header { height:25px; padding:8px; font-size:18px; font-weight:bold; background-color:#d9d8d1; }\n-div.page_header a:visited, a.header { color:#0000cc; }\n-div.page_header a:hover { color:#880000; }\n-div.page_nav { padding:8px; }\n-div.page_nav a:visited { color:#0000cc; }\n-div.page_path { padding:8px; border:solid #d9d8d1; border-width:0px 0px 1px}\n-div.page_footer { height:17px; padding:4px 8px; background-color: #d9d8d1; }\n-div.page_footer_text { float:left; color:#555555; font-style:italic; }\n-div.page_body { padding:8px; }\n+       font-family: sans-serif;\n+       font-size: 12px;\n+       border:solid #d9d8d1;\n+       border-width: 1px;\n+       margin: 10px;\n+       background-color: #ffffff;\n+       color: #000000;\n+}\n+\n+a { \n+       color: #0000cc;\n+}\n+\n+a:hover, a:visited, a:active {\n+       color: #880000;\n+}\n+\n+div.page_header {\n+       height: 25px;\n+       padding: 8px;\n+       font-size: 18px;\n+       font-weight: bold;\n+       background-color: #d9d8d1;\n+}\n+\n+div.page_header a:visited, a.header {\n+       color: #0000cc;\n+}\n+\n+div.page_header a:hover {\n+       color: #880000;\n+}\n+\n+div.page_nav {\n+       padding:8px;\n+}\n+\n+div.page_nav a:visited {\n+       color: #0000cc;\n+}\n+\n+div.page_path {\n+       padding: 8px;\n+       border: solid #d9d8d1;\n+       border-width: 0px 0px 1px;\n+}\n+\n+div.page_footer {\n+       height: 17px;\n+       padding: 4px 8px;\n+       background-color: #d9d8d1;\n+}\n+\n+div.page_footer_text {\n+       float: left;\n+       color: #555555;\n+       font-style: italic;\n+}\n+\n+div.page_body {\n+       padding: 8px;\n+}\n+\n div.title, a.title {\n-       display:block; padding:6px 8px;\n-       font-weight:bold; background-color:#edece6; text-decoration:none; color:#000000;\n+       display: block;\n+       padding: 6px 8px;\n+       font-weight: bold;\n+       background-color: #edece6;\n+       text-decoration: none;\n+       color: #000000;\n+}\n+\n+a.title:hover {\n+       background-color: #d9d8d1;\n+}\n+\n+div.title_text {\n+       padding: 6px 0px;\n+       border: solid #d9d8d1;\n+       border-width: 0px 0px 1px;\n }\n-a.title:hover { background-color: #d9d8d1; }\n-div.title_text { padding:6px 0px; border: solid #d9d8d1; border-width:0px 0px 1px; }\n-div.log_body { padding:8px 8px 8px 150px; }\n-span.age { position:relative; float:left; width:142px; font-style:italic; }\n+\n+div.log_body {\n+       padding: 8px 8px 8px 150px;\n+}\n+\n+span.age {\n+       position: relative;\n+       float: left;\n+       width: 142px;\n+       font-style:italic;\n+}\n+\n div.log_link {\n-       padding:0px 8px;\n-       font-size:10px; font-family:sans-serif; font-style:normal;\n-       position:relative; float:left; width:136px;\n-}\n-div.list_head { padding:6px 8px 4px; border:solid #d9d8d1; border-width:1px 0px 0px; font-style:italic; }\n-a.list { text-decoration:none; color:#000000; }\n-a.list:hover { text-decoration:underline; color:#880000; }\n-a.text { text-decoration:none; color:#0000cc; }\n-a.text:visited { text-decoration:none; color:#880000; }\n-a.text:hover { text-decoration:underline; color:#880000; }\n-table { padding:8px 4px; }\n-th { padding:2px 5px; font-size:12px; text-align:left; }\n-tr.light:hover { background-color:#edece6; }\n-tr.dark { background-color:#f6f6f0; }\n-tr.dark:hover { background-color:#edece6; }\n-td { padding:2px 5px; font-size:12px; vertical-align:top; }\n-td.link { padding:2px 5px; font-family:sans-serif; font-size:10px; }\n-div.pre { font-family:monospace; font-size:12px; white-space:pre; }\n-div.diff_info { font-family:monospace; color:#000099; background-color:#edece6; font-style:italic; }\n-div.index_include { border:solid #d9d8d1; border-width:0px 0px 1px; padding:12px 8px; }\n-div.search { margin:4px 8px; position:absolute; top:56px; right:12px }\n-a.linenr { color:#999999; text-decoration:none }\n+       padding: 0px 8px;\n+       font-size: 10px;\n+       font-family: sans-serif;\n+       font-style:normal;\n+       position: relative;\n+       float: left;\n+       width: 136px;\n+}\n+\n+div.list_head {\n+       padding: 6px 8px 4px;\n+       border: solid #d9d8d1;\n+       border-width: 1px 0px 0px;\n+       font-style: italic;\n+}\n+\n+a.list {\n+       text-decoration: none;\n+       color: #000000;\n+}\n+\n+a.list:hover {\n+       text-decoration: underline;\n+       color: #880000;\n+}\n+\n+a.text {\n+       text-decoration: none;\n+       color: #0000cc;\n+}\n+\n+a.text:visited {\n+       text-decoration: none;\n+       color: #880000;\n+}\n+\n+a.text:hover {\n+       text-decoration: underline;\n+       color: #880000;\n+}\n+\n+table {\n+       padding: 8px 4px;\n+}\n+\n+th {\n+       padding: 2px 5px;\n+       font-size: 12px;\n+       text-align: left;\n+}\n+\n+tr.light:hover {\n+       background-color: #edece6;\n+}\n+\n+tr.dark {\n+       background-color: #f6f6f0;\n+}\n+\n+tr.dark:hover {\n+       background-color: #edece6;\n+}\n+\n+\n+td {\n+       padding: 2px 5px;\n+       font-size: 12px;\n+       vertical-align:top;\n+}\n+\n+td.link {\n+       padding: 2px 5px;\n+       font-family: sans-serif;\n+       font-size: 10px;\n+}\n+\n+div.pre {\n+       font-family: monospace;\n+       font-size: 12px;\n+       white-space: pre;\n+       /* padding-left: 5px; */\n+}\n+\n+div.diff_info {\n+       font-family: monospace;\n+       color: #000099;\n+       background-color: #edece6;\n+       font-style: italic;\n+}\n+\n+div.index_include {\n+       border: solid #d9d8d1;\n+       border-width: 0px 0px 1px;\n+       padding: 12px 8px;\n+}\n+\n+div.search {\n+       margin: 4px 8px;\n+       position: absolute;\n+       top: 56px;\n+       right: 12px\n+}\n+\n+a.linenr {\n+       color: #999999;\n+       text-decoration: none\n+}\n+\n a.rss_logo {\n-       float:right; padding:3px 0px; width:35px; line-height:10px;\n-       border:1px solid; border-color:#fcc7a5 #7d3302 #3e1a01 #ff954e;\n-       color:#ffffff; background-color:#ff6600;\n-       font-weight:bold; font-family:sans-serif; font-size:10px;\n-       text-align:center; text-decoration:none;\n+       float: right;\n+       padding: 3px 0px;\n+       width: 35px;\n+       line-height: 10px;\n+       border: 1px solid;\n+       border-color: #fcc7a5 #7d3302 #3e1a01 #ff954e;\n+       color: #ffffff;\n+       background-color: #ff6600;\n+       font-weight: bold;\n+       font-family: sans-serif;\n+       font-size: 10px;\n+       text-align: center;\n+       text-decoration: none;\n+}\n+\n+a.rss_logo:hover {\n+       background-color: #ee5500;\n }\n-a.rss_logo:hover { background-color:#ee5500; }\n+\n span.tag {\n-       padding:0px 4px; font-size:10px; font-weight:normal;\n-       background-color:#ffffaa; border:1px solid; border-color:#ffffcc #ffee00 #ffee00 #ffffcc;\n+       padding: 0px 4px;\n+       font-size: 10px;\n+       font-weight: normal;\n+       background-color: #ffffaa;\n+       border: 1px solid;\n+       border-color: #ffffcc #ffee00 #ffee00 #ffffcc;\n }\n-- \n1.3.0\n"},{"id":"22073","messageId":"7vwtbc9a45.fsf@assigned-by-dhcp.cox.net","threadId":"4569","inReplyTo":"e76qbi$tt9$1@sea.gmane.org","subject":"Re: [PATCH] Make CSS file gitweb/gitweb.css more readable","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-19T20:14:02Z","receivedAt":"2006-06-19T20:14:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub, I've been applying your patches after hand-fixing but it\nappears that there is serious whitespace breakage on the mail\npath somewhere between you and the mailing list.  Please check\nyour MUA.\n\nFor example:\n\n>  div.title, a.title {\n> -       display:block; padding:6px 8px;\n> -       font-weight:bold; background-color:#edece6; text-decoration:none; color:#000000;\n\nThe original indents these two lines with a TAB.\n\nI'll hand-munge your patch again and will clean-up the\nindentation and push the result out as part of \"next\" sometime\nlater.\n\nAlso I've removed the commented out \"padding-left\" in div.pre.\n"},{"id":"22099","messageId":"e77prc$v40$1@sea.gmane.org","threadId":"4569","inReplyTo":"7vwtbc9a45.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Make CSS file gitweb/gitweb.css more readable","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-20T03:25:34Z","receivedAt":"2006-06-20T03:25:34Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Jakub, I've been applying your patches after hand-fixing but it\n> appears that there is serious whitespace breakage on the mail\n> path somewhere between you and the mailing list.  Please check\n> your MUA.\n\nChecking:\n--inserted file--\ntest\n        tab test\n         tab+space test\n space test\nempty line below\n\nline with tab only below\n        \n-- \nSignature\n--end of inserted file--\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22100","messageId":"e77q8j$v40$2@sea.gmane.org","threadId":"4569","inReplyTo":"e77prc$v40$1@sea.gmane.org","subject":"Re: [PATCH] Make CSS file gitweb/gitweb.css more readable","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-20T03:32:37Z","receivedAt":"2006-06-20T03:32:37Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jakub Narebski wrote:\n\n> Junio C Hamano wrote:\n> \n>> Jakub, I've been applying your patches after hand-fixing but it\n>> appears that there is serious whitespace breakage on the mail\n>> path somewhere between you and the mailing list.  Please check\n>> your MUA.\n> \n> Checking:\n\nIt looks like KNode/0.7.7 (from KDE 3.2.2) converts tabs to spaces\neven for inserted files.\n\nI'll use email client (KMail or git-send-email) in the future.\n\n\nI'll be resending the patch as part of larger series in near future.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"22101","messageId":"11507752922146-git-send-email-jnareb@gmail.com","threadId":"4569","inReplyTo":"7vwtbc9a45.fsf@assigned-by-dhcp.cox.net","subject":"[PATCH] Make CSS file gitweb/gitweb.css more readable","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-06-20T03:48:36Z","receivedAt":"2006-06-20T03:48:36Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"---\n\n gitweb/gitweb.css |  273 +++++++++++++++++++++++++++++++++++++++++++----------\n 1 files changed, 223 insertions(+), 50 deletions(-)\n\n72888c0a080d95117d54dc9578dc2a0de7b19abd\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 5900916..9d91426 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -1,58 +1,231 @@\n body {\n-\tfont-family: sans-serif; font-size: 12px; border:solid #d9d8d1; border-width:1px;\n-\tmargin:10px; background-color:#ffffff; color:#000000;\n-}\n-a { color:#0000cc; }\n-a:hover, a:visited, a:active { color:#880000; }\n-div.page_header { height:25px; padding:8px; font-size:18px; font-weight:bold; background-color:#d9d8d1; }\n-div.page_header a:visited, a.header { color:#0000cc; }\n-div.page_header a:hover { color:#880000; }\n-div.page_nav { padding:8px; }\n-div.page_nav a:visited { color:#0000cc; }\n-div.page_path { padding:8px; border:solid #d9d8d1; border-width:0px 0px 1px}\n-div.page_footer { height:17px; padding:4px 8px; background-color: #d9d8d1; }\n-div.page_footer_text { float:left; color:#555555; font-style:italic; }\n-div.page_body { padding:8px; }\n+\tfont-family: sans-serif;\n+\tfont-size: 12px;\n+\tborder:solid #d9d8d1;\n+\tborder-width: 1px;\n+\tmargin: 10px;\n+\tbackground-color: #ffffff;\n+\tcolor: #000000;\n+}\n+\n+a { \n+\tcolor: #0000cc;\n+}\n+\n+a:hover, a:visited, a:active {\n+\tcolor: #880000;\n+}\n+\n+div.page_header {\n+\theight: 25px;\n+\tpadding: 8px;\n+\tfont-size: 18px;\n+\tfont-weight: bold;\n+\tbackground-color: #d9d8d1;\n+}\n+\n+div.page_header a:visited, a.header {\n+\tcolor: #0000cc;\n+}\n+\n+div.page_header a:hover {\n+\tcolor: #880000;\n+}\n+\n+div.page_nav {\n+\tpadding:8px;\n+}\n+\n+div.page_nav a:visited {\n+\tcolor: #0000cc;\n+}\n+\n+div.page_path {\n+\tpadding: 8px;\n+\tborder: solid #d9d8d1;\n+\tborder-width: 0px 0px 1px;\n+}\n+\n+div.page_footer {\n+\theight: 17px;\n+\tpadding: 4px 8px;\n+\tbackground-color: #d9d8d1;\n+}\n+\n+div.page_footer_text {\n+\tfloat: left;\n+\tcolor: #555555;\n+\tfont-style: italic;\n+}\n+\n+div.page_body {\n+\tpadding: 8px;\n+}\n+\n div.title, a.title {\n-\tdisplay:block; padding:6px 8px;\n-\tfont-weight:bold; background-color:#edece6; text-decoration:none; color:#000000;\n+\tdisplay: block;\n+\tpadding: 6px 8px;\n+\tfont-weight: bold;\n+\tbackground-color: #edece6;\n+\ttext-decoration: none;\n+\tcolor: #000000;\n+}\n+\n+a.title:hover {\n+\tbackground-color: #d9d8d1;\n+}\n+\n+div.title_text {\n+\tpadding: 6px 0px;\n+\tborder: solid #d9d8d1;\n+\tborder-width: 0px 0px 1px;\n }\n-a.title:hover { background-color: #d9d8d1; }\n-div.title_text { padding:6px 0px; border: solid #d9d8d1; border-width:0px 0px 1px; }\n-div.log_body { padding:8px 8px 8px 150px; }\n-span.age { position:relative; float:left; width:142px; font-style:italic; }\n+\n+div.log_body {\n+\tpadding: 8px 8px 8px 150px;\n+}\n+\n+span.age {\n+\tposition: relative;\n+\tfloat: left;\n+\twidth: 142px;\n+\tfont-style:italic;\n+}\n+\n div.log_link {\n-\tpadding:0px 8px;\n-\tfont-size:10px; font-family:sans-serif; font-style:normal;\n-\tposition:relative; float:left; width:136px;\n-}\n-div.list_head { padding:6px 8px 4px; border:solid #d9d8d1; border-width:1px 0px 0px; font-style:italic; }\n-a.list { text-decoration:none; color:#000000; }\n-a.list:hover { text-decoration:underline; color:#880000; }\n-a.text { text-decoration:none; color:#0000cc; }\n-a.text:visited { text-decoration:none; color:#880000; }\n-a.text:hover { text-decoration:underline; color:#880000; }\n-table { padding:8px 4px; }\n-th { padding:2px 5px; font-size:12px; text-align:left; }\n-tr.light:hover { background-color:#edece6; }\n-tr.dark { background-color:#f6f6f0; }\n-tr.dark:hover { background-color:#edece6; }\n-td { padding:2px 5px; font-size:12px; vertical-align:top; }\n-td.link { padding:2px 5px; font-family:sans-serif; font-size:10px; }\n-div.pre { font-family:monospace; font-size:12px; white-space:pre; }\n-div.diff_info { font-family:monospace; color:#000099; background-color:#edece6; font-style:italic; }\n-div.index_include { border:solid #d9d8d1; border-width:0px 0px 1px; padding:12px 8px; }\n-div.search { margin:4px 8px; position:absolute; top:56px; right:12px }\n-a.linenr { color:#999999; text-decoration:none }\n+\tpadding: 0px 8px;\n+\tfont-size: 10px;\n+\tfont-family: sans-serif;\n+\tfont-style:normal;\n+\tposition: relative;\n+\tfloat: left;\n+\twidth: 136px;\n+}\n+\n+div.list_head {\n+\tpadding: 6px 8px 4px;\n+\tborder: solid #d9d8d1;\n+\tborder-width: 1px 0px 0px;\n+\tfont-style: italic;\n+}\n+\n+a.list {\n+\ttext-decoration: none;\n+\tcolor: #000000;\n+}\n+\n+a.list:hover {\n+\ttext-decoration: underline;\n+\tcolor: #880000;\n+}\n+\n+a.text {\n+\ttext-decoration: none;\n+\tcolor: #0000cc;\n+}\n+\n+a.text:visited {\n+\ttext-decoration: none;\n+\tcolor: #880000;\n+}\n+\n+a.text:hover {\n+\ttext-decoration: underline;\n+\tcolor: #880000;\n+}\n+\n+table {\n+\tpadding: 8px 4px;\n+}\n+\n+th {\n+\tpadding: 2px 5px;\n+\tfont-size: 12px;\n+\ttext-align: left;\n+}\n+\n+tr.light:hover {\n+\tbackground-color: #edece6;\n+}\n+\n+tr.dark {\n+\tbackground-color: #f6f6f0;\n+}\n+\n+tr.dark:hover {\n+\tbackground-color: #edece6;\n+}\n+\n+\n+td {\n+\tpadding: 2px 5px;\n+\tfont-size: 12px;\n+\tvertical-align:top;\n+}\n+\n+td.link {\n+\tpadding: 2px 5px;\n+\tfont-family: sans-serif;\n+\tfont-size: 10px;\n+}\n+\n+div.pre {\n+\tfont-family: monospace;\n+\tfont-size: 12px;\n+\twhite-space: pre;\n+\t/* padding-left: 5px; */\n+}\n+\n+div.diff_info {\n+\tfont-family: monospace;\n+\tcolor: #000099;\n+\tbackground-color: #edece6;\n+\tfont-style: italic;\n+}\n+\n+div.index_include {\n+\tborder: solid #d9d8d1;\n+\tborder-width: 0px 0px 1px;\n+\tpadding: 12px 8px;\n+}\n+\n+div.search {\n+\tmargin: 4px 8px;\n+\tposition: absolute;\n+\ttop: 56px;\n+\tright: 12px\n+}\n+\n+a.linenr {\n+\tcolor: #999999;\n+\ttext-decoration: none\n+}\n+\n a.rss_logo {\n-\tfloat:right; padding:3px 0px; width:35px; line-height:10px;\n-\tborder:1px solid; border-color:#fcc7a5 #7d3302 #3e1a01 #ff954e;\n-\tcolor:#ffffff; background-color:#ff6600;\n-\tfont-weight:bold; font-family:sans-serif; font-size:10px;\n-\ttext-align:center; text-decoration:none;\n+\tfloat: right;\n+\tpadding: 3px 0px;\n+\twidth: 35px;\n+\tline-height: 10px;\n+\tborder: 1px solid;\n+\tborder-color: #fcc7a5 #7d3302 #3e1a01 #ff954e;\n+\tcolor: #ffffff;\n+\tbackground-color: #ff6600;\n+\tfont-weight: bold;\n+\tfont-family: sans-serif;\n+\tfont-size: 10px;\n+\ttext-align: center;\n+\ttext-decoration: none;\n+}\n+\n+a.rss_logo:hover {\n+\tbackground-color: #ee5500;\n }\n-a.rss_logo:hover { background-color:#ee5500; }\n+\n span.tag {\n-\tpadding:0px 4px; font-size:10px; font-weight:normal;\n-\tbackground-color:#ffffaa; border:1px solid; border-color:#ffffcc #ffee00 #ffee00 #ffffcc;\n+\tpadding: 0px 4px;\n+\tfont-size: 10px;\n+\tfont-weight: normal;\n+\tbackground-color: #ffffaa;\n+\tborder: 1px solid;\n+\tborder-color: #ffffcc #ffee00 #ffee00 #ffffcc;\n }\n-- \n1.3.0\n"}]}