{"thread":{"id":"45559","subject":"Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries","startedAt":"2017-03-30T22:39:19Z","lastAt":"2017-03-31T00:39:31Z","messageCount":5,"participants":["Nate Mueller","Junio C Hamano","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"315843","messageId":"CAJF7t-dqSa7tmQqNEWmg_VZ=+832nsZ-3JmSGA03qK6aY5eNTQ@mail.gmail.com","threadId":"45559","inReplyTo":null,"subject":"Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries","fromName":"Nate Mueller","fromEmail":"nate@retailnext.net","sentAt":"2017-03-30T22:39:04Z","receivedAt":"2017-03-30T22:39:19Z","isPatch":false,"sender":{"key":"nate@retailnext.net","avatar":"https://gravatar.com/avatar/5699bf3a9811b46575539632ee333954e7135d3b9bdd50f483a4aed6db2c650e?d=mp&s=160"},"body":"I ran into this after upgrading to 2.11.0 through Xcode. I assumed it\nwas a packaging issue but it looks like it's been in the mainline\nsince 1073094f30 (on October 29).\n\nIn 2.11.0, git-sh-setup switched it's call of git-sh-i18n from:\n\n. git-sh-i18n\n\nto:\n\n. \"$(git --exec-path)/git-sh-i18n\"\n\nThis fails for me because my GIT_EXEC_PATH is set to\n\"/Library/Developer/CommandLineTools/usr/libexec/git-core:/Users/nate/.git-exec\".\nIf I remove the second entry git-sh-setup works just fine.\n\nAm I doing something wrong here? I can't see what but I'm surprised\nthat I'm the first person to hit this.\n\n\n\n-- \nNate Mueller - Head of Engineering - RetailNext - 406-356-6283\n"},{"id":"315845","messageId":"xmqqo9wi1ifw.fsf@gitster.mtv.corp.google.com","threadId":"45559","inReplyTo":"CAJF7t-dqSa7tmQqNEWmg_VZ=+832nsZ-3JmSGA03qK6aY5eNTQ@mail.gmail.com","subject":"Re: Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-03-30T22:57:39Z","receivedAt":"2017-03-30T22:58:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nate Mueller writes:\n\n> This fails for me because my GIT_EXEC_PATH is set to\n> \"/Library/Developer/CommandLineTools/usr/libexec/git-core:/Users/nate/.git-exec\".\n\nThat environment variable is designed to hold a single path, not\nlike $PATH that lists multiple places in a colon separated list.\n"},{"id":"315846","messageId":"CAJF7t-cAtR9yp2184pUsw+w3mf-SSMW4FUY27N8+f=6u7qjx3g@mail.gmail.com","threadId":"45559","inReplyTo":"xmqqo9wi1ifw.fsf@gitster.mtv.corp.google.com","subject":"Re: Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries","fromName":"Nate Mueller","fromEmail":"nate@retailnext.net","sentAt":"2017-03-30T23:00:41Z","receivedAt":"2017-03-30T23:00:47Z","isPatch":false,"sender":{"key":"nate@retailnext.net","avatar":"https://gravatar.com/avatar/5699bf3a9811b46575539632ee333954e7135d3b9bdd50f483a4aed6db2c650e?d=mp&s=160"},"body":"Really? My config has been set this way for years and it's never\ncaused problems before. I have subcommands in both of those\ndirectories and all work.\n\nOn Thu, Mar 30, 2017 at 3:57 PM, Junio C Hamano wrote:\n> Nate Mueller writes:\n>\n>> This fails for me because my GIT_EXEC_PATH is set to\n>> \"/Library/Developer/CommandLineTools/usr/libexec/git-core:/Users/nate/.git-exec\".\n>\n> That environment variable is designed to hold a single path, not\n> like $PATH that lists multiple places in a colon separated list.\n\n\n\n-- \nNate Mueller - Head of Engineering - RetailNext - 406-356-6283\n"},{"id":"315847","messageId":"20170330233228.dfv5mxnwlppghmua@sigill.intra.peff.net","threadId":"45559","inReplyTo":"CAJF7t-cAtR9yp2184pUsw+w3mf-SSMW4FUY27N8+f=6u7qjx3g@mail.gmail.com","subject":"Re: Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-03-30T23:32:28Z","receivedAt":"2017-03-30T23:33:25Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Mar 30, 2017 at 04:00:41PM -0700, Nate Mueller wrote:\n\n> Really? My config has been set this way for years and it's never\n> caused problems before. I have subcommands in both of those\n> directories and all work.\n\nReally. It did happen to work most of the time before (because most uses\ninvolved just appending it to $PATH). But it was never intended to work\nwith multiple paths. The:\n\n . \"$(git --exec-path)/git-sh-whatever\"\n\nadvice has been advertised in the documentation for years. E.g., see\nbd870878f (Documentation: don't assume git-sh-setup and git-parse-remote\nare in PATH, 2008-06-29). So even if we wanted to relax the rules in our\nscripts, it seems like a potential hazard for 3rd party scripts.\n\nThe recommended way is to just put your ~/.git-exec into your $PATH.\n\n-Peff\n"},{"id":"315848","messageId":"CAJF7t-cvCN1wMN1FzNPTG5zOC-d1g0GNxL-necZF7BOfUyrKog@mail.gmail.com","threadId":"45559","inReplyTo":"20170330233228.dfv5mxnwlppghmua@sigill.intra.peff.net","subject":"Re: Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries","fromName":"Nate Mueller","fromEmail":"nate@retailnext.net","sentAt":"2017-03-31T00:39:24Z","receivedAt":"2017-03-31T00:39:31Z","isPatch":false,"sender":{"key":"nate@retailnext.net","avatar":"https://gravatar.com/avatar/5699bf3a9811b46575539632ee333954e7135d3b9bdd50f483a4aed6db2c650e?d=mp&s=160"},"body":"Got it. Thanks!\n\nOn Thu, Mar 30, 2017 at 4:32 PM, Jeff King wrote:\n> On Thu, Mar 30, 2017 at 04:00:41PM -0700, Nate Mueller wrote:\n>\n>> Really? My config has been set this way for years and it's never\n>> caused problems before. I have subcommands in both of those\n>> directories and all work.\n>\n> Really. It did happen to work most of the time before (because most uses\n> involved just appending it to $PATH). But it was never intended to work\n> with multiple paths. The:\n>\n> . \"$(git --exec-path)/git-sh-whatever\"\n>\n> advice has been advertised in the documentation for years. E.g., see\n> bd870878f (Documentation: don't assume git-sh-setup and git-parse-remote\n> are in PATH, 2008-06-29). So even if we wanted to relax the rules in our\n> scripts, it seems like a potential hazard for 3rd party scripts.\n>\n> The recommended way is to just put your ~/.git-exec into your $PATH.\n>\n> -Peff\n\n\n\n-- \nNate Mueller - Head of Engineering - RetailNext - 406-356-6283\n"}]}