{"thread":{"id":"45550","subject":"ttk error when starting git gui","startedAt":"2017-03-30T17:17:03Z","lastAt":"2017-03-31T14:34:56Z","messageCount":12,"participants":["David Shrader","Peter van der Does","Dennis Kaarsemaker","Jessie Hernandez","Konstantin Khomoutov"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"315793","messageId":"0fc69c73-73aa-5355-264b-a7c55377eec2@lanl.gov","threadId":"45550","inReplyTo":null,"subject":"ttk error when starting git gui","fromName":"David Shrader","fromEmail":"dshrader@lanl.gov","sentAt":"2017-03-30T17:01:08Z","receivedAt":"2017-03-30T17:17:03Z","isPatch":false,"sender":{"key":"dshrader@lanl.gov","avatar":null},"body":"Hello,\n\nI get the following error when trying to start git gui:\n\nError in startup script: wrong # args: should be \"ttk::style theme use \ntheme\"\n     while executing\n\"ttk::style theme use\"\n     (procedure \"ttext\" line 4)\n     invoked from within\n\"ttext $ui_workdir -background white -foreground black \\\n         -borderwidth 0 \\\n         -width 20 -height 10 \\\n         -wrap none \\\n         -takefocus 1 -highlightthickness 1\\\n         ...\"\n     (file \n\"/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui\" \nline 3190)\n\nI get this error with the latest released version 2.12.2. Two older git \nversions are also available on this system, and neither has this issue. \nThose older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in \nthose corresponding git-gui executables, so that is probably why they work.\n\nHere are the steps to reproduce:\n\n1) cd to existing git repository\n2) run 'git gui' (no gui comes up, and the error is printed in the terminal)\n\nI'm running on a RHEL6 based system. Do I have an insufficient version \nof whatever git gui uses for graphics in the later versions of git? When \nI try 2.12.2 on my personal workstation running Fedora 25, I don't see \nthe same issue.\n\nThank you very much for your time,\nDavid\n\n-- \nDavid Shrader\nHPC-ENV High Performance Computer Systems\nLos Alamos National Lab\nEmail: dshrader <at> lanl.gov\n\n"},{"id":"315820","messageId":"4addfbdb-1289-7958-87e5-8d8caa9febfb@avirtualhome.com","threadId":"45550","inReplyTo":"0fc69c73-73aa-5355-264b-a7c55377eec2@lanl.gov","subject":"Re: ttk error when starting git gui","fromName":"Peter van der Does","fromEmail":"peter@avirtualhome.com","sentAt":"2017-03-30T19:54:50Z","receivedAt":"2017-03-30T20:15:18Z","isPatch":false,"sender":{"key":"peter@avirtualhome.com","avatar":"https://avatars.githubusercontent.com/u/380071?v=4"},"body":"On 3/30/17 1:01 PM, David Shrader wrote:\n> Hello,\n> \n> I get the following error when trying to start git gui:\n> \n> Error in startup script: wrong # args: should be \"ttk::style theme use\n> theme\"\n>     while executing\n> \"ttk::style theme use\"\n>     (procedure \"ttext\" line 4)\n>     invoked from within\n> \"ttext $ui_workdir -background white -foreground black \\\n>         -borderwidth 0 \\\n>         -width 20 -height 10 \\\n>         -wrap none \\\n>         -takefocus 1 -highlightthickness 1\\\n>         ...\"\n>     (file\n> \"/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui\"\n> line 3190)\n> \n> I get this error with the latest released version 2.12.2. Two older git\n> versions are also available on this system, and neither has this issue.\n> Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in\n> those corresponding git-gui executables, so that is probably why they work.\n> \n> Here are the steps to reproduce:\n> \n> 1) cd to existing git repository\n> 2) run 'git gui' (no gui comes up, and the error is printed in the\n> terminal)\n> \n> I'm running on a RHEL6 based system. Do I have an insufficient version\n> of whatever git gui uses for graphics in the later versions of git? When\n> I try 2.12.2 on my personal workstation running Fedora 25, I don't see\n> the same issue.\n> \n> Thank you very much for your time,\n> David\n> \n\n\nIt looks like the git gui needs TCL/TK 8.6.0 or higher. Since that\nversion the command 'ttk::style theme use' has been changed, which\nallows the command to be run without an argument and then returning the\ncurrent theme used.\nI believe RHEL6 use Tk-8.5.7 but I can't be 100% sure.\n\n-- \nPeter van der Does\n\nFacebook : https://www.facebook.com/petervanderdoes\nTwitter  : https://twitter.com/petervanderdoes\nGitHub   : https://github.com/petervanderdoes\nAbout Me : https://about.me/petervanderdoes\n"},{"id":"315827","messageId":"1490906641.2546.1.camel@kaarsemaker.net","threadId":"45550","inReplyTo":"4addfbdb-1289-7958-87e5-8d8caa9febfb@avirtualhome.com","subject":"Re: ttk error when starting git gui","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2017-03-30T20:44:01Z","receivedAt":"2017-03-30T20:44:09Z","isPatch":false,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"On Thu, 2017-03-30 at 15:54 -0400, Peter van der Does wrote:\n\n> It looks like the git gui needs TCL/TK 8.6.0 or higher. Since that\n> version the command 'ttk::style theme use' has been changed, which\n> allows the command to be run without an argument and then returning the\n> current theme used.\n> I believe RHEL6 use Tk-8.5.7 but I can't be 100% sure.\n\nIt does.\n\n$ rpm -q tk\ntk-8.5.7-5.el6.x86_64\n\nD.\n"},{"id":"315836","messageId":"c4e7185d-cef9-ce1b-a944-e92e0d17249c@lanl.gov","threadId":"45550","inReplyTo":"4addfbdb-1289-7958-87e5-8d8caa9febfb@avirtualhome.com","subject":"Re: ttk error when starting git gui","fromName":"David Shrader","fromEmail":"dshrader@lanl.gov","sentAt":"2017-03-30T21:33:51Z","receivedAt":"2017-03-30T21:34:06Z","isPatch":false,"sender":{"key":"dshrader@lanl.gov","avatar":null},"body":"\n\nOn 03/30/2017 01:54 PM, Peter van der Does wrote:\n> On 3/30/17 1:01 PM, David Shrader wrote:\n>> Hello,\n>>\n>> I get the following error when trying to start git gui:\n>>\n>> Error in startup script: wrong # args: should be \"ttk::style theme use\n>> theme\"\n>>      while executing\n>> \"ttk::style theme use\"\n>>      (procedure \"ttext\" line 4)\n>>      invoked from within\n>> \"ttext $ui_workdir -background white -foreground black \\\n>>          -borderwidth 0 \\\n>>          -width 20 -height 10 \\\n>>          -wrap none \\\n>>          -takefocus 1 -highlightthickness 1\\\n>>          ...\"\n>>      (file\n>> \"/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui\"\n>> line 3190)\n>>\n>> I get this error with the latest released version 2.12.2. Two older git\n>> versions are also available on this system, and neither has this issue.\n>> Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in\n>> those corresponding git-gui executables, so that is probably why they work.\n>>\n>> Here are the steps to reproduce:\n>>\n>> 1) cd to existing git repository\n>> 2) run 'git gui' (no gui comes up, and the error is printed in the\n>> terminal)\n>>\n>> I'm running on a RHEL6 based system. Do I have an insufficient version\n>> of whatever git gui uses for graphics in the later versions of git? When\n>> I try 2.12.2 on my personal workstation running Fedora 25, I don't see\n>> the same issue.\n>>\n>> Thank you very much for your time,\n>> David\n>>\n>\n> It looks like the git gui needs TCL/TK 8.6.0 or higher. Since that\n> version the command 'ttk::style theme use' has been changed, which\n> allows the command to be run without an argument and then returning the\n> current theme used.\n> I believe RHEL6 use Tk-8.5.7 but I can't be 100% sure.\n>\nYep, 8.5.7 is what I have on the RHEL6-based system. Thanks for the info!\nDavid\n\n-- \nDavid Shrader\nHPC-ENV High Performance Computer Systems\nLos Alamos National Lab\nEmail: dshrader <at> lanl.gov\n\n"},{"id":"315872","messageId":"916067befdc828e5d33dd3c1817989e7.squirrel@mail.jessiehernandez.com","threadId":"45550","inReplyTo":"0fc69c73-73aa-5355-264b-a7c55377eec2@lanl.gov","subject":"Re: ttk error when starting git gui","fromName":"Jessie Hernandez","fromEmail":"git@jessiehernandez.com","sentAt":"2017-03-31T06:44:27Z","receivedAt":"2017-03-31T07:02:28Z","isPatch":false,"sender":{"key":"git@jessiehernandez.com","avatar":null},"body":"> Hello,\n>\n> I get the following error when trying to start git gui:\n>\n> Error in startup script: wrong # args: should be \"ttk::style theme use\n> theme\"\n>      while executing\n> \"ttk::style theme use\"\n>      (procedure \"ttext\" line 4)\n>      invoked from within\n> \"ttext $ui_workdir -background white -foreground black \\\n>          -borderwidth 0 \\\n>          -width 20 -height 10 \\\n>          -wrap none \\\n>          -takefocus 1 -highlightthickness 1\\\n>          ...\"\n>      (file\n> \"/home/dshrader/opt/toss2/common/git/2.12.2/libexec/git-core/git-gui\"\n> line 3190)\n>\n> I get this error with the latest released version 2.12.2. Two older git\n> versions are also available on this system, and neither has this issue.\n> Those older versions are 1.7.1 and 2.3.3. I don't see a call to ttext in\n> those corresponding git-gui executables, so that is probably why they\n> work.\n>\n> Here are the steps to reproduce:\n>\n> 1) cd to existing git repository\n> 2) run 'git gui' (no gui comes up, and the error is printed in the\n> terminal)\n>\n> I'm running on a RHEL6 based system. Do I have an insufficient version\n> of whatever git gui uses for graphics in the later versions of git? When\n> I try 2.12.2 on my personal workstation running Fedora 25, I don't see\n> the same issue.\n>\n> Thank you very much for your time,\n> David\n\nHi David,\n\nI also got this problem when I wanted to build and run git 2.10.x.\nI have added the following change to git-gui/git-gui.sh\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 5bc21b878..5ce59ef94 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure font_ui]\n set default_config(gui.fontdiff) [font configure font_diff]\n # TODO: this option should be added to the git-config documentation\n set default_config(gui.maxfilesdisplayed) 5000\n-set default_config(gui.usettk) 1\n+set default_config(gui.usettk) 0\n set default_config(gui.warndetachedcommit) 1\n set default_config(gui.tabsize) 8\n set font_descs {\n\n\nIf you guys want I can submit it as a patch.\nBut i assume that 'fixing' this by disabling the feature is not really\nwhat we want.\n\n-----------------\nJessie Hernandez\n\n\n> --\n> David Shrader\n> HPC-ENV High Performance Computer Systems\n> Los Alamos National Lab\n> Email: dshrader <at> lanl.gov\n>\n>\n\n"},{"id":"315873","messageId":"20170331103330.5d7c414b6a0273cefb8508f2@domain007.com","threadId":"45550","inReplyTo":"916067befdc828e5d33dd3c1817989e7.squirrel@mail.jessiehernandez.com","subject":"Re: ttk error when starting git gui","fromName":"Konstantin Khomoutov","fromEmail":"kostix+git@007spb.ru","sentAt":"2017-03-31T07:33:30Z","receivedAt":"2017-03-31T07:33:46Z","isPatch":false,"sender":{"key":"kostix+git@007spb.ru","avatar":null},"body":"On Fri, 31 Mar 2017 08:44:27 +0200\n\"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n\n[...]\n> I also got this problem when I wanted to build and run git 2.10.x.\n> I have added the following change to git-gui/git-gui.sh\n> \n> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n> index 5bc21b878..5ce59ef94 100755\n> --- a/git-gui/git-gui.sh\n> +++ b/git-gui/git-gui.sh\n> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure\n> font_ui] set default_config(gui.fontdiff) [font configure font_diff]\n>  # TODO: this option should be added to the git-config documentation\n>  set default_config(gui.maxfilesdisplayed) 5000\n> -set default_config(gui.usettk) 1\n> +set default_config(gui.usettk) 0\n>  set default_config(gui.warndetachedcommit) 1\n>  set default_config(gui.tabsize) 8\n>  set font_descs {\n> \n> \n> If you guys want I can submit it as a patch.\n> But i assume that 'fixing' this by disabling the feature is not really\n> what we want.\n\nIt's possible to have ttk with 8.5 as well (say, here on Debian 8.5\nships with ttk enabled).\n\nA proper patch would be \n\n-set default_config(gui.usettk) 1\n+set default_config(gui.usettk) [namespace exists ::ttk]\n\nCould you please test it on your system?\n"},{"id":"315875","messageId":"ff7628d7c69ecd3d212b29fec33f6ba1.squirrel@mail.jessiehernandez.com","threadId":"45550","inReplyTo":"20170331103330.5d7c414b6a0273cefb8508f2@domain007.com","subject":"Re: ttk error when starting git gui","fromName":"Jessie Hernandez","fromEmail":"git@jessiehernandez.com","sentAt":"2017-03-31T07:45:03Z","receivedAt":"2017-03-31T07:45:43Z","isPatch":false,"sender":{"key":"git@jessiehernandez.com","avatar":null},"body":"> On Fri, 31 Mar 2017 08:44:27 +0200\n> \"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n>\n> [...]\n>> I also got this problem when I wanted to build and run git 2.10.x.\n>> I have added the following change to git-gui/git-gui.sh\n>>\n>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n>> index 5bc21b878..5ce59ef94 100755\n>> --- a/git-gui/git-gui.sh\n>> +++ b/git-gui/git-gui.sh\n>> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure\n>> font_ui] set default_config(gui.fontdiff) [font configure font_diff]\n>>  # TODO: this option should be added to the git-config documentation\n>>  set default_config(gui.maxfilesdisplayed) 5000\n>> -set default_config(gui.usettk) 1\n>> +set default_config(gui.usettk) 0\n>>  set default_config(gui.warndetachedcommit) 1\n>>  set default_config(gui.tabsize) 8\n>>  set font_descs {\n>>\n>>\n>> If you guys want I can submit it as a patch.\n>> But i assume that 'fixing' this by disabling the feature is not really\n>> what we want.\n>\n> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5\n> ships with ttk enabled).\n>\n> A proper patch would be\n>\n> -set default_config(gui.usettk) 1\n> +set default_config(gui.usettk) [namespace exists ::ttk]\n>\n> Could you please test it on your system?\n>\n\nYeah that seems to work.\nThanks for this.\n\nI have tried it with git 2.12.2\n\nJessie Hernandez\n\n\n\n"},{"id":"315876","messageId":"7447cca107bbc922877f8b80e9f3d934.squirrel@mail.jessiehernandez.com","threadId":"45550","inReplyTo":"ff7628d7c69ecd3d212b29fec33f6ba1.squirrel@mail.jessiehernandez.com","subject":"Re: ttk error when starting git gui","fromName":"Jessie Hernandez","fromEmail":"git@jessiehernandez.com","sentAt":"2017-03-31T07:53:38Z","receivedAt":"2017-03-31T07:54:16Z","isPatch":false,"sender":{"key":"git@jessiehernandez.com","avatar":null},"body":">> On Fri, 31 Mar 2017 08:44:27 +0200\n>> \"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n>>\n>> [...]\n>>> I also got this problem when I wanted to build and run git 2.10.x.\n>>> I have added the following change to git-gui/git-gui.sh\n>>>\n>>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n>>> index 5bc21b878..5ce59ef94 100755\n>>> --- a/git-gui/git-gui.sh\n>>> +++ b/git-gui/git-gui.sh\n>>> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure\n>>> font_ui] set default_config(gui.fontdiff) [font configure font_diff]\n>>>  # TODO: this option should be added to the git-config documentation\n>>>  set default_config(gui.maxfilesdisplayed) 5000\n>>> -set default_config(gui.usettk) 1\n>>> +set default_config(gui.usettk) 0\n>>>  set default_config(gui.warndetachedcommit) 1\n>>>  set default_config(gui.tabsize) 8\n>>>  set font_descs {\n>>>\n>>>\n>>> If you guys want I can submit it as a patch.\n>>> But i assume that 'fixing' this by disabling the feature is not really\n>>> what we want.\n>>\n>> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5\n>> ships with ttk enabled).\n>>\n>> A proper patch would be\n>>\n>> -set default_config(gui.usettk) 1\n>> +set default_config(gui.usettk) [namespace exists ::ttk]\n>>\n>> Could you please test it on your system?\n>>\n>\n> Yeah that seems to work.\n> Thanks for this.\n>\n> I have tried it with git 2.12.2\n>\n> Jessie Hernandez\n>\nHi Konstantin,\n\nI spoke to soon. :(\nIt does not work. I forgot to do a install when testing.\nSorry for the confusion.\n\n\n"},{"id":"315877","messageId":"20170331105614.15746aadd7c3a51e1fda65b3@domain007.com","threadId":"45550","inReplyTo":"ff7628d7c69ecd3d212b29fec33f6ba1.squirrel@mail.jessiehernandez.com","subject":"Re: ttk error when starting git gui","fromName":"Konstantin Khomoutov","fromEmail":"kostix+git@007spb.ru","sentAt":"2017-03-31T07:56:14Z","receivedAt":"2017-03-31T07:56:24Z","isPatch":false,"sender":{"key":"kostix+git@007spb.ru","avatar":null},"body":"On Fri, 31 Mar 2017 09:45:03 +0200\n\"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n\n> >> I also got this problem when I wanted to build and run git 2.10.x.\n> >> I have added the following change to git-gui/git-gui.sh\n> >>\n> >> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n> >> index 5bc21b878..5ce59ef94 100755\n> >> --- a/git-gui/git-gui.sh\n> >> +++ b/git-gui/git-gui.sh\n> >> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure\n> >> font_ui] set default_config(gui.fontdiff) [font configure\n> >> font_diff]\n> >>  # TODO: this option should be added to the git-config\n> >>  # documentation\n> >>  set default_config(gui.maxfilesdisplayed) 5000\n> >> -set default_config(gui.usettk) 1\n> >> +set default_config(gui.usettk) 0\n> >>  set default_config(gui.warndetachedcommit) 1\n> >>  set default_config(gui.tabsize) 8\n> >>  set font_descs {\n> >>\n> >> If you guys want I can submit it as a patch.\n> >> But i assume that 'fixing' this by disabling the feature is not\n> >> really what we want.\n> >\n> > It's possible to have ttk with 8.5 as well (say, here on Debian 8.5\n> > ships with ttk enabled).\n> >\n> > A proper patch would be\n> >\n> > -set default_config(gui.usettk) 1\n> > +set default_config(gui.usettk) [namespace exists ::ttk]\n> >\n> > Could you please test it on your system?\n> >\n> \n> Yeah that seems to work.\n> Thanks for this.\n> \n> I have tried it with git 2.12.2\n\nPlease consider re-posting this as a proper patch, then. ;-)\n"},{"id":"315878","messageId":"20170331105803.814cef2ce06b9171901206f4@domain007.com","threadId":"45550","inReplyTo":"7447cca107bbc922877f8b80e9f3d934.squirrel@mail.jessiehernandez.com","subject":"Re: ttk error when starting git gui","fromName":"Konstantin Khomoutov","fromEmail":"kostix+git@007spb.ru","sentAt":"2017-03-31T07:58:03Z","receivedAt":"2017-03-31T07:58:15Z","isPatch":false,"sender":{"key":"kostix+git@007spb.ru","avatar":null},"body":"On Fri, 31 Mar 2017 09:53:38 +0200\n\"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n\n[...]\n> >> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5\n> >> ships with ttk enabled).\n> >>\n> >> A proper patch would be\n> >>\n> >> -set default_config(gui.usettk) 1\n> >> +set default_config(gui.usettk) [namespace exists ::ttk]\n> >>\n> >> Could you please test it on your system?\n> >>\n> >\n> > Yeah that seems to work.\n> > Thanks for this.\n> >\n> > I have tried it with git 2.12.2\n[...]\n> I spoke to soon. :(\n> It does not work. I forgot to do a install when testing.\n> Sorry for the confusion.\n\nCare to elaborate on the exact error, please?\n"},{"id":"315879","messageId":"2db3bf6de4e169f0c116ba77b74998b4.squirrel@mail.jessiehernandez.com","threadId":"45550","inReplyTo":"20170331105803.814cef2ce06b9171901206f4@domain007.com","subject":"Re: ttk error when starting git gui","fromName":"Jessie Hernandez","fromEmail":"git@jessiehernandez.com","sentAt":"2017-03-31T11:29:04Z","receivedAt":"2017-03-31T11:29:37Z","isPatch":false,"sender":{"key":"git@jessiehernandez.com","avatar":null},"body":"> On Fri, 31 Mar 2017 09:53:38 +0200\n> \"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n>\n> [...]\n>> >> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5\n>> >> ships with ttk enabled).\n>> >>\n>> >> A proper patch would be\n>> >>\n>> >> -set default_config(gui.usettk) 1\n>> >> +set default_config(gui.usettk) [namespace exists ::ttk]\n>> >>\n>> >> Could you please test it on your system?\n>> >>\n>> >\n>> > Yeah that seems to work.\n>> > Thanks for this.\n>> >\n>> > I have tried it with git 2.12.2\n> [...]\n>> I spoke to soon. :(\n>> It does not work. I forgot to do a install when testing.\n>> Sorry for the confusion.\n>\n> Care to elaborate on the exact error, please?\n>\n\nThe error I get is the following\n\nError in startup script: wrong # args: should be \"ttk::style theme use theme\"\n    while executing\n\"ttk::style theme use\"\n    (procedure \"ttext\" line 4)\n    invoked from within\n\"ttext $ui_workdir -background white -foreground black \\\n\t-borderwidth 0 \\\n\t-width 20 -height 10 \\\n\t-wrap none \\\n\t-takefocus 1 -highlightthickness 1\\\n\t...\"\n    (file \"/usr/libexec/git-core/git-gui\" line 3190)\n\n\n\n"},{"id":"315915","messageId":"20170331173435.c822389c9fc7ebe15c20ed00@domain007.com","threadId":"45550","inReplyTo":"2db3bf6de4e169f0c116ba77b74998b4.squirrel@mail.jessiehernandez.com","subject":"Re: ttk error when starting git gui","fromName":"Konstantin Khomoutov","fromEmail":"kostix+git@007spb.ru","sentAt":"2017-03-31T14:34:35Z","receivedAt":"2017-03-31T14:34:56Z","isPatch":false,"sender":{"key":"kostix+git@007spb.ru","avatar":null},"body":"On Fri, 31 Mar 2017 13:29:04 +0200\n\"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n\n> > On Fri, 31 Mar 2017 09:53:38 +0200\n> > \"Jessie Hernandez\" <git@jessiehernandez.com> wrote:\n> >\n> > [...]\n> >> >> It's possible to have ttk with 8.5 as well (say, here on Debian\n> >> >> 8.5 ships with ttk enabled).\n> >> >>\n> >> >> A proper patch would be\n> >> >>\n> >> >> -set default_config(gui.usettk) 1\n> >> >> +set default_config(gui.usettk) [namespace exists ::ttk]\n> >> >>\n> >> >> Could you please test it on your system?\n> >> >>\n> >> >\n> >> > Yeah that seems to work.\n> >> > Thanks for this.\n> >> >\n> >> > I have tried it with git 2.12.2\n> > [...]\n> >> I spoke to soon. :(\n> >> It does not work. I forgot to do a install when testing.\n> >> Sorry for the confusion.\n> >\n> > Care to elaborate on the exact error, please?\n> >\n> \n> The error I get is the following\n> \n> Error in startup script: wrong # args: should be \"ttk::style theme\n> use theme\" while executing\n> \"ttk::style theme use\"\n>     (procedure \"ttext\" line 4)\n>     invoked from within\n> \"ttext $ui_workdir -background white -foreground black \\\n> \t-borderwidth 0 \\\n> \t-width 20 -height 10 \\\n> \t-wrap none \\\n> \t-takefocus 1 -highlightthickness 1\\\n> \t...\"\n>     (file \"/usr/libexec/git-core/git-gui\" line 3190)\n\nToo bad: the git-gui relies on the [ttk::style theme use] command --\nthat is, the two-argument invocation of [ttk::style] -- to return\nthe theme being currently in use, and this feature was implemented\non 2008-05-27 [1] by Pat Thoyts.\n\nJudging from the output of\n\n  fossil descendants e83b7dd29ddae998f96538584afb518849ac1e2c\n\nthe first Tk release to have this change was 8.6b2.\n\nSo the proper fix appears to be more involved:\n\n set default_config(gui.usettk) \\\n   [expr {[package vcompare [info patchlevel] 8.6b2] >= 0}]\n\n(The slash+newline sequence is not needed -- it's here mostly\nfor pretty-printing.)\n\n1. http://core.tcl.tk/tk/info/e83b7dd29ddae998\n"}]}