{"thread":{"id":"45431","subject":"[PATCH 1/2] refs: remove unused head_ref_submodule() implementation","startedAt":"2017-03-19T20:24:17Z","lastAt":"2017-03-19T20:24:17Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"314600","messageId":"a3c6fa20-7077-cd27-88da-fec4ded8bb30@ramsayjones.plus.com","threadId":"45431","inReplyTo":null,"subject":"[PATCH 1/2] refs: remove unused head_ref_submodule() implementation","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-03-19T20:23:56Z","receivedAt":"2017-03-19T20:24:17Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\ncommit 990eaca068 (\"refs: remove dead for_each_*_submodule()\",\n18-03-2017) removed the public declaration of head_ref_submodule(), but\nforgot to remove the definition.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Duy,\n\nIf you need to re-roll your 'nd/prune-in-worktree' branch, could you please\nsquash this into the relevant patch.\n\nAlso, I note that this patch does not update the technical documentation to\nremove references to these api functions. (see Documentation/technical/\\\napi-ref-iteration.txt).\n\nThanks!\n\nATB,\nRamsay Jones\n\n refs.c | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/refs.c b/refs.c\nindex 6006d4fdb..e80425379 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -1208,11 +1208,6 @@ int refs_head_ref(struct ref_store *refs, each_ref_fn fn, void *cb_data)\n \treturn 0;\n }\n \n-int head_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)\n-{\n-\treturn refs_head_ref(get_submodule_ref_store(submodule), fn, cb_data);\n-}\n-\n int head_ref(each_ref_fn fn, void *cb_data)\n {\n \treturn refs_head_ref(get_main_ref_store(), fn, cb_data);\n-- \n2.12.0\n"}]}