{"thread":{"id":"45402","subject":"[PATCH] wt-status.c: improve readability for wt_shortstatus_print","startedAt":"2017-03-16T21:36:41Z","lastAt":"2017-03-17T05:26:27Z","messageCount":3,"participants":["Stefan Beller","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"314259","messageId":"20170316213619.30678-1-sbeller@google.com","threadId":"45402","inReplyTo":null,"subject":"[PATCH] wt-status.c: improve readability for wt_shortstatus_print","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-03-16T21:36:19Z","receivedAt":"2017-03-16T21:36:41Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Signed-off-by: Stefan Beller <sbeller@google.com>\n---\n wt-status.c | 20 +++++---------------\n 1 file changed, 5 insertions(+), 15 deletions(-)\n\ndiff --git a/wt-status.c b/wt-status.c\nindex d47012048f..a52d342695 100644\n--- a/wt-status.c\n+++ b/wt-status.c\n@@ -1785,34 +1785,24 @@ static void wt_shortstatus_print_tracking(struct wt_status *s)\n \n static void wt_shortstatus_print(struct wt_status *s)\n {\n-\tint i;\n+\tstruct string_list_item *it;\n \n \tif (s->show_branch)\n \t\twt_shortstatus_print_tracking(s);\n \n-\tfor (i = 0; i < s->change.nr; i++) {\n-\t\tstruct wt_status_change_data *d;\n-\t\tstruct string_list_item *it;\n+\tfor_each_string_list_item(it, &s->change) {\n+\t\tstruct wt_status_change_data *d = it->util;\n \n-\t\tit = &(s->change.items[i]);\n-\t\td = it->util;\n \t\tif (d->stagemask)\n \t\t\twt_shortstatus_unmerged(it, s);\n \t\telse\n \t\t\twt_shortstatus_status(it, s);\n \t}\n-\tfor (i = 0; i < s->untracked.nr; i++) {\n-\t\tstruct string_list_item *it;\n-\n-\t\tit = &(s->untracked.items[i]);\n+\tfor_each_string_list_item(it, &s->untracked)\n \t\twt_shortstatus_other(it, s, \"??\");\n-\t}\n-\tfor (i = 0; i < s->ignored.nr; i++) {\n-\t\tstruct string_list_item *it;\n \n-\t\tit = &(s->ignored.items[i]);\n+\tfor_each_string_list_item(it, &s->ignored)\n \t\twt_shortstatus_other(it, s, \"!!\");\n-\t}\n }\n \n static void wt_porcelain_print(struct wt_status *s)\n-- \n2.12.0.269.g1a05a5734c.dirty\n\n"},{"id":"314285","messageId":"20170316225108.GB9135@aiede.mtv.corp.google.com","threadId":"45402","inReplyTo":"20170316213619.30678-1-sbeller@google.com","subject":"Re: [PATCH] wt-status.c: improve readability for wt_shortstatus_print","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-03-16T22:51:08Z","receivedAt":"2017-03-16T22:51:44Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Stefan Beller wrote:\n\n> Subject: wt-status.c: improve readability for wt_shortstatus_print\n\nMaybe:\n\n\twt-status: simplify by using for_each_string_list_item\n\n\tImprove readability by using the for_each_string_list_item helper\n\tinstead of manually iterating with an integer counter.\n\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n>  wt-status.c | 20 +++++---------------\n>  1 file changed, 5 insertions(+), 15 deletions(-)\n\nI like the diffstat. :)\n\nWith or without a clarified commit message,\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"},{"id":"314306","messageId":"xmqqd1dga30a.fsf@gitster.mtv.corp.google.com","threadId":"45402","inReplyTo":"20170316225108.GB9135@aiede.mtv.corp.google.com","subject":"Re: [PATCH] wt-status.c: improve readability for wt_shortstatus_print","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-03-17T05:25:25Z","receivedAt":"2017-03-17T05:26:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Stefan Beller wrote:\n>\n>> Subject: wt-status.c: improve readability for wt_shortstatus_print\n>\n> Maybe:\n>\n> \twt-status: simplify by using for_each_string_list_item\n>\n> \tImprove readability by using the for_each_string_list_item helper\n> \tinstead of manually iterating with an integer counter.\n\nMuch better.  That matches what I read from the patch when I skimmed\nit, but it did leave me wondering if I missed something else.\n\n>> Signed-off-by: Stefan Beller <sbeller@google.com>\n>> ---\n>>  wt-status.c | 20 +++++---------------\n>>  1 file changed, 5 insertions(+), 15 deletions(-)\n>\n> I like the diffstat. :)\n\nMe too ;-)\n\n>\n> With or without a clarified commit message,\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"}]}