{"thread":{"id":"45392","subject":"[PATCH] submodule.c: fix an 'using integer as NULL pointer' warning","startedAt":"2017-03-16T01:05:35Z","lastAt":"2017-03-16T04:49:16Z","messageCount":2,"participants":["Ramsay Jones","Brandon Williams"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"314202","messageId":"2134ffee-f144-1fb3-7e0e-325fd2873ba9@ramsayjones.plus.com","threadId":"45392","inReplyTo":null,"subject":"[PATCH] submodule.c: fix an 'using integer as NULL pointer' warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-03-16T01:02:01Z","receivedAt":"2017-03-16T01:05:35Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Brandon,\n\nIf you need to re-roll your 'bw/submodule-is-active' branch, could\nyou please squash this into the relevant patch (commit 20d59ab335,\n\"submodule: decouple url and submodule existence\", 13-03-2017).\n\nThanks!\n\nATB,\nRamsay Jones\n\n submodule.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/submodule.c b/submodule.c\nindex 800283154..a77d11cc4 100644\n--- a/submodule.c\n+++ b/submodule.c\n@@ -245,7 +245,7 @@ int is_submodule_initialized(const char *path)\n \t\t\targv_array_push(&args, item->string);\n \t\t}\n \n-\t\tparse_pathspec(&ps, 0, 0, 0, args.argv);\n+\t\tparse_pathspec(&ps, 0, 0, NULL, args.argv);\n \t\tret = match_pathspec(&ps, path, strlen(path), 0, NULL, 1);\n \n \t\targv_array_clear(&args);\n-- \n2.12.0\n"},{"id":"314205","messageId":"20170316044907.GI159137@google.com","threadId":"45392","inReplyTo":"2134ffee-f144-1fb3-7e0e-325fd2873ba9@ramsayjones.plus.com","subject":"Re: [PATCH] submodule.c: fix an 'using integer as NULL pointer' warning","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-03-16T04:49:07Z","receivedAt":"2017-03-16T04:49:16Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 03/16, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Brandon,\n> \n> If you need to re-roll your 'bw/submodule-is-active' branch, could\n> you please squash this into the relevant patch (commit 20d59ab335,\n> \"submodule: decouple url and submodule existence\", 13-03-2017).\n\nThanks for catching this, I've squashed it into my local branch and I'm\nplanning on sending out a reroll in a day or so.\n\n> \n> Thanks!\n> \n> ATB,\n> Ramsay Jones\n> \n>  submodule.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/submodule.c b/submodule.c\n> index 800283154..a77d11cc4 100644\n> --- a/submodule.c\n> +++ b/submodule.c\n> @@ -245,7 +245,7 @@ int is_submodule_initialized(const char *path)\n>  \t\t\targv_array_push(&args, item->string);\n>  \t\t}\n>  \n> -\t\tparse_pathspec(&ps, 0, 0, 0, args.argv);\n> +\t\tparse_pathspec(&ps, 0, 0, NULL, args.argv);\n>  \t\tret = match_pathspec(&ps, path, strlen(path), 0, NULL, 1);\n>  \n>  \t\targv_array_clear(&args);\n> -- \n> 2.12.0\n\n-- \nBrandon Williams\n"}]}