{"thread":{"id":"4536","subject":"git-1.4.0 make problems","startedAt":"2006-06-17T02:18:00Z","lastAt":"2006-06-17T22:40:05Z","messageCount":5,"participants":["Michael Somos","Rene Scharfe","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"21932","messageId":"200606170218.k5H2I0o0003192@grail.cba.csuohio.edu","threadId":"4536","inReplyTo":null,"subject":"git-1.4.0 make problems","fromName":"Michael Somos","fromEmail":"somos@grail.cba.csuohio.edu","sentAt":"2006-06-17T02:18:00Z","receivedAt":"2006-06-17T02:18:00Z","isPatch":false,"sender":{"key":"somos@grail.cba.csuohio.edu","avatar":null},"body":"I downloaded the git-1.4.0.tar.bz2 recently and encountered a few problems.\n\n1) The untar process creates a stray file \"pax_global_header\".\nI am using GNU tar v1.13.22 and I get this message :\n\n======================================================================\n> tar jxf ~/u/source/git-1.4.0.tar.bz2\ntar: pax_global_header: Unknown file type 'g', extracted as normal file\n======================================================================\n\n2) The make install process ignores the \"prefix=...\" argument. I have\nto comment out one line for this :\n\n======================================================================\n> diff Makefile git-1.4.0/\n94c94 \n< #prefix = $(HOME)\n---\n> prefix = $(HOME)\n======================================================================\n\n3) The make has a problem with \"expat\" include and libararies.\nI have to add more lines to the Makefile to handle this like some\nof the other include and libraries :\n\n======================================================================\n351,358c351\n< endif\n<\n< ifndef NO_EXPAT\n<       ifdef EXPATDIR\n<               # This is still problematic -- gcc does not always want -R.\n<               ALL_CFLAGS += -I$(EXPATDIR)/include\n<               EXPAT_LIBEXPAT = -L$(EXPATDIR)/lib -R$(EXPATDIR)/lib -lexpat\n<           else\n---\n>       ifndef NO_EXPAT\n360c353\n<           endif\n---\n>       endif\n======================================================================\n\nOther than that, it installed okay. I will have to read the docs and\nuse it to see how it goes otherwise.\n"},{"id":"21945","messageId":"4493A810.6010706@lsrfire.ath.cx","threadId":"4536","inReplyTo":"200606170218.k5H2I0o0003192@grail.cba.csuohio.edu","subject":"Re: git-1.4.0 make problems","fromName":"Rene Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-06-17T06:58:24Z","receivedAt":"2006-06-17T06:58:24Z","isPatch":false,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"| I downloaded the git-1.4.0.tar.bz2 recently and encountered a few\n| problems.\n|\n| 1) The untar process creates a stray file \"pax_global_header\".\n| I am using GNU tar v1.13.22 and I get this message :\n|\n| ======================================================================\n| > tar jxf ~/u/source/git-1.4.0.tar.bz2\n| tar: pax_global_header: Unknown file type 'g', extracted as normal\n| file\n| ======================================================================\n\nYou can ignore or delete that file.  It is a pax extended global header,\ncontaining the git commit ID as a comment.  GNU tar started supporting\npax headers with version 1.13.93 (released 2004-02-23).  Version 1.13.22\nwas released on 2001-08-29, by the way.  May I ask what operating system\nand version you are using?\n\n| 2) The make install process ignores the \"prefix=...\" argument. I have\n| to comment out one line for this :\n|\n| ======================================================================\n| > diff Makefile git-1.4.0/\n| 94c94\n| < #prefix = $(HOME)\n| ---\n| > prefix = $(HOME)\n| ======================================================================\n\nIt took me a while to realize that your diffs are reversed.  It's too\nearly for me, I think I'll go to bed again. :)\n\nAnyway, prefix handling is currently being worked on.  Yakov Lerner sent\na patch which seems to make make do what you need.\n\n| 3) The make has a problem with \"expat\" include and libararies.\n| I have to add more lines to the Makefile to handle this like some\n| of the other include and libraries :\n|\n| ======================================================================\n| 351,358c351\n| < endif\n| <\n| < ifndef NO_EXPAT\n| <       ifdef EXPATDIR\n| <               # This is still problematic -- gcc does not always want -R.\n| <               ALL_CFLAGS += -I$(EXPATDIR)/include\n| <               EXPAT_LIBEXPAT = -L$(EXPATDIR)/lib -R$(EXPATDIR)/lib -lexpat\n|\n| <           else\n| ---\n| >       ifndef NO_EXPAT\n| 360c353\n| <           endif\n| ---\n| >       endif\n| ======================================================================\n\nLooks sensible, except for the formatting.\n\n| Other than that, it installed okay. I will have to read the docs and\n| use it to see how it goes otherwise.\n\nA good first exercise would be to fetch the git repository, edit Makefile\nand commit your change, and then send a patch to this list -- all using\ngit (except the editing part). :-)  Care to try that?  Please let us know\nof any difficulties you may encounter.\n\nThanks,\nRené\n"},{"id":"21966","messageId":"7vbqsra4d2.fsf@assigned-by-dhcp.cox.net","threadId":"4536","inReplyTo":"4493A810.6010706@lsrfire.ath.cx","subject":"Re: git-1.4.0 make problems","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-17T20:56:09Z","receivedAt":"2006-06-17T20:56:09Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:\n\n> | 1) The untar process creates a stray file \"pax_global_header\".\n> | I am using GNU tar v1.13.22 and I get this message :\n> |\n> | ======================================================================\n> | > tar jxf ~/u/source/git-1.4.0.tar.bz2\n> | tar: pax_global_header: Unknown file type 'g', extracted as normal\n> | file\n> | ======================================================================\n>\n> You can ignore or delete that file.  It is a pax extended global header,\n> containing the git commit ID as a comment.  GNU tar started supporting\n> pax headers with version 1.13.93 (released 2004-02-23).  Version 1.13.22\n> was released on 2001-08-29, by the way.  May I ask what operating system\n> and version you are using?\n\nI've been using (in my non-git related project aka day-job)\n\n  git-tar-tree HEAD^{tree} $(PROJECT)-$(RELNAME) >$(PROJECT)-$(RELNAME).tar \n\nto avoid this.  Although all of my target machines have gtar\nthat are recent enough so I do not need it, but when the tarball\nhas version string in its name, there is not much point having\nthe pax header to identify the contents (where the pax header\nshines is when the result does not have the version string in\nits name).\n\nThis might be a sensible thing to do for our dist target as\nwell.  The product of our dist target is for people who build\nfrom the source to bootstrap themselves (if they have git, then\nfetching the source using git is preferred anyway), as opposed\nto using pre-built binaries, so being as friendly as we can to\ndifferent implementations of tar is a good thing.\n"},{"id":"21973","messageId":"44947A43.7070909@lsrfire.ath.cx","threadId":"4536","inReplyTo":"7vbqsra4d2.fsf@assigned-by-dhcp.cox.net","subject":"Re: git-1.4.0 make problems","fromName":"Rene Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-06-17T21:55:15Z","receivedAt":"2006-06-17T21:55:15Z","isPatch":false,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Junio C Hamano schrieb:\n> I've been using (in my non-git related project aka day-job)\n> \n> git-tar-tree HEAD^{tree} $(PROJECT)-$(RELNAME) >$(PROJECT)-$(RELNAME).tar\n> \n> to avoid this.  Although all of my target machines have gtar that are\n> recent enough so I do not need it, but when the tarball has version\n> string in its name, there is not much point having the pax header to\n> identify the contents (where the pax header shines is when the result\n> does not have the version string in its name).\n> \n> This might be a sensible thing to do for our dist target as well.\n> The product of our dist target is for people who build from the\n> source to bootstrap themselves (if they have git, then fetching the\n> source using git is preferred anyway), as opposed to using pre-built\n> binaries, so being as friendly as we can to different implementations\n> of tar is a good thing.\n\nHrm.  Is the header really that unfriendly?  With a non-POSIX tar you\nget an extra file and a nice, if somewhat cryptic, reminder to upgrade\nyour archiver. ;-)  Seriously, this is way below my annoyance-radar,\nbut I'm obviously biased.\n\nWhat do you think about the following patch for starters?  It adds an\nexample to the git-tar-tree documentation showing your \"tree trick\"\nand corrects two formatting buglets.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n\ndiff --git a/Documentation/git-tar-tree.txt b/Documentation/git-tar-tree.txt\nindex 831537b..c93a8fe 100644\n--- a/Documentation/git-tar-tree.txt\n+++ b/Documentation/git-tar-tree.txt\n@@ -45,11 +45,16 @@ git tar-tree HEAD | (cd /var/tmp/ && mkd\n \tlatest commit on the current branch, and extracts it in\n \t`/var/tmp/junk` directory.\n \n-git tar-tree v2.6.17 linux-2.6.17 | gzip >linux-2.6.17.tar.gz\n+git tar-tree v2.6.17 linux-2.6.17 | gzip >linux-2.6.17.tar.gz::\n \n \tCreate a tarball for v2.6.17 release.\n \n-git tar-tree --remote=example.com:git.git v0.99 >git-0.99.tar\n+git tar-tree v2.6.17{caret}\\{tree\\} linux-2.6.17 | gzip >linux-2.6.17.tar.gz::\n+\n+\tCreate a tarball for v2.6.17 release, but without a\n+\tglobal extended pax header.\n+\n+git tar-tree --remote=example.com:git.git v0.99 >git-0.99.tar::\n \n \tGet a tarball v0.99 from example.com.\n \n"},{"id":"21977","messageId":"7vac8b76ey.fsf@assigned-by-dhcp.cox.net","threadId":"4536","inReplyTo":"44947A43.7070909@lsrfire.ath.cx","subject":"Re: git-1.4.0 make problems","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-17T22:40:05Z","receivedAt":"2006-06-17T22:40:05Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:\n\n> Hrm.  Is the header really that unfriendly?  With a non-POSIX tar you\n> get an extra file and a nice, if somewhat cryptic, reminder to upgrade\n> your archiver. ;-)  Seriously, this is way below my annoyance-radar,\n> but I'm obviously biased.\n\nI do not mind tar-tree producing the header by default and\nhaving to override it with ^{tree} -- actually I think it is a\ngood default.  I think that particular use in our Makefile,\nhowever, is not necessary.\n\n> What do you think about the following patch for starters?\n\nDocumentation updates are always welcome, and I think this is a\ngood change.  Thanks.\n"}]}