{"thread":{"id":"45289","subject":"[PATCH] http: release strbuf on disabled alternates","startedAt":"2017-03-04T02:26:30Z","lastAt":"2017-03-04T03:50:49Z","messageCount":2,"participants":["Eric Wong","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"313255","messageId":"20170304015016.GA25408@starla","threadId":"45289","inReplyTo":null,"subject":"[PATCH] http: release strbuf on disabled alternates","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2017-03-04T01:50:16Z","receivedAt":"2017-03-04T02:26:30Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"This likely has no real-world impact on memory usage,\nbut it is cleaner for future readers.\n\nFixes: abcbdc03895f (\"http: respect protocol.*.allow=user for http-alternates\")\nSigned-off-by: Eric Wong <e@80x24.org>\n---\n http-walker.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/http-walker.c b/http-walker.c\nindex b34b6ace7c..2c85316112 100644\n--- a/http-walker.c\n+++ b/http-walker.c\n@@ -314,6 +314,8 @@ static void process_alternates_response(void *callback_data)\n \t\t\t\t\twhile (tail->next != NULL)\n \t\t\t\t\t\ttail = tail->next;\n \t\t\t\t\ttail->next = newalt;\n+\t\t\t\t} else {\n+\t\t\t\t\tstrbuf_release(&target);\n \t\t\t\t}\n \t\t\t}\n \t\t}\n-- \nEW\n"},{"id":"313258","messageId":"20170304034226.uz5pzu5nl2zmisjt@sigill.intra.peff.net","threadId":"45289","inReplyTo":"20170304015016.GA25408@starla","subject":"Re: [PATCH] http: release strbuf on disabled alternates","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-03-04T03:42:27Z","receivedAt":"2017-03-04T03:50:49Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Mar 04, 2017 at 01:50:16AM +0000, Eric Wong wrote:\n\n> This likely has no real-world impact on memory usage,\n> but it is cleaner for future readers.\n\nYep, this looks good.\n\n-Peff\n"}]}