{"thread":{"id":"45257","subject":"[PATCH v2 2/2] gitweb tests: Skip tests when we don't have Time::HiRes","startedAt":"2017-03-01T22:14:27Z","lastAt":"2017-03-01T23:12:10Z","messageCount":4,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"312988","messageId":"20170301211540.4382-3-avarab@gmail.com","threadId":"45257","inReplyTo":"20170301211540.4382-1-avarab@gmail.com","subject":"[PATCH v2 2/2] gitweb tests: Skip tests when we don't have Time::HiRes","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-03-01T21:15:40Z","receivedAt":"2017-03-01T22:14:27Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the gitweb tests to skip when we can't load the Time::HiRes\nmodule.\n\nGitweb needs this module to work. It has been in perl core since v5.8,\nwhich is the oldest version we support. However CentOS (and perhaps\nsome other distributions) carve it into its own non-core-perl package\nthat's not installed along with /usr/bin/perl by default. Without this\nwe'll hard fail the gitweb tests when trying to load the module.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/gitweb-lib.sh | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh\nindex 59ef15efbd..b7a73874e7 100644\n--- a/t/gitweb-lib.sh\n+++ b/t/gitweb-lib.sh\n@@ -114,4 +114,9 @@ perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {\n \ttest_done\n }\n \n+perl -mTime::HiRes -e 0  >/dev/null 2>&1 || {\n+\tskip_all='skipping gitweb tests, Time::HiRes module not available'\n+\ttest_done\n+}\n+\n gitweb_init\n-- \n2.11.0\n\n"},{"id":"312993","messageId":"20170301211540.4382-2-avarab@gmail.com","threadId":"45257","inReplyTo":"20170301211540.4382-1-avarab@gmail.com","subject":"[PATCH v2 1/2] gitweb tests: Change confusing \"skip_all\" phrasing","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-03-01T21:15:39Z","receivedAt":"2017-03-01T22:57:04Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the phrasing so that instead of saying that the CGI module is\nunusable, we say that it's not available.\n\nThis came up on the git mailing list in\n<4b34e3a0-3da7-d821-2a7f-9a420ac1d3f6@gmail.com> from Jakub Narębski.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/gitweb-lib.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh\nindex d5dab5a94f..59ef15efbd 100644\n--- a/t/gitweb-lib.sh\n+++ b/t/gitweb-lib.sh\n@@ -110,7 +110,7 @@ perl -MEncode -e '$e=\"\";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {\n }\n \n perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {\n-\tskip_all='skipping gitweb tests, CGI module unusable'\n+\tskip_all='skipping gitweb tests, CGI & CGI::Util & CGI::Carp modules not available'\n \ttest_done\n }\n \n-- \n2.11.0\n\n"},{"id":"312994","messageId":"xmqqy3woei11.fsf@gitster.mtv.corp.google.com","threadId":"45257","inReplyTo":"20170301211540.4382-1-avarab@gmail.com","subject":"Re: [PATCH v2 0/2] Minor changes to skip gitweb tests without Time::HiRes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-03-01T22:42:02Z","receivedAt":"2017-03-01T22:58:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, will replace what has been on 'pu'.\n\nNote that I'd dropped a double-SP from the latter one while queuing.\n"},{"id":"313000","messageId":"20170301211540.4382-1-avarab@gmail.com","threadId":"45257","inReplyTo":"4b34e3a0-3da7-d821-2a7f-9a420ac1d3f6@gmail.com","subject":"[PATCH v2 0/2] Minor changes to skip gitweb tests without Time::HiRes","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-03-01T21:15:38Z","receivedAt":"2017-03-01T23:12:10Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This was originally just one small patch, but Jakub Narębski pointed\nout that calling the module \"unusable\" when we failed to load it was\nconfusing, so now the start of this series is just a rephrasing of an\nexisting error message I copied.\n\nÆvar Arnfjörð Bjarmason (2):\n  gitweb tests: Change confusing \"skip_all\" phrasing\n  gitweb tests: Skip tests when we don't have Time::HiRes\n\n t/gitweb-lib.sh | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)\n\n-- \n2.11.0\n\n"}]}