{"thread":{"id":"45197","subject":"git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)","startedAt":"2017-02-23T06:05:08Z","lastAt":"2017-02-24T19:02:59Z","messageCount":5,"participants":["Greg KH","Jeff King","Simon Sandström","Geert Uytterhoeven"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"312371","messageId":"20170223060444.GA26196@kroah.com","threadId":"45197","inReplyTo":"CA+55aFy1JpXmo_PpC7f0zZa0YAP6rz+bztJ+fpDUoWgCz0_FMw@mail.gmail.com","subject":"git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)","fromName":"Greg KH","fromEmail":"gregkh@linuxfoundation.org","sentAt":"2017-02-23T06:04:44Z","receivedAt":"2017-02-23T06:05:08Z","isPatch":false,"sender":{"key":"gregkh@linuxfoundation.org","avatar":"https://gravatar.com/avatar/e6d9136f6e3bdcb59f0e5fd15565f382da42523d273824958b9e23e73cf38e04?d=mp&s=160"},"body":"On Wed, Feb 22, 2017 at 11:59:01AM -0800, Linus Torvalds wrote:\n> On Wed, Feb 22, 2017 at 6:56 AM, Greg KH wrote:\n> >\n> > =?UTF-8?q?Simon=20Sandstr=C3=B6m?= (1):\n> > staging: vt6656: Add missing identifier names\n> \n> Wow, your scripts really screwed up that name.\n> \n> I'm assuming this is quilt not doing proper character set handling..\n> \n> Because if it's git, we need to get that fixed (but I'm pretty sure\n> git gets this right - there are various tests for email header\n> quoting).\n> \n> Alternatively, somebody hand-edited some email and moved the From:\n> header to the body without fixing up the RFC 1342 mail header quoting\n> (which is very different from how quoting works in the *body* of an\n> email).\n> \n> Poor Simon Sandström.\n> \n> Funnily enough, this only exists for one commit. You've got several\n> other commits from Simon that get his name right.\n> \n> What happened?\n\nI don't know what happened, I used git for this, I don't use quilt for\n\"normal\" patches accepted into my trees anymore, only for stable kernel\nwork.\n\nSo either the mail is malformed, or git couldn't figure it out, I've\nattached the original message below, and cc:ed the git mailing list.\n\nAlso, Simon emailed me after this was committed saying something went\nwrong, but I couldn't go back and rebase my tree. Simon, did you ever\nfigure out if something was odd on your end?\n\nGit developers, any ideas?\n\nthanks,\n\ngreg k-h\n"},{"id":"312372","messageId":"20170223061702.bzzgrntotppvwdw6@sigill.intra.peff.net","threadId":"45197","inReplyTo":"20170223060444.GA26196@kroah.com","subject":"Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-02-23T06:17:02Z","receivedAt":"2017-02-23T06:18:06Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote:\n\n> > Poor Simon Sandström.\n> > \n> > Funnily enough, this only exists for one commit. You've got several\n> > other commits from Simon that get his name right.\n> > \n> > What happened?\n> \n> I don't know what happened, I used git for this, I don't use quilt for\n> \"normal\" patches accepted into my trees anymore, only for stable kernel\n> work.\n> \n> So either the mail is malformed, or git couldn't figure it out, I've\n> attached the original message below, and cc:ed the git mailing list.\n> \n> Also, Simon emailed me after this was committed saying something went\n> wrong, but I couldn't go back and rebase my tree. Simon, did you ever\n> figure out if something was odd on your end?\n> \n> Git developers, any ideas?\n\nThe problem isn't on the applying end, but rather on the generating end.\nThe From header in the attached mbox is:\n\n From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= \n\nIf you de-base64 that, you get:\n\n =?UTF-8?q?Simon=20Sandstr=C3=B6m?=\n\nSo something double-encoded it before it got to your mbox.\n\n-Peff\n"},{"id":"312376","messageId":"20170223075859.g6ert55bvbe44dxc@localhost","threadId":"45197","inReplyTo":"20170223061702.bzzgrntotppvwdw6@sigill.intra.peff.net","subject":"Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)","fromName":"Simon Sandström","fromEmail":"simon@nikanor.nu","sentAt":"2017-02-23T07:59:23Z","receivedAt":"2017-02-23T07:59:44Z","isPatch":false,"sender":{"key":"simon@nikanor.nu","avatar":null},"body":"On Thu, Feb 23, 2017 at 01:17:02AM -0500, Jeff King wrote:\n> On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote:\n> \n> > \n> > I don't know what happened, I used git for this, I don't use quilt for\n> > \"normal\" patches accepted into my trees anymore, only for stable kernel\n> > work.\n> > \n> > So either the mail is malformed, or git couldn't figure it out, I've\n> > attached the original message below, and cc:ed the git mailing list.\n> > \n> > Also, Simon emailed me after this was committed saying something went\n> > wrong, but I couldn't go back and rebase my tree. Simon, did you ever\n> > figure out if something was odd on your end?\n> > \n> > Git developers, any ideas?\n> \n> The problem isn't on the applying end, but rather on the generating end.\n> The From header in the attached mbox is:\n> \n> From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= \n> \n> If you de-base64 that, you get:\n> \n> =?UTF-8?q?Simon=20Sandstr=C3=B6m?=\n> \n> So something double-encoded it before it got to your mbox.\n> \n> -Peff\n\nHi,\n\nYes, Mutt on my end caused this. I used Mutt 1.5.23, and I either had\nit misconfigured or it simply can't handle files that contains encoded\nFrom:/Subject:-fields when you run it with mutt -H .\n\nI upgraded to Mutt 1.7.1 which solved the problem.\n\n- Simon\n"},{"id":"312509","messageId":"CAMuHMdX+xGUD+K16VCE=ywRgN1Zd4MzSr=NJ=2xz+8e_ixyGKQ@mail.gmail.com","threadId":"45197","inReplyTo":"20170223061702.bzzgrntotppvwdw6@sigill.intra.peff.net","subject":"Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)","fromName":"Geert Uytterhoeven","fromEmail":"geert@linux-m68k.org","sentAt":"2017-02-24T11:03:45Z","receivedAt":"2017-02-24T11:04:45Z","isPatch":false,"sender":{"key":"geert@linux-m68k.org","avatar":"https://gravatar.com/avatar/8105b34f653a7b5b98e225e565b11ebcc762ad4ab1a9d905a4663db029a9e6bc?d=mp&s=160"},"body":"On Thu, Feb 23, 2017 at 7:17 AM, Jeff King wrote:\n> On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote:\n>> > Poor Simon Sandström.\n>> >\n>> > Funnily enough, this only exists for one commit. You've got several\n>> > other commits from Simon that get his name right.\n>> >\n>> > What happened?\n>>\n>> I don't know what happened, I used git for this, I don't use quilt for\n>> \"normal\" patches accepted into my trees anymore, only for stable kernel\n>> work.\n>>\n>> So either the mail is malformed, or git couldn't figure it out, I've\n>> attached the original message below, and cc:ed the git mailing list.\n>>\n>> Also, Simon emailed me after this was committed saying something went\n>> wrong, but I couldn't go back and rebase my tree. Simon, did you ever\n>> figure out if something was odd on your end?\n>>\n>> Git developers, any ideas?\n>\n> The problem isn't on the applying end, but rather on the generating end.\n> The From header in the attached mbox is:\n>\n> From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= \n\nSlightly related, once in a while I get funny emails through\ngit-commits-head@vger.kernel.org, where the subject is completely screwed up:\n\n Subject: \\x64\\x72\\x6D\\x2F\\x74\\x69\\x6E\\x79\\x64\\x72\\x6D\\x3A\n\\x6D\\x69\\x70\\x69\\x2D\\x64\\x62\\x69\\x3A \\x53\\x69\\x6C\\x65\\x6E\\x63\\x65\\x3A\n‘\\x63\\x6D\\x64’ \\x6D\\x61\\x79 \\x62\\x65\n\nand some of the mail headers end up in the body as well:\n\n =?UTF-8?Q?\\x75\\x73\\x65\\x64_\\x75\\x6E\\x69\\x6E\\x69\\x74\\x69\\x61\\x6C\\x69\\x7A\\x65\\x64?=\n Return-Path: \"Linux Kernel Mailing List\" \n MIME-Version: 1.0\n Content-Type: text/plain; charset=UTF-8\n Content-Transfer-Encoding: 8bit\n X-Git-Commit: b401f34314db7c60e6d23ee7771cd090b4ef56c1\n X-Git-Parent: 1e8ad3d8da4763b238d09244d4d1177aa640c0d3\n X-Git-Refname: refs/heads/master\n\n Web:\nhttps://git.kernel.org/torvalds/c/b401f34314db7c60e6d23ee7771cd090b4ef56c1\n Commit: b401f34314db7c60e6d23ee7771cd090b4ef56c1\n Parent: 1e8ad3d8da4763b238d09244d4d1177aa640c0d3\n Refname: refs/heads/master\n Author: Noralf Trønnes \n AuthorDate: Thu Feb 23 14:29:55 2017 +0100\n Committer: Dave Airlie \n CommitDate: Fri Feb 24 12:08:58 2017 +1000\n\n drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized\n\nMy first guess was Noralf's UTF8 last name, but after looking at a few more,\nthey all seem to have UTF8 quotes from gcc output in the oneline summary.\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds\n"},{"id":"312534","messageId":"20170224185600.ftfts6y2au3tvzge@sigill.intra.peff.net","threadId":"45197","inReplyTo":"CAMuHMdX+xGUD+K16VCE=ywRgN1Zd4MzSr=NJ=2xz+8e_ixyGKQ@mail.gmail.com","subject":"Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-02-24T18:56:00Z","receivedAt":"2017-02-24T19:02:59Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Feb 24, 2017 at 12:03:45PM +0100, Geert Uytterhoeven wrote:\n\n> > The problem isn't on the applying end, but rather on the generating end.\n> > The From header in the attached mbox is:\n> >\n> > From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= \n> \n> Slightly related, once in a while I get funny emails through\n> git-commits-head@vger.kernel.org, where the subject is completely screwed up:\n> \n> Subject: \\x64\\x72\\x6D\\x2F\\x74\\x69\\x6E\\x79\\x64\\x72\\x6D\\x3A\n> \\x6D\\x69\\x70\\x69\\x2D\\x64\\x62\\x69\\x3A \\x53\\x69\\x6C\\x65\\x6E\\x63\\x65\\x3A\n> ‘\\x63\\x6D\\x64’ \\x6D\\x61\\x79 \\x62\\x65\n\nSorry, I don't have a clue on that one.\n\nIf you have UTF-8 or other non-ASCII characters in your subject,\nformat-patch will correctly do the rfc2047 encoding (and it should\nalways use QP). And that would kick in here because of the UTF-8 quotes.\n\nBut that weird \"\\x\" encoding is not in any mail standard I know of (and\ncertainly Git would never do it).\n\nThe odd thing is that the quotes themselves _aren't_ encoded. Just\neverything else.\n\nOne other feature is that subject line is long enough (especially\nQP-encoded) that it spans two lines:\n\n $ git format-patch --stdout -1 b401f34314d | grep -A1 ^Subject\n Subject: [PATCH] =?UTF-8?q?drm/tinydrm:=20mipi-dbi:=20Silence:=20=E2=80=98?=\n =?UTF-8?q?cmd=E2=80=99=20may=20be=20used=20uninitialized?=\n\nIt's possible that something along the way is mis-handling subjects with\nline-continuation (though why it would escape those characters, I don't\nknow).\n\n> and some of the mail headers end up in the body as well:\n> \n> =?UTF-8?Q?\\x75\\x73\\x65\\x64_\\x75\\x6E\\x69\\x6E\\x69\\x74\\x69\\x61\\x6C\\x69\\x7A\\x65\\x64?=\n\nThat might be related to the whitespace continuation (the first line\nafter the break is the second line of the subject).\n\n-Peff\n"}]}