{"thread":{"id":"45121","subject":"[git-gui] Amending doesn't preserve timestamp","startedAt":"2017-02-12T20:56:57Z","lastAt":"2017-03-24T10:25:24Z","messageCount":7,"participants":["Juraj","Igor Djordjevic BugA","Juraj Oršulić","Igor Djordjevic"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"311370","messageId":"CAEPqvoxM9_Ku-1YgwNiqearUBaaYbAJcehuSwZYNNfJLQNH1_g@mail.gmail.com","threadId":"45121","inReplyTo":null,"subject":"[git-gui] Amending doesn't preserve timestamp","fromName":"Juraj","fromEmail":"juraj.orsulic@fer.hr","sentAt":"2017-02-12T20:50:41Z","receivedAt":"2017-02-12T20:56:57Z","isPatch":false,"sender":{"key":"juraj.orsulic@fer.hr","avatar":"https://gravatar.com/avatar/1539f078c7cc6d853a33423b8059ece7a9b3b9c2c9eeb2269e7a8be647328ab1?d=mp&s=160"},"body":"I've just noticed that amending a commit from git-gui uses the time of\namending as the new timestamp of the commit, whereas git commit\n--amend preserves the original timestamp. Maybe the two should work\nthe same, whatever it is decided to be the standard behavior.\n\nJuraj\n"},{"id":"311372","messageId":"e8f63afd-18c5-0605-32f3-72a9c5650f84@gmail.com","threadId":"45121","inReplyTo":"CAEPqvoxM9_Ku-1YgwNiqearUBaaYbAJcehuSwZYNNfJLQNH1_g@mail.gmail.com","subject":"Re: [git-gui] Amending doesn't preserve timestamp","fromName":"Igor Djordjevic BugA","fromEmail":"igor.d.djordjevic@gmail.com","sentAt":"2017-02-12T21:33:09Z","receivedAt":"2017-02-12T21:33:23Z","isPatch":false,"sender":{"key":"igor.d.djordjevic@gmail.com","avatar":null},"body":"On 12/02/2017 21:50, Juraj wrote:\n> I've just noticed that amending a commit from git-gui uses the time of\n> amending as the new timestamp of the commit, whereas git commit\n> --amend preserves the original timestamp. Maybe the two should work\n> the same, whatever it is decided to be the standard behavior.\n> \n> Juraj\n> \n\nHi Juraj,\n\nJust to report that it seems to work as expected on my end...? Amending\nthrough both command line and git-gui preserves author date and updates\ncommiter date.\n\ngit version 2.11.1.windows.1\ngit-gui version 0.21.GITGUI\nTcl/Tk version 8.6.6\n\nRegards, BugA\n"},{"id":"311373","messageId":"CAEPqvozCvFqOTNPw0c1ErKoOd+Mn1WCyJr9hj6CXiWWtL93Tqw@mail.gmail.com","threadId":"45121","inReplyTo":"8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr","subject":"Re: [git-gui] Amending doesn't preserve timestamp","fromName":"Juraj","fromEmail":"juraj.orsulic@fer.hr","sentAt":"2017-02-12T21:40:56Z","receivedAt":"2017-02-12T21:41:45Z","isPatch":false,"sender":{"key":"juraj.orsulic@fer.hr","avatar":"https://gravatar.com/avatar/1539f078c7cc6d853a33423b8059ece7a9b3b9c2c9eeb2269e7a8be647328ab1?d=mp&s=160"},"body":"Hi Igor,\n\nI forgot to write the version I'm using. It's on Ubuntu 16.04, git-gui\npackage version 1:2.7.4-0ubuntu1 (--version: git-gui version 0.20.0),\ngit version 2.7.4, tcl and tk 8.6.0+9. Perhaps it got fixed in a newer\nversion, in that case, my bad for not checking before posting.\n\nThanks,\nJuraj\n"},{"id":"311384","messageId":"3e6e8f1f-a35c-45ee-e1a4-83e89ac3c1ec@gmail.com","threadId":"45121","inReplyTo":"CAEPqvozCvFqOTNPw0c1ErKoOd+Mn1WCyJr9hj6CXiWWtL93Tqw@mail.gmail.com","subject":"Re: [git-gui] Amending doesn't preserve timestamp","fromName":"Igor Djordjevic BugA","fromEmail":"igor.d.djordjevic@gmail.com","sentAt":"2017-02-12T23:06:19Z","receivedAt":"2017-02-12T23:06:30Z","isPatch":false,"sender":{"key":"igor.d.djordjevic@gmail.com","avatar":null},"body":"On 12/02/2017 22:40, Juraj wrote:\n> Hi Igor,\n> \n> I forgot to write the version I'm using. It's on Ubuntu 16.04, git-gui\n> package version 1:2.7.4-0ubuntu1 (--version: git-gui version 0.20.0),\n> git version 2.7.4, tcl and tk 8.6.0+9. Perhaps it got fixed in a newer\n> version, in that case, my bad for not checking before posting.\n> \n> Thanks,\n> Juraj\n\nHi Juraj,\n\nIndeed, if I`m reading it correctly, it seems to be addressed in git-gui\nversion 0.21.0[1], introduced in git version 2.11.0[2] on 2016-11-29\n(\"git-gui: Do not reset author details on amend\", 2016-04-11[3],\nreferencing an old bug report[4]).\n\nRegards,\nBugA\n\n[1] https://public-inbox.org/git/878ttji701.fsf@red.patthoyts.tk/\n[2]\nhttps://public-inbox.org/git/xmqqmvgidlsg.fsf@gitster.mtv.corp.google.com/\n[3]\nhttps://public-inbox.org/git/1462458182-4488-1-git-send-email-orgads@gmail.com/\n[4]\nhttps://public-inbox.org/git/CAGHpTB+35j0njmCZ0uCgBVroe=Ma7HLnn6fDty8yebKWgEmECg@mail.gmail.com/\n"},{"id":"315073","messageId":"CAEPqvoz8s=CVLABuXx-zOzryrXwr_cb39G2TYJvvFXRYzpCBFQ@mail.gmail.com","threadId":"45121","inReplyTo":"70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr","subject":"Re: [git-gui] Amending doesn't preserve timestamp","fromName":"Juraj Oršulić","fromEmail":"juraj.orsulic@fer.hr","sentAt":"2017-03-23T14:26:34Z","receivedAt":"2017-03-23T14:37:33Z","isPatch":false,"sender":{"key":"juraj.orsulic@fer.hr","avatar":"https://gravatar.com/avatar/1539f078c7cc6d853a33423b8059ece7a9b3b9c2c9eeb2269e7a8be647328ab1?d=mp&s=160"},"body":"Hello Igor (and others), I have something else to report about the\ncommit amend functionality in git-gui, and I think it could be\nrelated to my original question. It seems that git-gui messes up\ninternational signs on amending.\n\nE.g. I use git gui to make a commit, and all is OK:\n\ncommit ef24b133dda6c18b8ef01b1a38f9e049d87f2021\nAuthor: Juraj Oršulić \n\nI open git gui again, click \"Amend Last Commit\", press \"Commit\", and I\nget this in git log:\n\ncommit 6e09ff9edcef863d92f02cf86e0307c27171aec0\nAuthor: Juraj OrÅ¡uliÄ \n\n\nDoes anyone have any idea what could be the cause?\n\nI tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on\nhttp://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72.\n\n\nThanks,\nJuraj\n"},{"id":"315210","messageId":"851ca2c5-2224-2463-2b50-781861c95683@gmail.com","threadId":"45121","inReplyTo":"CAEPqvoz8s=CVLABuXx-zOzryrXwr_cb39G2TYJvvFXRYzpCBFQ@mail.gmail.com","subject":"Re: [git-gui] Amending doesn't preserve timestamp","fromName":"Igor Djordjevic","fromEmail":"igor.d.djordjevic@gmail.com","sentAt":"2017-03-23T22:54:42Z","receivedAt":"2017-03-23T22:54:51Z","isPatch":false,"sender":{"key":"igor.d.djordjevic@gmail.com","avatar":null},"body":"Hi Juraj,\n\nOn 23/03/2017 15:26, Juraj Oršulić wrote:\n> Hello Igor (and others), I have something else to report about the\n> commit amend functionality in git-gui, and I think it could be\n> related to my original question. It seems that git-gui messes up\n> international signs on amending.\n> \n> E.g. I use git gui to make a commit, and all is OK:\n> \n> commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021\n> Author: Juraj Oršulić \n> \n> I open git gui again, click \"Amend Last Commit\", press \"Commit\", and I\n> get this in git log:\n> \n> commit 6e09ff9edcef863d92f02cf86e0307c27171aec0\n> Author: Juraj OrÅ¡uliÄ \n> \n> \n> Does anyone have any idea what could be the cause?\n> \n> I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on\n> http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72.\n\nYes, I can confirm this.\n\ngit version 2.12.1.windows.1\ngit-gui version 0.21.GITGUI\nTcl/Tk version 8.6.6\n\nThat said, it seems there are quite some topics about it, like [1], \n[2], [3] and [4], but the most interesting one could be [5], having \nsome kind of a \"workaround\" at the end as well.\n\nI`ve tried replacing the \"commit.tcl\" file as proposed, and it seems \nto work correctly -- just please do note that it actually reverts the \nfile in question to an older version, maybe (re)introducing other \nbugs while fixing this specific one, so it could be something you may \nwant to investigate into a bit more before actually using it for good.\n\nP.S. It might be a good idea to start a new topic in situations like \nthis (send out a new e-mail instead of a reply), keeping unrelated \ndiscussions separated and helping interested parties spotting the new \ntopic more easily.\n\nRegards,\nBuga\n\n[1] https://public-inbox.org/git/588ac268-0a1b-6787-e6a1-4164e7e9a784@b-i-t.de/T/#ea05ebbde162f9c230a2cc4f7099363aed68768f6\n[2] https://public-inbox.org/git/52E1627956F20E458D872C5961027EDC654FE17C@SGDS00759.zf-lenksysteme.net/T/#m0baea8c76e79f25bf92ca0deabe38efec2ee168d\n[3] https://public-inbox.org/git/50913C58.2000200@drmicha.warpmail.net/T/#m72664106ad3070235ea2628b61fc6203fbb5563e\n[4] https://public-inbox.org/git/20071212091744.GA5377@pvv.org/T/#m8490dd348389b4eea82eb1bdaab69227c946de19\n[5] https://github.com/git-for-windows/git/issues/761\n"},{"id":"315231","messageId":"CAEPqvow38g-X0nCLwMsMW4T+uu0ouDUQNmOGZp6BG0yjwR6pTQ@mail.gmail.com","threadId":"45121","inReplyTo":"42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr","subject":"Re: [git-gui] Amending doesn't preserve timestamp","fromName":"Juraj Oršulić","fromEmail":"juraj.orsulic@fer.hr","sentAt":"2017-03-24T10:23:16Z","receivedAt":"2017-03-24T10:25:24Z","isPatch":false,"sender":{"key":"juraj.orsulic@fer.hr","avatar":"https://gravatar.com/avatar/1539f078c7cc6d853a33423b8059ece7a9b3b9c2c9eeb2269e7a8be647328ab1?d=mp&s=160"},"body":"Hi Igor! Thanks on for thoroughly searching the mailing list and on\nyour suggestions. I hope that someone will come up with a fix that\nboth preserves the author details and date correctly.\n\nRegards,\nJuraj\n\n\nOn Thu, Mar 23, 2017 at 11:54 PM, Igor Djordjevic\n wrote:\n> Hi Juraj,\n>\n> On 23/03/2017 15:26, Juraj Oršulić wrote:\n>> Hello Igor (and others), I have something else to report about the\n>> commit amend functionality in git-gui, and I think it could be\n>> related to my original question. It seems that git-gui messes up\n>> international signs on amending.\n>>\n>> E.g. I use git gui to make a commit, and all is OK:\n>>\n>> commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021\n>> Author: Juraj Oršulić \n>>\n>> I open git gui again, click \"Amend Last Commit\", press \"Commit\", and I\n>> get this in git log:\n>>\n>> commit 6e09ff9edcef863d92f02cf86e0307c27171aec0\n>> Author: Juraj OrÅ¡uliÄ \n>>\n>>\n>> Does anyone have any idea what could be the cause?\n>>\n>> I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on\n>> http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72.\n>\n> Yes, I can confirm this.\n>\n> git version 2.12.1.windows.1\n> git-gui version 0.21.GITGUI\n> Tcl/Tk version 8.6.6\n>\n> That said, it seems there are quite some topics about it, like [1],\n> [2], [3] and [4], but the most interesting one could be [5], having\n> some kind of a \"workaround\" at the end as well.\n>\n> I`ve tried replacing the \"commit.tcl\" file as proposed, and it seems\n> to work correctly -- just please do note that it actually reverts the\n> file in question to an older version, maybe (re)introducing other\n> bugs while fixing this specific one, so it could be something you may\n> want to investigate into a bit more before actually using it for good.\n>\n> P.S. It might be a good idea to start a new topic in situations like\n> this (send out a new e-mail instead of a reply), keeping unrelated\n> discussions separated and helping interested parties spotting the new\n> topic more easily.\n>\n> Regards,\n> Buga\n>\n> [1] https://public-inbox.org/git/588ac268-0a1b-6787-e6a1-4164e7e9a784@b-i-t.de/T/#ea05ebbde162f9c230a2cc4f7099363aed68768f6\n> [2] https://public-inbox.org/git/52E1627956F20E458D872C5961027EDC654FE17C@SGDS00759.zf-lenksysteme.net/T/#m0baea8c76e79f25bf92ca0deabe38efec2ee168d\n> [3] https://public-inbox.org/git/50913C58.2000200@drmicha.warpmail.net/T/#m72664106ad3070235ea2628b61fc6203fbb5563e\n> [4] https://public-inbox.org/git/20071212091744.GA5377@pvv.org/T/#m8490dd348389b4eea82eb1bdaab69227c946de19\n> [5] https://github.com/git-for-windows/git/issues/761\n"}]}