{"thread":{"id":"45082","subject":"[PATCH] refs-internal.c: make files_log_ref_write() static","startedAt":"2017-02-08T09:47:20Z","lastAt":"2017-02-08T22:08:02Z","messageCount":2,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"311046","messageId":"20170208094558.23712-1-pclouds@gmail.com","threadId":"45082","inReplyTo":null,"subject":"[PATCH] refs-internal.c: make files_log_ref_write() static","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2017-02-08T09:45:58Z","receivedAt":"2017-02-08T09:47:20Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"Created in 5f3c3a4e6f (files_log_ref_write: new function - 2015-11-10)\nbut probably never used outside refs-internal.c\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n refs/files-backend.c | 3 +++\n refs/refs-internal.h | 4 ----\n 2 files changed, 3 insertions(+), 4 deletions(-)\n\ndiff --git a/refs/files-backend.c b/refs/files-backend.c\nindex c041d4ba21..6a0bf94bf1 100644\n--- a/refs/files-backend.c\n+++ b/refs/files-backend.c\n@@ -165,6 +165,9 @@ static struct ref_entry *create_dir_entry(struct files_ref_store *ref_store,\n \t\t\t\t\t  const char *dirname, size_t len,\n \t\t\t\t\t  int incomplete);\n static void add_entry_to_dir(struct ref_dir *dir, struct ref_entry *entry);\n+static int files_log_ref_write(const char *refname, const unsigned char *old_sha1,\n+\t\t\t       const unsigned char *new_sha1, const char *msg,\n+\t\t\t       int flags, struct strbuf *err);\n \n static struct ref_dir *get_ref_dir(struct ref_entry *entry)\n {\ndiff --git a/refs/refs-internal.h b/refs/refs-internal.h\nindex 25444cf5b0..4c9215d33f 100644\n--- a/refs/refs-internal.h\n+++ b/refs/refs-internal.h\n@@ -220,10 +220,6 @@ struct ref_transaction {\n \tenum ref_transaction_state state;\n };\n \n-int files_log_ref_write(const char *refname, const unsigned char *old_sha1,\n-\t\t\tconst unsigned char *new_sha1, const char *msg,\n-\t\t\tint flags, struct strbuf *err);\n-\n /*\n  * Check for entries in extras that are within the specified\n  * directory, where dirname is a reference directory name including\n-- \n2.11.0.157.gd943d85\n\n"},{"id":"311106","messageId":"xmqqfujouylb.fsf@gitster.mtv.corp.google.com","threadId":"45082","inReplyTo":"20170208094558.23712-1-pclouds@gmail.com","subject":"Re: [PATCH] refs-internal.c: make files_log_ref_write() static","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-02-08T22:06:24Z","receivedAt":"2017-02-08T22:08:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n> Created in 5f3c3a4e6f (files_log_ref_write: new function - 2015-11-10)\n> but probably never used outside refs-internal.c\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n> ---\n\nIt's been more than a year, so let's declare that when somebody\nneeds it it can easily be turned into extern again and take this\npatch.\n\nThanks.\n\n>  refs/files-backend.c | 3 +++\n>  refs/refs-internal.h | 4 ----\n>  2 files changed, 3 insertions(+), 4 deletions(-)\n>\n> diff --git a/refs/files-backend.c b/refs/files-backend.c\n> index c041d4ba21..6a0bf94bf1 100644\n> --- a/refs/files-backend.c\n> +++ b/refs/files-backend.c\n> @@ -165,6 +165,9 @@ static struct ref_entry *create_dir_entry(struct files_ref_store *ref_store,\n>  \t\t\t\t\t  const char *dirname, size_t len,\n>  \t\t\t\t\t  int incomplete);\n>  static void add_entry_to_dir(struct ref_dir *dir, struct ref_entry *entry);\n> +static int files_log_ref_write(const char *refname, const unsigned char *old_sha1,\n> +\t\t\t       const unsigned char *new_sha1, const char *msg,\n> +\t\t\t       int flags, struct strbuf *err);\n>  \n>  static struct ref_dir *get_ref_dir(struct ref_entry *entry)\n>  {\n> diff --git a/refs/refs-internal.h b/refs/refs-internal.h\n> index 25444cf5b0..4c9215d33f 100644\n> --- a/refs/refs-internal.h\n> +++ b/refs/refs-internal.h\n> @@ -220,10 +220,6 @@ struct ref_transaction {\n>  \tenum ref_transaction_state state;\n>  };\n>  \n> -int files_log_ref_write(const char *refname, const unsigned char *old_sha1,\n> -\t\t\tconst unsigned char *new_sha1, const char *msg,\n> -\t\t\tint flags, struct strbuf *err);\n> -\n>  /*\n>   * Check for entries in extras that are within the specified\n>   * directory, where dirname is a reference directory name including\n"}]}