{"thread":{"id":"45060","subject":"[PATCH] worktree: fix option descriptions for `prune`","startedAt":"2017-02-06T13:14:08Z","lastAt":"2017-02-07T11:11:45Z","messageCount":3,"participants":["Patrick Steinhardt","Junio C Hamano","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"310909","messageId":"c2af75361b7b357fa905ab072bfdc45ad055ca49.1486386803.git.patrick.steinhardt@elego.de","threadId":"45060","inReplyTo":null,"subject":"[PATCH] worktree: fix option descriptions for `prune`","fromName":"Patrick Steinhardt","fromEmail":"patrick.steinhardt@elego.de","sentAt":"2017-02-06T13:13:59Z","receivedAt":"2017-02-06T13:14:08Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"The `verbose` and `expire` options of the `git worktree prune`\nsubcommand have wrong descriptions in that they pretend to relate to\nobjects. But as the git-worktree(1) correctly states, these options have\nnothing to do with objects but only with worktrees. Fix the description\naccordingly.\n\nSigned-off-by: Patrick Steinhardt <patrick.steinhardt@elego.de>\n---\n builtin/worktree.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/worktree.c b/builtin/worktree.c\nindex 9a97e37a3..831fe058a 100644\n--- a/builtin/worktree.c\n+++ b/builtin/worktree.c\n@@ -125,9 +125,9 @@ static int prune(int ac, const char **av, const char *prefix)\n {\n \tstruct option options[] = {\n \t\tOPT__DRY_RUN(&show_only, N_(\"do not remove, show only\")),\n-\t\tOPT__VERBOSE(&verbose, N_(\"report pruned objects\")),\n+\t\tOPT__VERBOSE(&verbose, N_(\"report pruned working trees\")),\n \t\tOPT_EXPIRY_DATE(0, \"expire\", &expire,\n-\t\t\t\tN_(\"expire objects older than <time>\")),\n+\t\t\t\tN_(\"expire working trees older than <time>\")),\n \t\tOPT_END()\n \t};\n \n-- \n2.11.1\n\n"},{"id":"310935","messageId":"xmqq60kn2lia.fsf@gitster.mtv.corp.google.com","threadId":"45060","inReplyTo":"c2af75361b7b357fa905ab072bfdc45ad055ca49.1486386803.git.patrick.steinhardt@elego.de","subject":"Re: [PATCH] worktree: fix option descriptions for `prune`","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-02-06T18:59:41Z","receivedAt":"2017-02-06T18:59:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <patrick.steinhardt@elego.de> writes:\n\n>  \tstruct option options[] = {\n>  \t\tOPT__DRY_RUN(&show_only, N_(\"do not remove, show only\")),\n> -\t\tOPT__VERBOSE(&verbose, N_(\"report pruned objects\")),\n> +\t\tOPT__VERBOSE(&verbose, N_(\"report pruned working trees\")),\n>  \t\tOPT_EXPIRY_DATE(0, \"expire\", &expire,\n> -\t\t\t\tN_(\"expire objects older than <time>\")),\n> +\t\t\t\tN_(\"expire working trees older than <time>\")),\n\nThanks for sharp eyes.\n"},{"id":"310976","messageId":"CACsJy8ATyxrTrcym9qPY7EX+rukmF7MhZYEOoEtASrq5Gpg7RA@mail.gmail.com","threadId":"45060","inReplyTo":"xmqq60kn2lia.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] worktree: fix option descriptions for `prune`","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2017-02-07T11:11:02Z","receivedAt":"2017-02-07T11:11:45Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Tue, Feb 7, 2017 at 1:59 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> Patrick Steinhardt <patrick.steinhardt@elego.de> writes:\n>\n>>       struct option options[] = {\n>>               OPT__DRY_RUN(&show_only, N_(\"do not remove, show only\")),\n>> -             OPT__VERBOSE(&verbose, N_(\"report pruned objects\")),\n>> +             OPT__VERBOSE(&verbose, N_(\"report pruned working trees\")),\n>>               OPT_EXPIRY_DATE(0, \"expire\", &expire,\n>> -                             N_(\"expire objects older than <time>\")),\n>> +                             N_(\"expire working trees older than <time>\")),\n>\n> Thanks for sharp eyes.\n\nYep.\n\nThis message never made it to git@vger right, because I didn't see it?\nOh no, gmail classified the original mail as spam again...\n\n-- \nDuy\n"}]}