{"thread":{"id":"45050","subject":"[PATCH] completion: fix git svn authorship switches","startedAt":"2017-02-05T02:19:04Z","lastAt":"2017-02-05T02:19:04Z","messageCount":1,"participants":["Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"310864","messageId":"20170205021857.GA1922@starla","threadId":"45050","inReplyTo":null,"subject":"[PATCH] completion: fix git svn authorship switches","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2017-02-05T02:18:57Z","receivedAt":"2017-02-05T02:19:04Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"--add-author-from and --use-log-author are for \"git svn dcommit\",\nnot \"git svn (init|clone)\"\n\nSigned-off-by: Eric Wong <e@80x24.org>\n---\n contrib/completion/git-completion.bash | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n Though, I now wonder if allowing those switches to write changes\n in $GIT_CONFIG at init/clone time makes sense...\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 97d73ad88f..6990e98c44 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2587,14 +2587,14 @@ _git_svn ()\n \t\t\t--no-metadata --use-svm-props --use-svnsync-props\n \t\t\t--log-window-size= --no-checkout --quiet\n \t\t\t--repack-flags --use-log-author --localtime\n+\t\t\t--add-author-from\n \t\t\t--ignore-paths= --include-paths= $remote_opts\n \t\t\t\"\n \t\tlocal init_opts=\"\n \t\t\t--template= --shared= --trunk= --tags=\n \t\t\t--branches= --stdlayout --minimize-url\n \t\t\t--no-metadata --use-svm-props --use-svnsync-props\n-\t\t\t--rewrite-root= --prefix= --use-log-author\n-\t\t\t--add-author-from $remote_opts\n+\t\t\t--rewrite-root= --prefix= $remote_opts\n \t\t\t\"\n \t\tlocal cmt_opts=\"\n \t\t\t--edit --rmdir --find-copies-harder --copy-similarity=\n-- \nEW\n"}]}