{"thread":{"id":"45016","subject":"[PATCH 1/2] doc: add doc for git-push --recurse-submodules=only","startedAt":"2017-02-01T23:08:32Z","lastAt":"2017-02-04T12:06:06Z","messageCount":6,"participants":["cornelius.weig@tngtech.com","Junio C Hamano","Stefan Beller","Brandon Williams","Cornelius Weig"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"310677","messageId":"20170201230753.19462-1-cornelius.weig@tngtech.com","threadId":"45016","inReplyTo":null,"subject":"[PATCH 1/2] doc: add doc for git-push --recurse-submodules=only","fromName":"","fromEmail":"cornelius.weig@tngtech.com","sentAt":"2017-02-01T23:07:52Z","receivedAt":"2017-02-01T23:08:32Z","isPatch":true,"sender":{"key":"cornelius.weig@tngtech.com","avatar":null},"body":"From: Cornelius Weig \n\nAdd documentation for the `--recurse-submodules=only` option of\ngit-push. The feature was added in commit 225e8bf (add option to\npush only submodules).\n\nSigned-off-by: Cornelius Weig \n---\n\nNotes:\n This feature is already in 'next' but was undocumented. Unless somebody reads\n the release notes, there is no way of knowing about it.\n\n Documentation/git-push.txt | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/git-push.txt b/Documentation/git-push.txt\nindex 8eefabd..1624a35 100644\n--- a/Documentation/git-push.txt\n+++ b/Documentation/git-push.txt\n@@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the\n \tstandard error stream is not directed to a terminal.\n \n --no-recurse-submodules::\n---recurse-submodules=check|on-demand|no::\n+--recurse-submodules=check|on-demand|only|no::\n \tMay be used to make sure all submodule commits used by the\n \trevisions to be pushed are available on a remote-tracking branch.\n \tIf 'check' is used Git will verify that all submodule commits that\n@@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the\n \tremote of the submodule. If any commits are missing the push will\n \tbe aborted and exit with non-zero status. If 'on-demand' is used\n \tall submodules that changed in the revisions to be pushed will be\n-\tpushed. If on-demand was not able to push all necessary revisions\n-\tit will also be aborted and exit with non-zero status. A value of\n-\t'no' or using `--no-recurse-submodules` can be used to override the\n-\tpush.recurseSubmodules configuration variable when no submodule\n-\trecursion is required.\n+\tpushed. If on-demand was not able to push all necessary revisions it will\n+\talso be aborted and exit with non-zero status. If 'only' is used all\n+\tsubmodules will be recursively pushed while the superproject is left\n+\tunpushed. A value of 'no' or using `--no-recurse-submodules` can be used\n+\tto override the push.recurseSubmodules configuration variable when no\n+\tsubmodule recursion is required.\n \n --[no-]verify::\n \tToggle the pre-push hook (see linkgit:githooks[5]). The\n-- \n2.10.2\n\n"},{"id":"310678","messageId":"20170201230753.19462-2-cornelius.weig@tngtech.com","threadId":"45016","inReplyTo":"20170201230753.19462-1-cornelius.weig@tngtech.com","subject":"[PATCH 2/2] completion: add completion for --recurse-submodules=only","fromName":"","fromEmail":"cornelius.weig@tngtech.com","sentAt":"2017-02-01T23:07:53Z","receivedAt":"2017-02-01T23:08:36Z","isPatch":true,"sender":{"key":"cornelius.weig@tngtech.com","avatar":null},"body":"From: Cornelius Weig \n\nCommand completion for 'git-push --recurse-submodules' already knows to\ncomplete some modes. However, the recently added mode 'only' is missing.\n\nAdding 'only' to the recognized modes completes the list of non-trivial\nmodes.\n\nSigned-off-by: Cornelius Weig \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex ff7072a..fe3b0f8 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1675,7 +1675,7 @@ _git_pull ()\n \t__git_complete_remote_or_refspec\n }\n \n-__git_push_recurse_submodules=\"check on-demand\"\n+__git_push_recurse_submodules=\"check on-demand only\"\n \n __git_complete_force_with_lease ()\n {\n-- \n2.10.2\n\n"},{"id":"310680","messageId":"xmqqinotmrhe.fsf@gitster.mtv.corp.google.com","threadId":"45016","inReplyTo":"20170201230753.19462-1-cornelius.weig@tngtech.com","subject":"Re: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-02-01T23:16:45Z","receivedAt":"2017-02-01T23:16:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"cornelius.weig@tngtech.com writes:\n\n> From: Cornelius Weig \n>\n> Add documentation for the `--recurse-submodules=only` option of\n> git-push. The feature was added in commit 225e8bf (add option to\n> push only submodules).\n>\n> Signed-off-by: Cornelius Weig \n> ---\n>\n> Notes:\n> This feature is already in 'next' but was undocumented. Unless somebody reads\n> the release notes, there is no way of knowing about it.\n\nGood eyes; the topic bw/push-submodule-only is already in 'master'.\n\nLooks good to me; Brandon?\n\n>\n> Documentation/git-push.txt | 13 +++++++------\n> 1 file changed, 7 insertions(+), 6 deletions(-)\n>\n> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt\n> index 8eefabd..1624a35 100644\n> --- a/Documentation/git-push.txt\n> +++ b/Documentation/git-push.txt\n> @@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the\n> \tstandard error stream is not directed to a terminal.\n> \n> --no-recurse-submodules::\n> ---recurse-submodules=check|on-demand|no::\n> +--recurse-submodules=check|on-demand|only|no::\n> \tMay be used to make sure all submodule commits used by the\n> \trevisions to be pushed are available on a remote-tracking branch.\n> \tIf 'check' is used Git will verify that all submodule commits that\n> @@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the\n> \tremote of the submodule. If any commits are missing the push will\n> \tbe aborted and exit with non-zero status. If 'on-demand' is used\n> \tall submodules that changed in the revisions to be pushed will be\n> -\tpushed. If on-demand was not able to push all necessary revisions\n> -\tit will also be aborted and exit with non-zero status. A value of\n> -\t'no' or using `--no-recurse-submodules` can be used to override the\n> -\tpush.recurseSubmodules configuration variable when no submodule\n> -\trecursion is required.\n> +\tpushed. If on-demand was not able to push all necessary revisions it will\n> +\talso be aborted and exit with non-zero status. If 'only' is used all\n> +\tsubmodules will be recursively pushed while the superproject is left\n> +\tunpushed. A value of 'no' or using `--no-recurse-submodules` can be used\n> +\tto override the push.recurseSubmodules configuration variable when no\n> +\tsubmodule recursion is required.\n> \n> --[no-]verify::\n> \tToggle the pre-push hook (see linkgit:githooks[5]). The\n"},{"id":"310720","messageId":"CAGZ79kbN90qNyuQ7HkcTMNY3nMu_cx6i3gEVmXrfOBo5=h94ag@mail.gmail.com","threadId":"45016","inReplyTo":"20170201230753.19462-2-cornelius.weig@tngtech.com","subject":"Re: [PATCH 2/2] completion: add completion for --recurse-submodules=only","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-02-02T09:30:37Z","receivedAt":"2017-02-02T09:30:44Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Wed, Feb 1, 2017 at 3:07 PM, wrote:\n> From: Cornelius Weig \n>\n> Command completion for 'git-push --recurse-submodules' already knows to\n> complete some modes. However, the recently added mode 'only' is missing.\n>\n> Adding 'only' to the recognized modes completes the list of non-trivial\n> modes.\n>\n> Signed-off-by: Cornelius Weig \n> ---\n\nLooks good,\n\nThanks,\nStefan\n\n> contrib/completion/git-completion.bash | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index ff7072a..fe3b0f8 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1675,7 +1675,7 @@ _git_pull ()\n> __git_complete_remote_or_refspec\n> }\n>\n> -__git_push_recurse_submodules=\"check on-demand\"\n> +__git_push_recurse_submodules=\"check on-demand only\"\n>\n> __git_complete_force_with_lease ()\n> {\n> --\n> 2.10.2\n>\n"},{"id":"310722","messageId":"CAKoko1rvxLWi+WgEnQEnzjhMpSe1-f_jXQcDT=ALWDHcj1RnmQ@mail.gmail.com","threadId":"45016","inReplyTo":"CAKoko1q=6agpGsABxy8rmm6sGFWx9gE_c1j44h4M=yJ3r4JJBQ@mail.gmail.com","subject":"Fwd: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-02-02T09:32:39Z","receivedAt":"2017-02-02T09:32:46Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"Looks good to me! Thanks for writing the documentation. I really\nneed to be better about getting documentation done at the same time\nI'm adding features :)\n\n-Brandon\n\nOn Wed, Feb 1, 2017 at 3:16 PM, Junio C Hamano wrote:\n>\n> cornelius.weig@tngtech.com writes:\n>\n> > From: Cornelius Weig \n> >\n> > Add documentation for the `--recurse-submodules=only` option of\n> > git-push. The feature was added in commit 225e8bf (add option to\n> > push only submodules).\n> >\n> > Signed-off-by: Cornelius Weig \n> > ---\n> >\n> > Notes:\n> > This feature is already in 'next' but was undocumented. Unless somebody reads\n> > the release notes, there is no way of knowing about it.\n>\n> Good eyes; the topic bw/push-submodule-only is already in 'master'.\n>\n> Looks good to me; Brandon?\n>\n> >\n> > Documentation/git-push.txt | 13 +++++++------\n> > 1 file changed, 7 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt\n> > index 8eefabd..1624a35 100644\n> > --- a/Documentation/git-push.txt\n> > +++ b/Documentation/git-push.txt\n> > @@ -272,7 +272,7 @@ origin +master` to force a push to the `master` branch). See the\n> > standard error stream is not directed to a terminal.\n> >\n> > --no-recurse-submodules::\n> > ---recurse-submodules=check|on-demand|no::\n> > +--recurse-submodules=check|on-demand|only|no::\n> > May be used to make sure all submodule commits used by the\n> > revisions to be pushed are available on a remote-tracking branch.\n> > If 'check' is used Git will verify that all submodule commits that\n> > @@ -280,11 +280,12 @@ origin +master` to force a push to the `master` branch). See the\n> > remote of the submodule. If any commits are missing the push will\n> > be aborted and exit with non-zero status. If 'on-demand' is used\n> > all submodules that changed in the revisions to be pushed will be\n> > - pushed. If on-demand was not able to push all necessary revisions\n> > - it will also be aborted and exit with non-zero status. A value of\n> > - 'no' or using `--no-recurse-submodules` can be used to override the\n> > - push.recurseSubmodules configuration variable when no submodule\n> > - recursion is required.\n> > + pushed. If on-demand was not able to push all necessary revisions it will\n> > + also be aborted and exit with non-zero status. If 'only' is used all\n> > + submodules will be recursively pushed while the superproject is left\n> > + unpushed. A value of 'no' or using `--no-recurse-submodules` can be used\n> > + to override the push.recurseSubmodules configuration variable when no\n> > + submodule recursion is required.\n> >\n> > --[no-]verify::\n> > Toggle the pre-push hook (see linkgit:githooks[5]). The\n"},{"id":"310849","messageId":"f79acbf7-5c06-72e3-c410-aca320a26418@tngtech.com","threadId":"45016","inReplyTo":"xmqqinotmrhe.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 1/2] doc: add doc for git-push --recurse-submodules=only","fromName":"Cornelius Weig","fromEmail":"cornelius.weig@tngtech.com","sentAt":"2017-02-04T12:05:58Z","receivedAt":"2017-02-04T12:06:06Z","isPatch":true,"sender":{"key":"cornelius.weig@tngtech.com","avatar":null},"body":"Shouldn't this be part of v2.12-rc0? I just checked but it's not there.\n\nCheers,\n Cornelius\n"}]}