{"thread":{"id":"44997","subject":"[PATCH] checkout: convert post_checkout_hook() to struct object_id","startedAt":"2017-01-28T22:16:19Z","lastAt":"2017-01-30T22:48:42Z","messageCount":3,"participants":["René Scharfe","Johannes Schindelin","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"310500","messageId":"b30e5d34-436a-af5f-dbad-b1df464bf303@web.de","threadId":"44997","inReplyTo":null,"subject":"[PATCH] checkout: convert post_checkout_hook() to struct object_id","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2017-01-28T22:14:29Z","receivedAt":"2017-01-28T22:16:19Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Signed-off-by: Rene Scharfe <l.s.r@web.de>\n---\n builtin/checkout.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/checkout.c b/builtin/checkout.c\nindex bfe685c198..80d5e38981 100644\n--- a/builtin/checkout.c\n+++ b/builtin/checkout.c\n@@ -56,8 +56,8 @@ static int post_checkout_hook(struct commit *old, struct commit *new,\n \t\t\t      int changed)\n {\n \treturn run_hook_le(NULL, \"post-checkout\",\n-\t\t\t   sha1_to_hex(old ? old->object.oid.hash : null_sha1),\n-\t\t\t   sha1_to_hex(new ? new->object.oid.hash : null_sha1),\n+\t\t\t   oid_to_hex(old ? &old->object.oid : &null_oid),\n+\t\t\t   oid_to_hex(new ? &new->object.oid : &null_oid),\n \t\t\t   changed ? \"1\" : \"0\", NULL);\n \t/* \"new\" can be NULL when checking out from the index before\n \t   a commit exists. */\n-- \n2.11.0\n\n"},{"id":"310523","messageId":"alpine.DEB.2.20.1701301359500.3469@virtualbox","threadId":"44997","inReplyTo":"b30e5d34-436a-af5f-dbad-b1df464bf303@web.de","subject":"Re: [PATCH] checkout: convert post_checkout_hook() to struct object_id","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-01-30T13:01:12Z","receivedAt":"2017-01-30T13:03:04Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi René,\n\nOn Sat, 28 Jan 2017, René Scharfe wrote:\n\n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n\nThese three SHA-1 -> OID patches all appear correct to me.\n\nCiao,\nDscho"},{"id":"310570","messageId":"20170130224822.uehscfwrgav5r6pc@genre.crustytoothpaste.net","threadId":"44997","inReplyTo":"alpine.DEB.2.20.1701301359500.3469@virtualbox","subject":"Re: [PATCH] checkout: convert post_checkout_hook() to struct object_id","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2017-01-30T22:48:22Z","receivedAt":"2017-01-30T22:48:42Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Mon, Jan 30, 2017 at 02:01:12PM +0100, Johannes Schindelin wrote:\n> Hi René,\n> \n> On Sat, 28 Jan 2017, René Scharfe wrote:\n> \n> > Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> \n> These three SHA-1 -> OID patches all appear correct to me.\n\nI concur.  These look good.\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: https://keybase.io/bk2204\n"}]}