{"thread":{"id":"44993","subject":"[PATCH] t0001: don't let a default ACL interfere with the umask test","startedAt":"2017-01-28T20:54:14Z","lastAt":"2017-01-31T17:13:37Z","messageCount":2,"participants":["Matt McCutchen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"310491","messageId":"1485636766.2482.3.camel@mattmccutchen.net","threadId":"44993","inReplyTo":null,"subject":"[PATCH] t0001: don't let a default ACL interfere with the umask test","fromName":"Matt McCutchen","fromEmail":"matt@mattmccutchen.net","sentAt":"2017-01-28T20:25:48Z","receivedAt":"2017-01-28T20:54:14Z","isPatch":true,"sender":{"key":"matt@mattmccutchen.net","avatar":"https://avatars.githubusercontent.com/u/8885753?v=4"},"body":"The \"init creates a new deep directory (umask vs. shared)\" test expects\nthe permissions of newly created files to be based on the umask, which\nfails if a default ACL is inherited from the working tree for git.  So\nattempt to remove a default ACL if there is one.  Same idea as\n8ed0a740dd42bd0724aebed6e3b07c4ea2a2d5e8.  (I guess I'm the only one who\never runs the test suite with a default ACL set.)\n\nSigned-off-by: Matt McCutchen <matt@mattmccutchen.net>\n---\n t/t0001-init.sh | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex b8fc588..e424de5 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -258,6 +258,9 @@ test_expect_success POSIXPERM 'init creates a new deep directory (umask vs. shar\n \t(\n \t\t# Leading directories should honor umask while\n \t\t# the repository itself should follow \"shared\"\n+\t\tmkdir newdir &&\n+\t\t# Remove a default ACL if possible.\n+\t\t(setfacl -k newdir 2>/dev/null || true) &&\n \t\tumask 002 &&\n \t\tgit init --bare --shared=0660 newdir/a/b/c &&\n \t\ttest_path_is_dir newdir/a/b/c/refs &&\n-- \n2.9.3\n\n\n"},{"id":"310605","messageId":"xmqq37fzrw3o.fsf@gitster.mtv.corp.google.com","threadId":"44993","inReplyTo":"1485636766.2482.3.camel@mattmccutchen.net","subject":"Re: [PATCH] t0001: don't let a default ACL interfere with the umask test","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-31T17:13:31Z","receivedAt":"2017-01-31T17:13:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matt McCutchen <matt@mattmccutchen.net> writes:\n\n> The \"init creates a new deep directory (umask vs. shared)\" test expects\n> the permissions of newly created files to be based on the umask, which\n> fails if a default ACL is inherited from the working tree for git.  So\n> attempt to remove a default ACL if there is one.  Same idea as\n> 8ed0a740dd42bd0724aebed6e3b07c4ea2a2d5e8.  (I guess I'm the only one who\n> ever runs the test suite with a default ACL set.)\n\nThanks--people with such a configuration who run tests are valuable ;-)\n"}]}