{"thread":{"id":"44982","subject":"[PATCH] git-bisect: allow running in a working tree subdirectory","startedAt":"2017-01-26T18:33:42Z","lastAt":"2017-01-26T23:27:02Z","messageCount":5,"participants":["marcandre.lureau@redhat.com","Stefan Beller","Junio C Hamano","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"310342","messageId":"20170126183030.28632-1-marcandre.lureau@redhat.com","threadId":"44982","inReplyTo":null,"subject":"[PATCH] git-bisect: allow running in a working tree subdirectory","fromName":"","fromEmail":"marcandre.lureau@redhat.com","sentAt":"2017-01-26T18:30:30Z","receivedAt":"2017-01-26T18:33:42Z","isPatch":true,"sender":{"key":"marcandre.lureau@redhat.com","avatar":null},"body":"From: Marc-André Lureau \n\nIt looks like it can do it.\n\nSigned-off-by: Marc-André Lureau \n---\n git-bisect.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex ae3cb013e..b0bd604d4 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -1,5 +1,6 @@\n #!/bin/sh\n \n+SUBDIRECTORY_OK=Yes\n USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'\n LONG_USAGE='git bisect help\n \tprint this long help message.\n-- \n2.11.0.295.gd7dffce1c.dirty\n\n"},{"id":"310344","messageId":"CAGZ79kZkxnoKCyk9teQnEPjsnS7iEorZALY4dXE8Fy78ifur7g@mail.gmail.com","threadId":"44982","inReplyTo":"20170126183030.28632-1-marcandre.lureau@redhat.com","subject":"Re: [PATCH] git-bisect: allow running in a working tree subdirectory","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-01-26T18:46:04Z","receivedAt":"2017-01-26T18:46:54Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"+ Duy, main author of the worktree feature.\n\nOn Thu, Jan 26, 2017 at 10:30 AM, wrote:\n> From: Marc-André Lureau \n>\n> It looks like it can do it.\n>\n> Signed-off-by: Marc-André Lureau \n> ---\n> git-bisect.sh | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/git-bisect.sh b/git-bisect.sh\n> index ae3cb013e..b0bd604d4 100755\n> --- a/git-bisect.sh\n> +++ b/git-bisect.sh\n> @@ -1,5 +1,6 @@\n> #!/bin/sh\n>\n> +SUBDIRECTORY_OK=Yes\n> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'\n> LONG_USAGE='git bisect help\n> print this long help message.\n> --\n> 2.11.0.295.gd7dffce1c.dirty\n>\n"},{"id":"310354","messageId":"xmqqk29h4nv4.fsf@gitster.mtv.corp.google.com","threadId":"44982","inReplyTo":"CAGZ79kZkxnoKCyk9teQnEPjsnS7iEorZALY4dXE8Fy78ifur7g@mail.gmail.com","subject":"Re: [PATCH] git-bisect: allow running in a working tree subdirectory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-26T19:34:07Z","receivedAt":"2017-01-26T19:37:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n> + Duy, main author of the worktree feature.\n>\n> On Thu, Jan 26, 2017 at 10:30 AM, wrote:\n>> From: Marc-André Lureau \n>>\n>> It looks like it can do it.\n>>\n>> Signed-off-by: Marc-André Lureau \n>> ---\n\nI do not think the OP meant by \"a working tree subdirectory\" using\nthe command in a secondary worktree. SUBDIRECTORY_OK is about \"can\nthe command be started in a subdirectory (as opposed to requiring to\nbe run only at the toplevel)?\"\n\nI am slightly negative on this change, though. The subdirectory you\nare sitting in when you start your bisection may disappear and reappear\nas you dig the history, and I do not think the code makes anything\nspecial to prevent the disappearing current directory from getting\nin the way of bisection process.\n\n>> git-bisect.sh | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/git-bisect.sh b/git-bisect.sh\n>> index ae3cb013e..b0bd604d4 100755\n>> --- a/git-bisect.sh\n>> +++ b/git-bisect.sh\n>> @@ -1,5 +1,6 @@\n>> #!/bin/sh\n>>\n>> +SUBDIRECTORY_OK=Yes\n>> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'\n>> LONG_USAGE='git bisect help\n>> print this long help message.\n>> --\n>> 2.11.0.295.gd7dffce1c.dirty\n>>\n"},{"id":"310363","messageId":"96afaa1d-31d7-0b7e-d2b3-77a455158638@kdbg.org","threadId":"44982","inReplyTo":"20170126183030.28632-1-marcandre.lureau@redhat.com","subject":"Re: [PATCH] git-bisect: allow running in a working tree subdirectory","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2017-01-26T21:46:44Z","receivedAt":"2017-01-26T21:49:21Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com:\n> From: Marc-André Lureau \n>\n> It looks like it can do it.\n>\n> Signed-off-by: Marc-André Lureau \n> ---\n> git-bisect.sh | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/git-bisect.sh b/git-bisect.sh\n> index ae3cb013e..b0bd604d4 100755\n> --- a/git-bisect.sh\n> +++ b/git-bisect.sh\n> @@ -1,5 +1,6 @@\n> #!/bin/sh\n>\n> +SUBDIRECTORY_OK=Yes\n> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'\n> LONG_USAGE='git bisect help\n> \tprint this long help message.\n>\n\nDoes it also work to drive git bisect from a subdirectory and pass a \nfile name (or pathspec) that is relative to that subdirectory rather \nthan relative to the root of the worktree? Can `git bisect good` or `git \nbisect bad` of later bisection steps be invoked from different \nsubdirectories or the root?\n\n-- Hannes\n\n"},{"id":"310373","messageId":"xmqqziid1k51.fsf@gitster.mtv.corp.google.com","threadId":"44982","inReplyTo":"96afaa1d-31d7-0b7e-d2b3-77a455158638@kdbg.org","subject":"Re: [PATCH] git-bisect: allow running in a working tree subdirectory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-26T23:22:50Z","receivedAt":"2017-01-26T23:27:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Sixt writes:\n\n> Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com:\n>> From: Marc-André Lureau \n>>\n>> It looks like it can do it.\n>>\n>> Signed-off-by: Marc-André Lureau \n>> ---\n>> git-bisect.sh | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/git-bisect.sh b/git-bisect.sh\n>> index ae3cb013e..b0bd604d4 100755\n>> --- a/git-bisect.sh\n>> +++ b/git-bisect.sh\n>> @@ -1,5 +1,6 @@\n>> #!/bin/sh\n>>\n>> +SUBDIRECTORY_OK=Yes\n>> USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'\n>> LONG_USAGE='git bisect help\n>> \tprint this long help message.\n>>\n>\n> Does it also work to drive git bisect from a subdirectory and pass a\n> file name (or pathspec) that is relative to that subdirectory rather\n> than relative to the root of the worktree? Can `git bisect good` or\n> `git bisect bad` of later bisection steps be invoked from different\n> subdirectories or the root?\n\nI think the answers are no and no. Entries in BISECT_NAMES and\nBISECT_LOG are not getting any prefix.\n\n"}]}