{"thread":{"id":"44946","subject":"[PATCH v2] travis-ci: fix Perforce install on macOS","startedAt":"2017-01-22T22:56:04Z","lastAt":"2017-01-23T18:39:39Z","messageCount":2,"participants":["Lars Schneider","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"309952","messageId":"20170122225550.28422-1-larsxschneider@gmail.com","threadId":"44946","inReplyTo":null,"subject":"[PATCH v2] travis-ci: fix Perforce install on macOS","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2017-01-22T22:55:50Z","receivedAt":"2017-01-22T22:56:04Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"The `perforce` and `perforce-server` package were moved from brew [1][2]\nto cask [3]. Teach TravisCI the new location.\n\nPerforce updates their binaries without version bumps. That made the\nbrew install (legitimately!) fail due to checksum mismatches. The\nworkaround is not necessary anymore as Cask [4] allows to disable the\nchecksum test for individual formulas.\n\n[1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6\n[2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b\n[3] https://github.com/caskroom/homebrew-cask/pull/29180\n[4] https://caskroom.github.io/\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\n---\n\nHi,\n\nthis small update removes one more unnecessary line and makes the\nformula name lower case (no functional reason - just looks better ;-).\n\n@Junio: Do you prefer such a v2 as \"--in-reply-to\" to v1 or as separate\n        thread? What eases your workflow?\n\nThanks,\nLars\n\n\nNotes:\n    Base Commit: 787f75f056 (787f75f0567aa8c7347544c65e9d3bc6640a27d4)\n    Diff on Web: https://github.com/larsxschneider/git/commit/a8ec423355\n    Checkout:    git fetch https://github.com/larsxschneider/git travisci/brew-perforce-fix-v2 && git checkout a8ec423355\n\n    Interdiff (v1..v2):\n\n    diff --git a/.travis.yml b/.travis.yml\n    index c6ba8c8ec5..9c63c8c3f6 100644\n    --- a/.travis.yml\n    +++ b/.travis.yml\n    @@ -76,12 +76,11 @@ before_install:\n           ;;\n         osx)\n           brew update --quiet\n    -      brew tap homebrew/binary --quiet\n           # Uncomment this if you want to run perf tests:\n           # brew install gnu-time\n           brew install git-lfs gettext\n           brew link --force gettext\n    -      brew install Caskroom/cask/perforce\n    +      brew install caskroom/cask/perforce\n           ;;\n         esac;\n         echo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\";\n\n .travis.yml | 12 ++----------\n 1 file changed, 2 insertions(+), 10 deletions(-)\n\ndiff --git a/.travis.yml b/.travis.yml\nindex 3843967a69..9c63c8c3f6 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -75,20 +75,12 @@ before_install:\n       popd\n       ;;\n     osx)\n-      brew_force_set_latest_binary_hash () {\n-        FORMULA=$1\n-        SHA=$(brew fetch --force $FORMULA 2>&1 | grep ^SHA256: | cut -d ' ' -f 2)\n-        sed -E -i.bak \"s/sha256 \\\"[0-9a-f]{64}\\\"/sha256 \\\"$SHA\\\"/g\" \\\n-          \"$(brew --repository homebrew/homebrew-binary)/$FORMULA.rb\"\n-      }\n       brew update --quiet\n-      brew tap homebrew/binary --quiet\n-      brew_force_set_latest_binary_hash perforce\n-      brew_force_set_latest_binary_hash perforce-server\n       # Uncomment this if you want to run perf tests:\n       # brew install gnu-time\n-      brew install git-lfs perforce-server perforce gettext\n+      brew install git-lfs gettext\n       brew link --force gettext\n+      brew install caskroom/cask/perforce\n       ;;\n     esac;\n     echo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\";\n--\n2.11.0\n\n"},{"id":"309996","messageId":"xmqqmvehsjrv.fsf@gitster.mtv.corp.google.com","threadId":"44946","inReplyTo":"20170122225550.28422-1-larsxschneider@gmail.com","subject":"Re: [PATCH v2] travis-ci: fix Perforce install on macOS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-23T18:39:32Z","receivedAt":"2017-01-23T18:39:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lars Schneider <larsxschneider@gmail.com> writes:\n\n> The `perforce` and `perforce-server` package were moved from brew [1][2]\n> to cask [3]. Teach TravisCI the new location.\n>\n> Perforce updates their binaries without version bumps. That made the\n> brew install (legitimately!) fail due to checksum mismatches. The\n> workaround is not necessary anymore as Cask [4] allows to disable the\n> checksum test for individual formulas.\n>\n> [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6\n> [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b\n> [3] https://github.com/caskroom/homebrew-cask/pull/29180\n> [4] https://caskroom.github.io/\n>\n> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>\n> ---\n>\n> Hi,\n>\n> this small update removes one more unnecessary line and makes the\n> formula name lower case (no functional reason - just looks better ;-).\n>\n> @Junio: Do you prefer such a v2 as \"--in-reply-to\" to v1 or as separate\n>         thread? What eases your workflow?\n\nIt does not make that much of a difference if the second one comes\nwithin a few days since the first one but in general it probably\nwould help if the follow-up is threaded _and_ made it clear upfront\nthat if somebody is reading v2 then v1 can be ignored ;-).\n\nThanks.\n"}]}