{"thread":{"id":"4494","subject":"[PATCH 1/4] Remove dependencies with absolute path","startedAt":"2006-06-13T04:32:24Z","lastAt":"2006-06-13T04:32:33Z","messageCount":4,"participants":["Pavel Roskin"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"21704","messageId":"20060613043224.16681.98358.stgit@dv.roinet.com","threadId":"4494","inReplyTo":null,"subject":"[PATCH 1/4] Remove dependencies with absolute path","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-06-13T04:32:24Z","receivedAt":"2006-06-13T04:32:24Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"From: Pavel Roskin <proski@gnu.org>\n\nNot everybody has headers in the same locations and not everybody uses\ngcc 3.3.6.  Only leave dependencies with relative path.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n---\n\n Makefile |  213 ++++----------------------------------------------------------\n 1 files changed, 14 insertions(+), 199 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 1257ae7..cc277e2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -38,218 +38,33 @@ clean:\n .PHONY: install clean\n # DO NOT DELETE\n \n-cache.o: /usr/include/stdio.h /usr/include/features.h\n-cache.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cache.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cache.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cache.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-cache.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cache.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cache.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cache.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n-cache.o: /usr/include/search.h /usr/include/string.h /usr/include/stdlib.h\n-cache.o: /usr/include/limits.h\n-cache.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/limits.h\n-cache.o: /usr/include/unistd.h /usr/include/bits/posix_opt.h\n-cache.o: /usr/include/bits/confname.h /usr/include/ctype.h\n-cache.o: /usr/include/endian.h /usr/include/bits/endian.h /usr/include/time.h\n-cache.o: /usr/include/bits/time.h ./cbtcommon/hash.h ./cbtcommon/list.h\n-cache.o: ./cbtcommon/inline.h ./cbtcommon/debug.h /usr/include/sys/types.h\n+cache.o: ./cbtcommon/hash.h ./cbtcommon/list.h\n+cache.o: ./cbtcommon/inline.h ./cbtcommon/debug.h\n cache.o: cache.h cvsps_types.h cvsps.h util.h\n-cap.o: /usr/include/stdio.h /usr/include/features.h /usr/include/sys/cdefs.h\n-cap.o: /usr/include/gnu/stubs.h\n-cap.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cap.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cap.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-cap.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cap.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cap.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cap.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n-cap.o: /usr/include/stdlib.h /usr/include/string.h ./cbtcommon/debug.h\n-cap.o: /usr/include/sys/types.h /usr/include/time.h /usr/include/bits/time.h\n+cap.o: ./cbtcommon/debug.h\n cap.o: ./cbtcommon/inline.h ./cbtcommon/text_util.h cap.h cvs_direct.h\n-cvs_direct.o: /usr/include/string.h /usr/include/features.h\n-cvs_direct.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cvs_direct.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cvs_direct.o: /usr/include/unistd.h /usr/include/bits/posix_opt.h\n-cvs_direct.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cvs_direct.o: /usr/include/bits/typesizes.h /usr/include/bits/confname.h\n-cvs_direct.o: /usr/include/stdlib.h /usr/include/limits.h\n-cvs_direct.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/limits.h\n-cvs_direct.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cvs_direct.o: /usr/include/zlib.h /usr/include/zconf.h\n-cvs_direct.o: /usr/include/sys/types.h /usr/include/time.h\n-cvs_direct.o: /usr/include/bits/time.h /usr/include/sys/socket.h\n-cvs_direct.o: /usr/include/sys/uio.h /usr/include/bits/uio.h\n-cvs_direct.o: /usr/include/bits/socket.h /usr/include/bits/sockaddr.h\n-cvs_direct.o: /usr/include/asm/socket.h /usr/include/asm/sockios.h\n-cvs_direct.o: ./cbtcommon/debug.h /usr/include/stdio.h /usr/include/libio.h\n-cvs_direct.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cvs_direct.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cvs_direct.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n+cvs_direct.o: ./cbtcommon/debug.h\n cvs_direct.o: ./cbtcommon/inline.h ./cbtcommon/text_util.h\n cvs_direct.o: ./cbtcommon/tcpsocket.h ./cbtcommon/sio.h cvs_direct.h util.h\n-cvsps.o: /usr/include/stdio.h /usr/include/features.h\n-cvsps.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cvsps.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cvsps.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cvsps.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-cvsps.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cvsps.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cvsps.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cvsps.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n-cvsps.o: /usr/include/stdlib.h /usr/include/string.h /usr/include/limits.h\n-cvsps.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/limits.h\n-cvsps.o: /usr/include/unistd.h /usr/include/bits/posix_opt.h\n-cvsps.o: /usr/include/bits/confname.h /usr/include/search.h\n-cvsps.o: /usr/include/time.h /usr/include/bits/time.h /usr/include/ctype.h\n-cvsps.o: /usr/include/endian.h /usr/include/bits/endian.h\n-cvsps.o: /usr/include/sys/stat.h /usr/include/bits/stat.h\n-cvsps.o: /usr/include/sys/types.h /usr/include/fcntl.h\n-cvsps.o: /usr/include/bits/fcntl.h /usr/include/regex.h\n-cvsps.o: /usr/include/sys/wait.h /usr/include/signal.h\n-cvsps.o: /usr/include/bits/sigset.h /usr/include/bits/signum.h\n-cvsps.o: /usr/include/sys/resource.h /usr/include/bits/resource.h\n-cvsps.o: /usr/include/bits/waitflags.h /usr/include/bits/waitstatus.h\n cvsps.o: ./cbtcommon/hash.h ./cbtcommon/list.h ./cbtcommon/inline.h\n cvsps.o: ./cbtcommon/list.h ./cbtcommon/text_util.h ./cbtcommon/debug.h\n cvsps.o: ./cbtcommon/rcsid.h cache.h cvsps_types.h cvsps.h util.h stats.h\n cvsps.o: cap.h cvs_direct.h list_sort.h\n-list_sort.o: /usr/include/stdio.h /usr/include/features.h\n-list_sort.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-list_sort.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-list_sort.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-list_sort.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-list_sort.o: /usr/include/_G_config.h /usr/include/wchar.h\n-list_sort.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-list_sort.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-list_sort.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n-list_sort.o: /usr/include/stdlib.h list_sort.h ./cbtcommon/list.h\n-stats.o: /usr/include/stdio.h /usr/include/features.h\n-stats.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-stats.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-stats.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-stats.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-stats.o: /usr/include/_G_config.h /usr/include/wchar.h\n-stats.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-stats.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-stats.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n-stats.o: /usr/include/string.h /usr/include/search.h ./cbtcommon/hash.h\n+list_sort.o: list_sort.h ./cbtcommon/list.h\n+stats.o: ./cbtcommon/hash.h\n stats.o: ./cbtcommon/list.h ./cbtcommon/inline.h cvsps_types.h\n-stats.o: /usr/include/time.h /usr/include/bits/time.h cvsps.h\n-util.o: /usr/include/stdio.h /usr/include/features.h /usr/include/sys/cdefs.h\n-util.o: /usr/include/gnu/stubs.h\n-util.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-util.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-util.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-util.o: /usr/include/_G_config.h /usr/include/wchar.h\n-util.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-util.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-util.o: /usr/include/bits/stdio_lim.h /usr/include/bits/sys_errlist.h\n-util.o: /usr/include/string.h /usr/include/stdlib.h /usr/include/unistd.h\n-util.o: /usr/include/bits/posix_opt.h /usr/include/bits/confname.h\n-util.o: /usr/include/limits.h\n-util.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/limits.h\n-util.o: /usr/include/assert.h /usr/include/search.h /usr/include/time.h\n-util.o: /usr/include/bits/time.h /usr/include/errno.h\n-util.o: /usr/include/bits/errno.h /usr/include/linux/errno.h\n-util.o: /usr/include/asm/errno.h /usr/include/asm-generic/errno.h\n-util.o: /usr/include/asm-generic/errno-base.h /usr/include/signal.h\n-util.o: /usr/include/bits/sigset.h /usr/include/bits/signum.h\n-util.o: /usr/include/regex.h /usr/include/sys/types.h /usr/include/sys/stat.h\n-util.o: /usr/include/bits/stat.h /usr/include/sys/time.h\n-util.o: /usr/include/sys/select.h /usr/include/bits/select.h\n-util.o: /usr/include/sys/wait.h /usr/include/sys/resource.h\n-util.o: /usr/include/bits/resource.h /usr/include/bits/waitflags.h\n-util.o: /usr/include/bits/waitstatus.h ./cbtcommon/debug.h\n+stats.o: cvsps.h\n+util.o: ./cbtcommon/debug.h\n util.o: ./cbtcommon/inline.h util.h\n-cbtcommon/debug.o: /usr/include/stdio.h /usr/include/features.h\n-cbtcommon/debug.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cbtcommon/debug.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cbtcommon/debug.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cbtcommon/debug.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-cbtcommon/debug.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cbtcommon/debug.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cbtcommon/debug.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cbtcommon/debug.o: /usr/include/bits/stdio_lim.h\n-cbtcommon/debug.o: /usr/include/bits/sys_errlist.h /usr/include/errno.h\n-cbtcommon/debug.o: /usr/include/bits/errno.h /usr/include/linux/errno.h\n-cbtcommon/debug.o: /usr/include/asm/errno.h /usr/include/asm-generic/errno.h\n-cbtcommon/debug.o: /usr/include/asm-generic/errno-base.h /usr/include/ctype.h\n-cbtcommon/debug.o: /usr/include/endian.h /usr/include/bits/endian.h\n-cbtcommon/debug.o: /usr/include/string.h cbtcommon/debug.h\n-cbtcommon/debug.o: /usr/include/sys/types.h /usr/include/time.h\n-cbtcommon/debug.o: /usr/include/bits/time.h ./cbtcommon/inline.h\n+cbtcommon/debug.o: cbtcommon/debug.h\n+cbtcommon/debug.o: ./cbtcommon/inline.h\n cbtcommon/debug.o: cbtcommon/rcsid.h\n-cbtcommon/hash.o: /usr/include/stdio.h /usr/include/features.h\n-cbtcommon/hash.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cbtcommon/hash.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cbtcommon/hash.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cbtcommon/hash.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-cbtcommon/hash.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cbtcommon/hash.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cbtcommon/hash.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cbtcommon/hash.o: /usr/include/bits/stdio_lim.h\n-cbtcommon/hash.o: /usr/include/bits/sys_errlist.h /usr/include/stdlib.h\n-cbtcommon/hash.o: /usr/include/string.h cbtcommon/debug.h\n-cbtcommon/hash.o: /usr/include/sys/types.h /usr/include/time.h\n-cbtcommon/hash.o: /usr/include/bits/time.h ./cbtcommon/inline.h\n+cbtcommon/hash.o: cbtcommon/debug.h\n+cbtcommon/hash.o: ./cbtcommon/inline.h\n cbtcommon/hash.o: cbtcommon/hash.h ./cbtcommon/list.h cbtcommon/rcsid.h\n-cbtcommon/sio.o: /usr/include/stdio.h /usr/include/features.h\n-cbtcommon/sio.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cbtcommon/sio.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cbtcommon/sio.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cbtcommon/sio.o: /usr/include/bits/typesizes.h /usr/include/libio.h\n-cbtcommon/sio.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cbtcommon/sio.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cbtcommon/sio.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cbtcommon/sio.o: /usr/include/bits/stdio_lim.h\n-cbtcommon/sio.o: /usr/include/bits/sys_errlist.h /usr/include/unistd.h\n-cbtcommon/sio.o: /usr/include/bits/posix_opt.h /usr/include/bits/confname.h\n-cbtcommon/sio.o: /usr/include/errno.h /usr/include/bits/errno.h\n-cbtcommon/sio.o: /usr/include/linux/errno.h /usr/include/asm/errno.h\n-cbtcommon/sio.o: /usr/include/asm-generic/errno.h\n-cbtcommon/sio.o: /usr/include/asm-generic/errno-base.h cbtcommon/sio.h\n+cbtcommon/sio.o: cbtcommon/sio.h\n cbtcommon/sio.o: cbtcommon/rcsid.h\n-cbtcommon/tcpsocket.o: /usr/include/string.h /usr/include/features.h\n-cbtcommon/tcpsocket.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cbtcommon/tcpsocket.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cbtcommon/tcpsocket.o: /usr/include/sys/types.h /usr/include/bits/types.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/wordsize.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/typesizes.h /usr/include/time.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/time.h /usr/include/sys/socket.h\n-cbtcommon/tcpsocket.o: /usr/include/sys/uio.h /usr/include/bits/uio.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/socket.h /usr/include/limits.h\n-cbtcommon/tcpsocket.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/limits.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/sockaddr.h /usr/include/asm/socket.h\n-cbtcommon/tcpsocket.o: /usr/include/asm/sockios.h /usr/include/netinet/in.h\n-cbtcommon/tcpsocket.o: /usr/include/stdint.h /usr/include/bits/wchar.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/in.h /usr/include/endian.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/endian.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/byteswap.h /usr/include/arpa/inet.h\n-cbtcommon/tcpsocket.o: /usr/include/netdb.h /usr/include/bits/netdb.h\n-cbtcommon/tcpsocket.o: /usr/include/errno.h /usr/include/bits/errno.h\n-cbtcommon/tcpsocket.o: /usr/include/linux/errno.h /usr/include/asm/errno.h\n-cbtcommon/tcpsocket.o: /usr/include/asm-generic/errno.h\n-cbtcommon/tcpsocket.o: /usr/include/asm-generic/errno-base.h\n cbtcommon/tcpsocket.o: cbtcommon/tcpsocket.h cbtcommon/debug.h\n-cbtcommon/tcpsocket.o: /usr/include/stdio.h /usr/include/libio.h\n-cbtcommon/tcpsocket.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cbtcommon/tcpsocket.o: /usr/include/gconv.h\n-cbtcommon/tcpsocket.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/stdio_lim.h\n-cbtcommon/tcpsocket.o: /usr/include/bits/sys_errlist.h ./cbtcommon/inline.h\n+cbtcommon/tcpsocket.o: ./cbtcommon/inline.h\n cbtcommon/tcpsocket.o: cbtcommon/rcsid.h\n-cbtcommon/text_util.o: /usr/include/ctype.h /usr/include/features.h\n-cbtcommon/text_util.o: /usr/include/sys/cdefs.h /usr/include/gnu/stubs.h\n-cbtcommon/text_util.o: /usr/include/bits/types.h /usr/include/bits/wordsize.h\n-cbtcommon/text_util.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stddef.h\n-cbtcommon/text_util.o: /usr/include/bits/typesizes.h /usr/include/endian.h\n-cbtcommon/text_util.o: /usr/include/bits/endian.h /usr/include/string.h\n-cbtcommon/text_util.o: /usr/include/stdio.h /usr/include/libio.h\n-cbtcommon/text_util.o: /usr/include/_G_config.h /usr/include/wchar.h\n-cbtcommon/text_util.o: /usr/include/bits/wchar.h /usr/include/gconv.h\n-cbtcommon/text_util.o: /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/include/stdarg.h\n-cbtcommon/text_util.o: /usr/include/bits/stdio_lim.h\n-cbtcommon/text_util.o: /usr/include/bits/sys_errlist.h /usr/include/stdlib.h\n cbtcommon/text_util.o: cbtcommon/text_util.h cbtcommon/rcsid.h\n"},{"id":"21705","messageId":"20060613043229.16681.52113.stgit@dv.roinet.com","threadId":"4494","inReplyTo":"20060613043224.16681.98358.stgit@dv.roinet.com","subject":"[PATCH 2/4] Trivial compile fix for cache.c","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-06-13T04:32:29Z","receivedAt":"2006-06-13T04:32:29Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"From: Pavel Roskin <proski@gnu.org>\n\n\"tagnames\" was renamed to \"link\", fix the last occurrence of \"tagnames\".\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n---\n\n cache.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/cache.c b/cache.c\nindex 409392d..07e5d02 100644\n--- a/cache.c\n+++ b/cache.c\n@@ -501,7 +501,7 @@ static void dump_patch_set(FILE * fp, Pa\n \tstruct list_head * tag;\n \tfor (tag = ps->tags.next; tag != &ps->tags; tag = tag->next)\n \t{\n-            TagName* tagname = list_entry (tag, TagName, tagnames);\n+            TagName* tagname = list_entry (tag, TagName, link);\n \n \t    fprintf(fp, \" %s %d%s\", tagname->name, tagname->flags,\n \t\t    (tag->next == &ps->tags) ? \"\" : \",\");\n"},{"id":"21706","messageId":"20060613043231.16681.13655.stgit@dv.roinet.com","threadId":"4494","inReplyTo":"20060613043224.16681.98358.stgit@dv.roinet.com","subject":"[PATCH 3/4] Use __linux__ conditional, not LINUX.","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-06-13T04:32:31Z","receivedAt":"2006-06-13T04:32:31Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"From: Pavel Roskin <proski@gnu.org>\n\n__linux__ is defined automatically, LINUX is not.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n---\n\n cbtcommon/tcpsocket.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/cbtcommon/tcpsocket.c b/cbtcommon/tcpsocket.c\nindex 27cc13a..a174007 100644\n--- a/cbtcommon/tcpsocket.c\n+++ b/cbtcommon/tcpsocket.c\n@@ -185,14 +185,14 @@ #endif\n int\n convert_address(long *dest, const char *addr_str)\n {\n-#ifdef LINUX\n+#ifdef __linux__\n   struct in_addr ip;\n #endif\n   int retval = 0;\n   char errstr[256];\n   \n   /* first try converting \"numbers and dots\" notation */\n-#ifdef LINUX\n+#ifdef __linux__\n   if ( inet_aton(addr_str, &ip) )\n   {\n     memcpy(dest, &ip.s_addr, sizeof(ip.s_addr));\n"},{"id":"21707","messageId":"20060613043233.16681.68343.stgit@dv.roinet.com","threadId":"4494","inReplyTo":"20060613043224.16681.98358.stgit@dv.roinet.com","subject":"[PATCH 4/4] Use INADDR_NONE instead of -1 to check inet_addr() result","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2006-06-13T04:32:33Z","receivedAt":"2006-06-13T04:32:33Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"From: Pavel Roskin <proski@gnu.org>\n\nINADDR_NONE is not equal to -1 on 64-bit systems.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n---\n\n cbtcommon/tcpsocket.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/cbtcommon/tcpsocket.c b/cbtcommon/tcpsocket.c\nindex a174007..f31060e 100644\n--- a/cbtcommon/tcpsocket.c\n+++ b/cbtcommon/tcpsocket.c\n@@ -198,7 +198,7 @@ #ifdef __linux__\n     memcpy(dest, &ip.s_addr, sizeof(ip.s_addr));\n   }\n #else\n-  if ( (*dest = inet_addr(addr_str)) != -1)\n+  if ( (*dest = inet_addr(addr_str)) != INADDR_NONE)\n   {\n     /* nothing */\n   }\n"}]}