{"thread":{"id":"4486","subject":"[PATCH] Fix git-format-patch -s","startedAt":"2006-06-12T19:31:38Z","lastAt":"2006-06-12T19:31:38Z","messageCount":1,"participants":["Eric W. Biederman"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"21676","messageId":"m1k67m5fxh.fsf@ebiederm.dsl.xmission.com","threadId":"4486","inReplyTo":null,"subject":"[PATCH] Fix git-format-patch -s","fromName":"Eric W. Biederman","fromEmail":"ebiederm@xmission.com","sentAt":"2006-06-12T19:31:38Z","receivedAt":"2006-06-12T19:31:38Z","isPatch":true,"sender":{"key":"ebiederm@xmission.com","avatar":"https://avatars.githubusercontent.com/u/7477136?v=4"},"body":"\nWhen git-format-patch was converted to a builtin an appropriate call\nto setup_ident was missed and thus git-format-patch -s fails because\nit doesn't look up anything in the password file.\n\nSigned-off-by: Eric W. Biederman <ebiederm@xmission.com>\n---\n builtin-log.c |    7 +++++--\n 1 files changed, 5 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex 29a8851..322024c 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -217,8 +217,11 @@ int cmd_format_patch(int argc, const cha\n \t\t}\n \t\telse if (!strcmp(argv[i], \"--signoff\") ||\n \t\t\t !strcmp(argv[i], \"-s\")) {\n-\t\t\tconst char *committer = git_committer_info(1);\n-\t\t\tconst char *endpos = strchr(committer, '>');\n+\t\t\tconst char *committer;\n+\t\t\tconst char *endpos;\n+\t\t\tsetup_ident();\n+\t\t\tcommitter = git_committer_info(1);\n+\t\t\tendpos = strchr(committer, '>');\n \t\t\tif (!endpos)\n \t\t\t\tdie(\"bogos committer info %s\\n\", committer);\n \t\t\tadd_signoff = xmalloc(endpos - committer + 2);\n-- \n1.4.0.g25f48-dirty\n"}]}