{"thread":{"id":"44849","subject":"[PATCH] index: improve constness for reading blob data","startedAt":"2017-01-10T20:06:37Z","lastAt":"2017-01-11T21:36:17Z","messageCount":2,"participants":["Brandon Williams","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"309155","messageId":"20170110200610.146596-1-bmwill@google.com","threadId":"44849","inReplyTo":null,"subject":"[PATCH] index: improve constness for reading blob data","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-01-10T20:06:10Z","receivedAt":"2017-01-10T20:06:37Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"Improve constness of the index_state parameter to the\n'read_blob_data_from_index' function.\n\nSigned-off-by: Brandon Williams <bmwill@google.com>\n---\n cache.h      | 2 +-\n read-cache.c | 3 ++-\n 2 files changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/cache.h b/cache.h\nindex a50a61a19..363953c1a 100644\n--- a/cache.h\n+++ b/cache.h\n@@ -599,7 +599,7 @@ extern int chmod_index_entry(struct index_state *, struct cache_entry *ce, char\n extern int ce_same_name(const struct cache_entry *a, const struct cache_entry *b);\n extern void set_object_name_for_intent_to_add_entry(struct cache_entry *ce);\n extern int index_name_is_other(const struct index_state *, const char *, int);\n-extern void *read_blob_data_from_index(struct index_state *, const char *, unsigned long *);\n+extern void *read_blob_data_from_index(const struct index_state *, const char *, unsigned long *);\n \n /* do stat comparison even if CE_VALID is true */\n #define CE_MATCH_IGNORE_VALID\t\t01\ndiff --git a/read-cache.c b/read-cache.c\nindex f92a912dc..6ee044442 100644\n--- a/read-cache.c\n+++ b/read-cache.c\n@@ -2292,7 +2292,8 @@ int index_name_is_other(const struct index_state *istate, const char *name,\n \treturn 1;\n }\n \n-void *read_blob_data_from_index(struct index_state *istate, const char *path, unsigned long *size)\n+void *read_blob_data_from_index(const struct index_state *istate,\n+\t\t\t\tconst char *path, unsigned long *size)\n {\n \tint pos, len;\n \tunsigned long sz;\n-- \n2.11.0.390.gc69c2f50cf-goog\n\n"},{"id":"309234","messageId":"xmqqy3yhmg8m.fsf@gitster.mtv.corp.google.com","threadId":"44849","inReplyTo":"20170110200610.146596-1-bmwill@google.com","subject":"Re: [PATCH] index: improve constness for reading blob data","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-11T21:36:09Z","receivedAt":"2017-01-11T21:36:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brandon Williams <bmwill@google.com> writes:\n\n> Improve constness of the index_state parameter to the\n> 'read_blob_data_from_index' function.\n>\n> Signed-off-by: Brandon Williams <bmwill@google.com>\n> ---\n\nThanks.\n"}]}