{"thread":{"id":"44834","subject":"[PATCH] Makefile: POSIX windres","startedAt":"2017-01-07T21:41:52Z","lastAt":"2017-01-09T19:54:37Z","messageCount":5,"participants":["Steven Penny","Junio C Hamano","Johannes Schindelin","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"308933","messageId":"20170107214110.3124-1-svnpenn@gmail.com","threadId":"44834","inReplyTo":null,"subject":"[PATCH] Makefile: POSIX windres","fromName":"Steven Penny","fromEmail":"svnpenn@gmail.com","sentAt":"2017-01-07T21:41:10Z","receivedAt":"2017-01-07T21:41:52Z","isPatch":true,"sender":{"key":"svnpenn@gmail.com","avatar":"https://avatars.githubusercontent.com/u/60531334?v=4"},"body":"When environment variable POSIXLY_CORRECT is set, the \"input -o output\" syntax\nis not supported.\n\nhttp://cygwin.com/ml/cygwin/2017-01/msg00036.html\n\nSigned-off-by: Steven Penny \n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex d861bd9..a2a1212 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1816,7 +1816,7 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES\n git.res: git.rc GIT-VERSION-FILE\n \t$(QUIET_RC)$(RC) \\\n \t $(join -DMAJOR= -DMINOR=, $(wordlist 1,2,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \\\n-\t -DGIT_VERSION=\"\\\\\\\"$(GIT_VERSION)\\\\\\\"\" $< -o $@\n+\t -DGIT_VERSION=\"\\\\\\\"$(GIT_VERSION)\\\\\\\"\" -i $< -o $@\n \n # This makes sure we depend on the NO_PERL setting itself.\n $(SCRIPT_PERL_GEN): GIT-BUILD-OPTIONS\n-- \n2.8.3\n\n"},{"id":"308980","messageId":"xmqqtw99x70u.fsf@gitster.mtv.corp.google.com","threadId":"44834","inReplyTo":"20170107214110.3124-1-svnpenn@gmail.com","subject":"Re: [PATCH] Makefile: POSIX windres","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-09T03:10:41Z","receivedAt":"2017-01-09T03:10:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Steven Penny writes:\n\n> When environment variable POSIXLY_CORRECT is set, the \"input -o output\" syntax\n> is not supported.\n>\n> http://cygwin.com/ml/cygwin/2017-01/msg00036.html\n>\n> Signed-off-by: Steven Penny \n> ---\n\nWho other than cygwin build uses this target? Git for Windows?\n\nHannes, Dscho, is this change OK with you guys?\n \n> Makefile | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index d861bd9..a2a1212 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1816,7 +1816,7 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES\n> git.res: git.rc GIT-VERSION-FILE\n> \t$(QUIET_RC)$(RC) \\\n> \t $(join -DMAJOR= -DMINOR=, $(wordlist 1,2,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \\\n> -\t -DGIT_VERSION=\"\\\\\\\"$(GIT_VERSION)\\\\\\\"\" $< -o $@\n> +\t -DGIT_VERSION=\"\\\\\\\"$(GIT_VERSION)\\\\\\\"\" -i $< -o $@\n> \n> # This makes sure we depend on the NO_PERL setting itself.\n> $(SCRIPT_PERL_GEN): GIT-BUILD-OPTIONS\n"},{"id":"309005","messageId":"alpine.DEB.2.20.1701090903500.3469@virtualbox","threadId":"44834","inReplyTo":"xmqqtw99x70u.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Makefile: POSIX windres","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-01-09T08:09:54Z","receivedAt":"2017-01-09T08:10:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Sun, 8 Jan 2017, Junio C Hamano wrote:\n\n> Steven Penny writes:\n> \n> > When environment variable POSIXLY_CORRECT is set, the \"input -o\n> > output\" syntax is not supported.\n> >\n> > http://cygwin.com/ml/cygwin/2017-01/msg00036.html\n> >\n> > Signed-off-by: Steven Penny \n> > ---\n> \n> Who other than cygwin build uses this target? Git for Windows?\n\nYes, Git for Windows uses this target, as did msysGit (and I suspect\nHannes' setup).\n\nThe resources are built correctly in Git for Windows SDK with this patch,\nand I just verified that the windres shipped with the last msysGit (AKA\nGit for Windows 1.x' SDK) handles the -i flag correctly, too. That is, at\nleast windres.exe included in binutils-2.19.1-mingw32-bin.tar.gz (which\nwas current at the time I updated msysGit on Feb 19 2009) can handle it.\n\nSo: ACK\n\nCiao,\nDscho\n\nP.S.: I applied this patch to Git for Windows' `master`:\nhttps://github.com/git-for-windows/git/commit/744120c602\n"},{"id":"309011","messageId":"xmqq7f64y38i.fsf@gitster.mtv.corp.google.com","threadId":"44834","inReplyTo":"alpine.DEB.2.20.1701090903500.3469@virtualbox","subject":"Re: [PATCH] Makefile: POSIX windres","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-09T09:47:09Z","receivedAt":"2017-01-09T09:47:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n>> Who other than cygwin build uses this target? Git for Windows?\n>\n> Yes, Git for Windows uses this target, as did msysGit (and I suspect\n> Hannes' setup).\n> ...\n> So: ACK\n\nThanks.\n"},{"id":"309064","messageId":"69ad0a2b-2005-4845-7400-9951a0811c1c@kdbg.org","threadId":"44834","inReplyTo":"alpine.DEB.2.20.1701090903500.3469@virtualbox","subject":"Re: [PATCH] Makefile: POSIX windres","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2017-01-09T19:54:24Z","receivedAt":"2017-01-09T19:54:37Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 09.01.2017 um 09:09 schrieb Johannes Schindelin:\n> Hi Junio,\n>\n> On Sun, 8 Jan 2017, Junio C Hamano wrote:\n>\n>> Steven Penny writes:\n>>\n>>> When environment variable POSIXLY_CORRECT is set, the \"input -o\n>>> output\" syntax is not supported.\n>>>\n>>> http://cygwin.com/ml/cygwin/2017-01/msg00036.html\n>>>\n>>> Signed-off-by: Steven Penny \n>>> ---\n>>\n>> Who other than cygwin build uses this target? Git for Windows?\n>\n> Yes, Git for Windows uses this target, as did msysGit (and I suspect\n> Hannes' setup).\n\nThe patch works for me, too.\n\n-- Hannes\n\n"}]}