{"thread":{"id":"44774","subject":"[PATCH 0/2] submodule config test cleanup","startedAt":"2016-12-27T19:36:25Z","lastAt":"2016-12-27T19:36:32Z","messageCount":3,"participants":["Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"308411","messageId":"20161227193605.12413-1-sbeller@google.com","threadId":"44774","inReplyTo":null,"subject":"[PATCH 0/2] submodule config test cleanup","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-12-27T19:36:03Z","receivedAt":"2016-12-27T19:36:25Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"A test cleanup and an additional test for the submodule configuration.\n\nStefan Beller (2):\n  t7411: quote URLs\n  t7411: test lookup of uninitialized submodules\n\n t/t7411-submodule-config.sh | 25 +++++++++++++++++++++++--\n 1 file changed, 23 insertions(+), 2 deletions(-)\n\n-- \n2.11.0.rc2.50.g8bda6b2.dirty\n\n"},{"id":"308412","messageId":"20161227193605.12413-2-sbeller@google.com","threadId":"44774","inReplyTo":"20161227193605.12413-1-sbeller@google.com","subject":"[PATCH 1/2] t7411: quote URLs","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-12-27T19:36:04Z","receivedAt":"2016-12-27T19:36:28Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"The variables may contain white spaces, so we need to quote them.\nBy not quoting the variables we'd end up passing multiple arguments to\ngit config, which doesn't fail for two arguments as value.\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n t/t7411-submodule-config.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t7411-submodule-config.sh b/t/t7411-submodule-config.sh\nindex 47562ce465..3646f28b40 100755\n--- a/t/t7411-submodule-config.sh\n+++ b/t/t7411-submodule-config.sh\n@@ -120,8 +120,8 @@ test_expect_success 'reading of local configuration' '\n \t\t\t\"\" submodule \\\n \t\t\t\t>actual &&\n \t\ttest_cmp expect_local_path actual &&\n-\t\tgit config submodule.a.url $old_a &&\n-\t\tgit config submodule.submodule.url $old_submodule &&\n+\t\tgit config submodule.a.url \"$old_a\" &&\n+\t\tgit config submodule.submodule.url \"$old_submodule\" &&\n \t\tgit config --unset submodule.a.path c\n \t)\n '\n-- \n2.11.0.rc2.50.g8bda6b2.dirty\n\n"},{"id":"308413","messageId":"20161227193605.12413-3-sbeller@google.com","threadId":"44774","inReplyTo":"20161227193605.12413-1-sbeller@google.com","subject":"[PATCH 2/2] t7411: test lookup of uninitialized submodules","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-12-27T19:36:05Z","receivedAt":"2016-12-27T19:36:32Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Sometimes we need to lookup information of uninitialized submodules. Make\nsure that works.\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n t/t7411-submodule-config.sh | 21 +++++++++++++++++++++\n 1 file changed, 21 insertions(+)\n\ndiff --git a/t/t7411-submodule-config.sh b/t/t7411-submodule-config.sh\nindex 3646f28b40..b40df6a4c1 100755\n--- a/t/t7411-submodule-config.sh\n+++ b/t/t7411-submodule-config.sh\n@@ -126,6 +126,27 @@ test_expect_success 'reading of local configuration' '\n \t)\n '\n \n+cat >super/expect_url <<EOF\n+Submodule url: '../submodule' for path 'b'\n+Submodule url: 'git@somewhere.else.net:submodule.git' for path 'submodule'\n+EOF\n+\n+test_expect_success 'reading of local configuration for uninitialized submodules' '\n+\t(\n+\t\tcd super &&\n+\t\tgit submodule deinit -f b &&\n+\t\told_submodule=$(git config submodule.submodule.url) &&\n+\t\tgit config submodule.submodule.url git@somewhere.else.net:submodule.git &&\n+\t\ttest-submodule-config --url \\\n+\t\t\t\"\" b \\\n+\t\t\t\"\" submodule \\\n+\t\t\t\t>actual &&\n+\t\ttest_cmp expect_url actual &&\n+\t\tgit config submodule.submodule.url \"$old_submodule\" &&\n+\t\tgit submodule init b\n+\t)\n+'\n+\n cat >super/expect_fetchrecurse_die.err <<EOF\n fatal: bad submodule.submodule.fetchrecursesubmodules argument: blabla\n EOF\n-- \n2.11.0.rc2.50.g8bda6b2.dirty\n\n"}]}