{"thread":{"id":"44613","subject":"[PATCH] Completion: Add support for --submodule=diff","startedAt":"2016-12-04T14:41:53Z","lastAt":"2017-02-06T22:56:35Z","messageCount":6,"participants":["peterjclaw@gmail.com","Peter Law","Brandon Williams","Junio C Hamano","Jacob Keller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"306894","messageId":"20161204144127.28452-1-peterjclaw@gmail.com","threadId":"44613","inReplyTo":null,"subject":"[PATCH] Completion: Add support for --submodule=diff","fromName":"","fromEmail":"peterjclaw@gmail.com","sentAt":"2016-12-04T14:41:27Z","receivedAt":"2016-12-04T14:41:53Z","isPatch":true,"sender":{"key":"peterjclaw@gmail.com","avatar":"https://avatars.githubusercontent.com/u/336212?v=4"},"body":"From: Peter Law \n\nTeach git-completion.bash about the 'diff' option to 'git diff\n--submodule=', which was added in Git 2.11.\n\nSigned-off-by: Peter Law \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 21016bf8d..ab11e7371 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1206,7 +1206,7 @@ _git_describe ()\n \n __git_diff_algorithms=\"myers minimal patience histogram\"\n \n-__git_diff_submodule_formats=\"log short\"\n+__git_diff_submodule_formats=\"diff log short\"\n \n __git_diff_common_options=\"--stat --numstat --shortstat --summary\n \t\t\t--patch-with-stat --name-only --name-status --color\n-- \n2.11.0\n\n"},{"id":"310560","messageId":"CAKoneT+Bn+MdbeNnPJsu23rbLCZ=jxADNVtpNefw9zNYMq26dA@mail.gmail.com","threadId":"44613","inReplyTo":"20161204144127.28452-1-peterjclaw@gmail.com","subject":"Re: [PATCH] Completion: Add support for --submodule=diff","fromName":"Peter Law","fromEmail":"peterjclaw@gmail.com","sentAt":"2017-01-30T21:13:37Z","receivedAt":"2017-01-30T21:14:06Z","isPatch":true,"sender":{"key":"peterjclaw@gmail.com","avatar":"https://avatars.githubusercontent.com/u/336212?v=4"},"body":"Hi,\n\n> Teach git-completion.bash about the 'diff' option to 'git diff\n> --submodule=', which was added in Git 2.11.\n\nI posted this patch back in December, but I've not heard anything. I'm\nsure as maintainers you're all quite busy, but I was wondering how\nlong it usually takes to get a response to patches? (also whether I'd\ngotten some part of the submission process wrong?)\n\nThanks,\nPeter\n"},{"id":"310562","messageId":"20170130214312.GB35626@google.com","threadId":"44613","inReplyTo":"CAKoneT+Bn+MdbeNnPJsu23rbLCZ=jxADNVtpNefw9zNYMq26dA@mail.gmail.com","subject":"Re: [PATCH] Completion: Add support for --submodule=diff","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-01-30T21:43:12Z","receivedAt":"2017-01-30T21:43:48Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 01/30, Peter Law wrote:\n> Hi,\n> \n> > Teach git-completion.bash about the 'diff' option to 'git diff\n> > --submodule=', which was added in Git 2.11.\n> \n> I posted this patch back in December, but I've not heard anything. I'm\n> sure as maintainers you're all quite busy, but I was wondering how\n> long it usually takes to get a response to patches? (also whether I'd\n> gotten some part of the submission process wrong?)\n> \n> Thanks,\n> Peter\n\nIt looks like this must have just fallen through the cracks. Your patch\nlooks good to me and works when I test it locally.\n\n-- \nBrandon Williams\n"},{"id":"310573","messageId":"xmqq4m0gtakk.fsf@gitster.mtv.corp.google.com","threadId":"44613","inReplyTo":"CAKoneT+Bn+MdbeNnPJsu23rbLCZ=jxADNVtpNefw9zNYMq26dA@mail.gmail.com","subject":"Re: [PATCH] Completion: Add support for --submodule=diff","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-30T23:03:23Z","receivedAt":"2017-01-30T23:04:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Peter Law writes:\n\n>> Teach git-completion.bash about the 'diff' option to 'git diff\n>> --submodule=', which was added in Git 2.11.\n>\n> I posted this patch back in December, but I've not heard anything. I'm\n> sure as maintainers you're all quite busy, but I was wondering how\n> long it usually takes to get a response to patches? (also whether I'd\n> gotten some part of the submission process wrong?)\n\nWhen there is clear \"subsystem maintainer(s)\" in the area, I try to\nrefrain from commenting until they speak up, and completion scripts\nare one of these areas. I usually ping them after a few days but in\nDecember with holidays and things people are usually slow, and so\nwas I X-<.\n\nWill pick it up. Thanks for a reminder; you absolutely did the\nright thing (i.e. sending it out with people who are likely to know\nabout the area CC'ed, waiting for a while and then sending a\nreminder).\n\n\n"},{"id":"310580","messageId":"CA+P7+xqYGigV=8k_vS+4Y5fS2ORHUjYOnNRsAGYb1BwCx13xzg@mail.gmail.com","threadId":"44613","inReplyTo":"20161204144127.28452-1-peterjclaw@gmail.com","subject":"Re: [PATCH] Completion: Add support for --submodule=diff","fromName":"Jacob Keller","fromEmail":"jacob.keller@gmail.com","sentAt":"2017-01-31T00:10:04Z","receivedAt":"2017-01-31T00:17:34Z","isPatch":true,"sender":{"key":"jacob.keller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/874719?v=4"},"body":"On Sun, Dec 4, 2016 at 6:41 AM, wrote:\n> From: Peter Law \n>\n> Teach git-completion.bash about the 'diff' option to 'git diff\n> --submodule=', which was added in Git 2.11.\n>\n> Signed-off-by: Peter Law \n> ---\n> contrib/completion/git-completion.bash | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 21016bf8d..ab11e7371 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1206,7 +1206,7 @@ _git_describe ()\n>\n> __git_diff_algorithms=\"myers minimal patience histogram\"\n>\n> -__git_diff_submodule_formats=\"log short\"\n> +__git_diff_submodule_formats=\"diff log short\"\n>\n> __git_diff_common_options=\"--stat --numstat --shortstat --summary\n> --patch-with-stat --name-only --name-status --color\n> --\n> 2.11.0\n>\n\nYep, this looks good to me.\n\nThanks,\nJake\n"},{"id":"310952","messageId":"CAKoneTL3-1ohv22mm-RpZ-2sNbFeAV62wOS-JoE0r2Dcn_2E3A@mail.gmail.com","threadId":"44613","inReplyTo":"xmqq4m0gtakk.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Completion: Add support for --submodule=diff","fromName":"Peter Law","fromEmail":"peterjclaw@gmail.com","sentAt":"2017-02-06T22:56:09Z","receivedAt":"2017-02-06T22:56:35Z","isPatch":true,"sender":{"key":"peterjclaw@gmail.com","avatar":"https://avatars.githubusercontent.com/u/336212?v=4"},"body":"Hi,\n\nJunio C Hamano wrote:\n> Peter Law writes:\n>\n>>> Teach git-completion.bash about the 'diff' option to 'git diff\n>>> --submodule=', which was added in Git 2.11.\n>>\n>> I posted this patch back in December, but I've not heard anything. I'm\n>> sure as maintainers you're all quite busy, but I was wondering how\n>> long it usually takes to get a response to patches? (also whether I'd\n>> gotten some part of the submission process wrong?)\n>\n> When there is clear \"subsystem maintainer(s)\" in the area, I try to\n> refrain from commenting until they speak up, and completion scripts\n> are one of these areas. I usually ping them after a few days but in\n> December with holidays and things people are usually slow, and so\n> was I X-<.\n>\n> Will pick it up. Thanks for a reminder; you absolutely did the\n> right thing (i.e. sending it out with people who are likely to know\n> about the area CC'ed, waiting for a while and then sending a\n> reminder).\n\nAwesome, many thanks!\n\nPeter\n"}]}