{"thread":{"id":"44598","subject":"[PATCH] worktree: mark a file-local symbol with static","startedAt":"2016-12-02T20:56:55Z","lastAt":"2016-12-02T21:59:48Z","messageCount":2,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"306814","messageId":"0be15cd5-4ecb-3d87-93ee-d34d2be2d4c6@ramsayjones.plus.com","threadId":"44598","inReplyTo":null,"subject":"[PATCH] worktree: mark a file-local symbol with static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-12-02T20:55:25Z","receivedAt":"2016-12-02T20:56:55Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll your 'sb/submodule-intern-gitdir'\nbranch, could you please squash something similar to this\ninto the relevant patch (commit 2529715dc, \"worktree: get\nworktrees from submodules\", 01-12-2016).\n\n[This is based on pu; ie. on top of merge 86c7f863a, where\nJunio as added the 'flags' parameter.]\n\nThanks!\n\nATB,\nRamsay Jones\n\n worktree.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/worktree.c b/worktree.c\nindex d5c71095e..ba393fe5c 100644\n--- a/worktree.c\n+++ b/worktree.c\n@@ -168,7 +168,7 @@ static int compare_worktree(const void *a_, const void *b_)\n \treturn fspathcmp((*a)->path, (*b)->path);\n }\n \n-struct worktree **get_worktrees_internal(const char *git_common_dir, unsigned flags)\n+static struct worktree **get_worktrees_internal(const char *git_common_dir, unsigned flags)\n {\n \tstruct worktree **list = NULL;\n \tstruct strbuf path = STRBUF_INIT;\n-- \n2.11.0\n"},{"id":"306820","messageId":"CAGZ79kaXeFOL0k1tqPxk76XLrkRH_ApZPC7V=kKK3xN=mPbxJQ@mail.gmail.com","threadId":"44598","inReplyTo":"0be15cd5-4ecb-3d87-93ee-d34d2be2d4c6@ramsayjones.plus.com","subject":"Re: [PATCH] worktree: mark a file-local symbol with static","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-12-02T21:58:39Z","receivedAt":"2016-12-02T21:59:48Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Fri, Dec 2, 2016 at 12:55 PM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll your 'sb/submodule-intern-gitdir'\n> branch,\n\nI will need to reroll it.\n\n> could you please squash something similar to this\n> into the relevant patch (commit 2529715dc, \"worktree: get\n> worktrees from submodules\", 01-12-2016).\n>\n> [This is based on pu; ie. on top of merge 86c7f863a, where\n> Junio as added the 'flags' parameter.]\n\nOh, ok. I may just reroll the series on top of nd/worktree-list-fixup\n\nThanks for the annotation!\nStefan\n"}]}