{"thread":{"id":"44500","subject":"[PATCH] git-gui: Sort entries in optimized tclIndex","startedAt":"2016-11-16T21:51:25Z","lastAt":"2016-11-16T21:51:25Z","messageCount":1,"participants":["Anders Kaseorg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"306083","messageId":"alpine.DEB.2.10.1611161643170.835@buzzword-bingo.mit.edu","threadId":"44500","inReplyTo":null,"subject":"[PATCH] git-gui: Sort entries in optimized tclIndex","fromName":"Anders Kaseorg","fromEmail":"andersk@mit.edu","sentAt":"2016-11-16T21:46:06Z","receivedAt":"2016-11-16T21:51:25Z","isPatch":true,"sender":{"key":"andersk@mit.edu","avatar":"https://avatars.githubusercontent.com/u/26471?v=4"},"body":"auto_mkindex expands wildcards in directory order, which depends on\nthe underlying filesystem.  To improve build reproducibility, sort the\nlist of *.tcl files in the Makefile.\n\nThe unoptimized loading case (7 lines below) was previously fixed in\nv2.11.0-rc0~31^2^2~14 “git-gui: sort entries in tclIndex”.\n\nSigned-off-by: Anders Kaseorg <andersk@mit.edu>\n---\n git-gui/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex fe30be38d..f94b3e13d 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -252,7 +252,7 @@ $(ALL_MSGFILES): %.msg : %.po\n lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n \t$(QUIET_INDEX)if echo \\\n \t  $(foreach p,$(PRELOAD_FILES),source $p\\;) \\\n-\t  auto_mkindex lib '*.tcl' \\\n+\t  auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \\\n \t| $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \\\n \telse \\\n \t echo >&2 \"    * $(TCL_PATH) failed; using unoptimized loading\"; \\\n-- \n2.11.0.rc0\n\n"}]}