{"thread":{"id":"44477","subject":"[PATCH] attr: mark a file-local symbol as static","startedAt":"2016-11-13T16:42:24Z","lastAt":"2016-11-14T20:00:30Z","messageCount":2,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"305876","messageId":"83508d1f-e809-f6be-5afc-4c23195dbd08@ramsayjones.plus.com","threadId":"44477","inReplyTo":null,"subject":"[PATCH] attr: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-11-13T16:42:13Z","receivedAt":"2016-11-13T16:42:24Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll your 'sb/attr' branch, could you please\nsquash this into the relevant patch.\n\nAlternatively, since there is only a single call site for git_attr()\n(on line #1005), you could perhaps remove git_attr() and inline that\ncall. (However, that does make that line exceed 80 columns).\n\nThanks!\n\nATB,\nRamsay Jones\n\n attr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/attr.c b/attr.c\nindex 667ba85..84c4b08 100644\n--- a/attr.c\n+++ b/attr.c\n@@ -169,7 +169,7 @@ static struct git_attr *git_attr_internal(const char *name, int len)\n \treturn a;\n }\n \n-struct git_attr *git_attr(const char *name)\n+static struct git_attr *git_attr(const char *name)\n {\n \treturn git_attr_internal(name, strlen(name));\n }\n-- \n2.10.0\n"},{"id":"305916","messageId":"CAGZ79kaDK3syiNKvAKQf8q6AtcoXZuFz8fvxGZTj2Ced+Hu3Pg@mail.gmail.com","threadId":"44477","inReplyTo":"83508d1f-e809-f6be-5afc-4c23195dbd08@ramsayjones.plus.com","subject":"Re: [PATCH] attr: mark a file-local symbol as static","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-11-14T20:00:23Z","receivedAt":"2016-11-14T20:00:30Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Sun, Nov 13, 2016 at 8:42 AM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll your 'sb/attr' branch, could you please\n> squash this into the relevant patch.\n\nwill do. I have it applied locally\n\n>\n> Alternatively, since there is only a single call site for git_attr()\n> (on line #1005), you could perhaps remove git_attr() and inline that\n> call. (However, that does make that line exceed 80 columns).\n\nI'll look into that.\n\nThanks,\nStefan\n\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n>\n>  attr.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/attr.c b/attr.c\n> index 667ba85..84c4b08 100644\n> --- a/attr.c\n> +++ b/attr.c\n> @@ -169,7 +169,7 @@ static struct git_attr *git_attr_internal(const char *name, int len)\n>         return a;\n>  }\n>\n> -struct git_attr *git_attr(const char *name)\n> +static struct git_attr *git_attr(const char *name)\n>  {\n>         return git_attr_internal(name, strlen(name));\n>  }\n> --\n> 2.10.0\n"}]}