{"thread":{"id":"44389","subject":"[PATCH] Fix typo in 2.11.0 RelNotes","startedAt":"2016-10-28T11:15:04Z","lastAt":"2016-10-28T15:33:12Z","messageCount":3,"participants":["Henrik Ahlgren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"305055","messageId":"1477651639-11529-1-git-send-email-pablo@seestieto.com","threadId":"44389","inReplyTo":null,"subject":"[PATCH] Fix typo in 2.11.0 RelNotes","fromName":"Henrik Ahlgren","fromEmail":"pablo@seestieto.com","sentAt":"2016-10-28T10:47:19Z","receivedAt":"2016-10-28T11:15:04Z","isPatch":true,"sender":{"key":"pablo@seestieto.com","avatar":null},"body":"Signed-off-by: Henrik Ahlgren <pablo@seestieto.com>\n---\n Documentation/RelNotes/2.11.0.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/RelNotes/2.11.0.txt b/Documentation/RelNotes/2.11.0.txt\nindex 3590620..1d3a07d 100644\n--- a/Documentation/RelNotes/2.11.0.txt\n+++ b/Documentation/RelNotes/2.11.0.txt\n@@ -5,7 +5,7 @@ Backward compatibility notes.\n \n  * An empty string used as a pathspec element has always meant\n    'everything matches', but it is too easy to write a script that\n-   finds a path to remove in $path and run 'git rm \"$paht\"', which\n+   finds a path to remove in $path and run 'git rm \"$path\"', which\n    ends up removing everything.  This release starts warning about the\n    use of an empty string that is used for 'everything matches' and\n    asks users to use a more explicit '.' for that instead.\n-- \n2.1.4\n\n"},{"id":"305058","messageId":"xmqqoa2439sp.fsf@gitster.mtv.corp.google.com","threadId":"44389","inReplyTo":"1477651639-11529-1-git-send-email-pablo@seestieto.com","subject":"Re: [PATCH] Fix typo in 2.11.0 RelNotes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-10-28T13:03:34Z","receivedAt":"2016-10-28T13:03:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Henrik Ahlgren <pablo@seestieto.com> writes:\n\n> Signed-off-by: Henrik Ahlgren <pablo@seestieto.com>\n> ---\n>  Documentation/RelNotes/2.11.0.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/RelNotes/2.11.0.txt b/Documentation/RelNotes/2.11.0.txt\n> index 3590620..1d3a07d 100644\n> --- a/Documentation/RelNotes/2.11.0.txt\n> +++ b/Documentation/RelNotes/2.11.0.txt\n> @@ -5,7 +5,7 @@ Backward compatibility notes.\n>  \n>   * An empty string used as a pathspec element has always meant\n>     'everything matches', but it is too easy to write a script that\n> -   finds a path to remove in $path and run 'git rm \"$paht\"', which\n> +   finds a path to remove in $path and run 'git rm \"$path\"', which\n>     ends up removing everything.  This release starts warning about the\n>     use of an empty string that is used for 'everything matches' and\n>     asks users to use a more explicit '.' for that instead.\n\nWhat you spotted is certainly a typo, but it is a deliberate one\nthat must not be fixed like this.  \"..., but it is too easy to ...\"\nis illustrating a scenario in which an empty string is accidentally\ngiven to \"git rm\" as a pathspec by mistake, and the example it uses\nis for the user to prepare a path to be removed in variable $path,\nand referring to it as its typoed $paht by mistake.  Fixing that typo\nin this paragraph defeats the whole point of the example.\n\nBut the fact that you spotted the typo (which is good; we want the\ndeliberate typo in the example to be clearly visible) and thought\nthat the writer of the paragraph must have meant a non-typoed\nversion there (which is bad) indicates that the paragraph needs\nimprovement to save readers from making the same mis-reading as you\ndid.\n\nIf the original text were like the following, would it have been\nclear enough that prevented you from sending your patch?\n\n * An empty string used as a pathspec element has always meant\n   'everything matches', but it is too easy to write a script that\n   finds a path to remove in $path and run 'git rm \"$paht\"' by \n   mistake (when the user meant to give \"$path\"), which ends up\n   removing everything.  This release starts warning about the\n   use of an empty string that is used for 'everything matches' and\n   asks users to use a more explicit '.' for that instead.\n\nThanks.\n"},{"id":"305065","messageId":"1477668782.1869.4.camel@seestieto.com","threadId":"44389","inReplyTo":"xmqqoa2439sp.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Fix typo in 2.11.0 RelNotes","fromName":"Henrik Ahlgren","fromEmail":"pablo@seestieto.com","sentAt":"2016-10-28T15:33:02Z","receivedAt":"2016-10-28T15:33:12Z","isPatch":true,"sender":{"key":"pablo@seestieto.com","avatar":null},"body":"On Fri, 2016-10-28 at 06:03 -0700, Junio C Hamano wrote:\n\n> If the original text were like the following, would it have been\n> clear enough that prevented you from sending your patch?\n> \n>  * An empty string used as a pathspec element has always meant\n>    'everything matches', but it is too easy to write a script that\n>    finds a path to remove in $path and run 'git rm \"$paht\"' by \n>    mistake (when the user meant to give \"$path\"), which ends up\n>    removing everything.  This release starts warning about the\n>    use of an empty string that is used for 'everything matches' and\n>    asks users to use a more explicit '.' for that instead.\n\nOops. Yes, but not sure if it really needs to be clear enough even for\nidiots like me. :-) Sorry.\n\n\n"}]}