{"thread":{"id":"4438","subject":"[PATCH 1/2]: amendment","startedAt":"2006-06-08T15:22:43Z","lastAt":"2006-06-08T20:11:39Z","messageCount":4,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"21435","messageId":"Pine.LNX.4.63.0606081719400.27335@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4438","inReplyTo":null,"subject":"[PATCH 1/2]: amendment","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-06-08T15:22:43Z","receivedAt":"2006-06-08T15:22:43Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nI completely forgot that with a global config, it makes sense to have \naliases even if we are not in a git repository.\n\nSo, in git.c, handle_alias() the \"if (nongit)\" makes no sense any longer. \nIf I have to revise the patch anyway, I will include the change, but if \nyou decide to take it, please change that.\n\nCiao,\nDscho\n\nP.S.: There might be other users (such as git-peek-remote) who want that \nchange, too.\n"},{"id":"21441","messageId":"7v7j3r8uab.fsf@assigned-by-dhcp.cox.net","threadId":"4438","inReplyTo":"Pine.LNX.4.63.0606081719400.27335@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH 1/2]: amendment","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-08T16:51:56Z","receivedAt":"2006-06-08T16:51:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> I completely forgot that with a global config, it makes sense to have \n> aliases even if we are not in a git repository.\n>\n> So, in git.c, handle_alias() the \"if (nongit)\" makes no sense any longer. \n> If I have to revise the patch anyway, I will include the change, but if \n> you decide to take it, please change that.\n>\n> Ciao,\n> Dscho\n>\n> P.S.: There might be other users (such as git-peek-remote) who want that \n> change, too.\n\nWell, this is pretty late in the 1.4.0 game and honestly I am\npretty reluctant to merge this in, push 1.4.0 out in 48 hours\nand leave for nearly a week.\n\nSo either we would reschedule 1.4.0 and shoot for June 24th, or\ndo 1.4.0 this weekend as planned, and leave this as the first\nitem (perhaps the second, after applying many small clean-ups\nI've privately received, which I haven't acted on other than\nquickly reviewing and asking the submitter to rebase and resend\ncc'ing the list) in the post-1.4.0 development cycle. This\npotentially is a candidate to backport to 1.4.X series.\n\nMy preference is to cook this in \"next\" for a while and merge it\npost 1.4.0.\n"},{"id":"21442","messageId":"7vzmgntwra.fsf@assigned-by-dhcp.cox.net","threadId":"4438","inReplyTo":"Pine.LNX.4.63.0606081719400.27335@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH 1/2]: amendment","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-08T16:52:57Z","receivedAt":"2006-06-08T16:52:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> I completely forgot that with a global config, it makes sense to have \n> aliases even if we are not in a git repository.\n>\n> So, in git.c, handle_alias() the \"if (nongit)\" makes no sense any longer. \n> If I have to revise the patch anyway, I will include the change, but if \n> you decide to take it, please change that.\n>\n> Ciao,\n> Dscho\n>\n> P.S.: There might be other users (such as git-peek-remote) who want that \n> change, too.\n\nWell, this is pretty late in the 1.4.0 game and honestly I am\npretty reluctant to merge this in, push 1.4.0 out in 48 hours\nand leave for nearly a week.\n\nSo either we would reschedule 1.4.0 and shoot for June 24th, or\ndo 1.4.0 this weekend as planned, and leave this as the first\nitem (perhaps the second, after applying many small clean-ups\nI've privately received, which I haven't acted on other than\nquickly reviewing and asking the submitter to rebase and resend\ncc'ing the list) in the post-1.4.0 development cycle. This\npotentially is a candidate to backport to 1.4.X series.\n\nMy preference is to cook this in \"next\" for a while and merge it\npost 1.4.0.\n"},{"id":"21448","messageId":"Pine.LNX.4.63.0606082209380.28323@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4438","inReplyTo":"7v7j3r8uab.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/2]: amendment","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-06-08T20:11:39Z","receivedAt":"2006-06-08T20:11:39Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Thu, 8 Jun 2006, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > I completely forgot that with a global config, it makes sense to have \n> > aliases even if we are not in a git repository.\n> >\n> > So, in git.c, handle_alias() the \"if (nongit)\" makes no sense any longer. \n> > If I have to revise the patch anyway, I will include the change, but if \n> > you decide to take it, please change that.\n> >\n> > Ciao,\n> > Dscho\n> >\n> > P.S.: There might be other users (such as git-peek-remote) who want that \n> > change, too.\n> \n> Well, this is pretty late in the 1.4.0 game and honestly I am\n> pretty reluctant to merge this in, push 1.4.0 out in 48 hours\n> and leave for nearly a week.\n\nSorry, I timed that rather badly.\n\n> My preference is to cook this in \"next\" for a while and merge it\n> post 1.4.0.\n\nJudging from the flurry of creative flag naming wishes, I think that will \ndo just fine.\n\nCiao,\nDscho\n"}]}