{"thread":{"id":"44347","subject":"t9000-addresses.sh: unexpected pases","startedAt":"2016-10-21T00:24:57Z","lastAt":"2016-10-21T18:44:53Z","messageCount":6,"participants":["Ramsay Jones","Junio C Hamano","Matthieu Moy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"304551","messageId":"3e9bfa01-d69c-05c1-e24e-960a3add2551@ramsayjones.plus.com","threadId":"44347","inReplyTo":null,"subject":"t9000-addresses.sh: unexpected pases","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-10-21T00:24:48Z","receivedAt":"2016-10-21T00:24:57Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Matthieu,\n\nI have started seeing unexpected passes in this test (am I the\nonly one?) on the next and pu branch, which seems to be caused\nby commit e3fdbcc8 (\"parse_mailboxes: accept extra text after\n<...> address\", 13-10-2016). Thus:\n\n $ tail -15 ntest-out\n [15:17:44]\n All tests successful.\n\n Test Summary Report\n -------------------\n t9000-addresses.sh (Wstat: 0 Tests: 37 Failed: 0)\n TODO passed: 28, 30-31\n Files=760, Tests=13940, 484 wallclock secs ( 4.04 usr 1.30 sys + 60.52 cusr 36.76 csys = 102.62 CPU)\n Result: PASS\n make clean-except-prove-cache\n make[2]: Entering directory '/home/ramsay/git/t'\n rm -f -r 'trash directory'.* 'test-results'\n rm -f -r valgrind/bin\n make[2]: Leaving directory '/home/ramsay/git/t'\n make[1]: Leaving directory '/home/ramsay/git/t'\n $ \n\nI have not even looked, but I suspect that it simply requires\na change from expect_fail to expect_success, since your commit\nhas 'fixed' these tests ... would you mind taking a quick look?\n\nThanks!\n\nATB,\nRamsay Jones\n\n"},{"id":"304555","messageId":"xmqq1szaeda9.fsf@gitster.mtv.corp.google.com","threadId":"44347","inReplyTo":"3e9bfa01-d69c-05c1-e24e-960a3add2551@ramsayjones.plus.com","subject":"Re: t9000-addresses.sh: unexpected pases","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-10-21T00:50:06Z","receivedAt":"2016-10-21T00:50:15Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n> I have started seeing unexpected passes in this test (am I the\n> only one?) on the next and pu branch, which seems to be caused\n> by commit e3fdbcc8 (\"parse_mailboxes: accept extra text after\n> <...> address\", 13-10-2016). Thus:\n>\n> $ tail -15 ntest-out\n> [15:17:44]\n> All tests successful.\n>\n> Test Summary Report\n> -------------------\n> t9000-addresses.sh (Wstat: 0 Tests: 37 Failed: 0)\n> TODO passed: 28, 30-31\n\nYeah, I noticed this in some of my integration runs but didn't pay\nattention and forgot about it; thanks for bringing it up.\n\n"},{"id":"304564","messageId":"20161021092024.15861-1-Matthieu.Moy@imag.fr","threadId":"44347","inReplyTo":"xmqq1szaeda9.fsf@gitster.mtv.corp.google.com","subject":"[PATCH 1/2] t9000-addresses: update expected results after fix","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2016-10-21T09:20:23Z","receivedAt":"2016-10-21T09:21:10Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"e3fdbcc8e1 (parse_mailboxes: accept extra text after <...> address,\n2016-10-13) improved our in-house address parser and made it closer to\nMail::Address. As a consequence, some tests comparing it to\nMail::Address now pass, but e3fdbcc8e1 forgot to update the test.\n\nSigned-off-by: Matthieu Moy \n---\n t/t9000/test.pl | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t9000/test.pl b/t/t9000/test.pl\nindex 2d05d3eeab..dfeaa9c655 100755\n--- a/t/t9000/test.pl\n+++ b/t/t9000/test.pl\n@@ -32,15 +32,15 @@ my @success_list = (q[Jane],\n \tq[\"Jane\\\" Doe\" ],\n \tq[Doe, jane ],\n \tq[\"Jane Doe ],\n-\tq['Jane 'Doe' ]);\n+\tq['Jane 'Doe' ],\n+\tq[Jane@:;\\.,()<>Doe ],\n+\tq[Jane Doe],\n+\tq[ Jane Doe]);\n \n my @known_failure_list = (q[Jane\\ Doe ],\n \tq[\"Doe, Ja\"ne ],\n \tq[\"Doe, Katarina\" Jane ],\n-\tq[Jane@:;\\.,()<>Doe ],\n \tq[Jane jdoe@example.com],\n-\tq[ Jane Doe],\n-\tq[Jane Doe],\n \tq[\"Jane \"Kat\"a\" ri\"na\" \",Doe\" ],\n \tq[Jane Doe],\n \tq[Jane \"Doe \"],\n-- \n2.10.1.651.gffd0de0\n\n"},{"id":"304565","messageId":"20161021092024.15861-2-Matthieu.Moy@imag.fr","threadId":"44347","inReplyTo":"20161021092024.15861-1-Matthieu.Moy@imag.fr","subject":"[PATCH 2/2] Git.pm: add comment pointing to t9000","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2016-10-21T09:20:24Z","receivedAt":"2016-10-21T09:34:46Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"parse_mailboxes should probably eventually be completely equivalent to\nMail::Address, and if this happens we can drop the Mail::Address\ndependency. Add a comment in the code reminding the current state of the\ncode, and point to the corresponding failing test to help future\ncontributors to get it right.\n\nSigned-off-by: Matthieu Moy \n---\n perl/Git.pm | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex 42e0895ef7..8bb2b7c7e3 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -870,6 +870,8 @@ Return an array of mailboxes extracted from a string.\n \n =cut\n \n+# Very close to Mail::Address's parser, but we still have minor\n+# differences in some cases (see t9000 for examples).\n sub parse_mailboxes {\n \tmy $re_comment = qr/\\((?:[^)]*)\\)/;\n \tmy $re_quote = qr/\"(?:[^\\\"\\\\]|\\\\.)*\"/;\n-- \n2.10.1.651.gffd0de0\n\n"},{"id":"304620","messageId":"xmqqh985d4x7.fsf@gitster.mtv.corp.google.com","threadId":"44347","inReplyTo":"20161021092024.15861-1-Matthieu.Moy@imag.fr","subject":"Re: [PATCH 1/2] t9000-addresses: update expected results after fix","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-10-21T16:48:20Z","receivedAt":"2016-10-21T16:48:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> e3fdbcc8e1 (parse_mailboxes: accept extra text after <...> address,\n> 2016-10-13) improved our in-house address parser and made it closer to\n> Mail::Address. As a consequence, some tests comparing it to\n> Mail::Address now pass, but e3fdbcc8e1 forgot to update the test.\n>\n> Signed-off-by: Matthieu Moy \n> ---\n\nThanks.\n"},{"id":"304639","messageId":"3aa70781-e930-c7a9-c106-0268f82f6a5d@ramsayjones.plus.com","threadId":"44347","inReplyTo":"xmqqh985d4x7.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 1/2] t9000-addresses: update expected results after fix","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-10-21T18:44:44Z","receivedAt":"2016-10-21T18:44:53Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 21/10/16 17:48, Junio C Hamano wrote:\n> Matthieu Moy writes:\n> \n>> e3fdbcc8e1 (parse_mailboxes: accept extra text after <...> address,\n>> 2016-10-13) improved our in-house address parser and made it closer to\n>> Mail::Address. As a consequence, some tests comparing it to\n>> Mail::Address now pass, but e3fdbcc8e1 forgot to update the test.\n>>\n>> Signed-off-by: Matthieu Moy \n>> ---\n> \n> Thanks.\n\nYep, thanks for looking into this Matthieu.\n\nI applied these cleanly (to both next and pu) and tested\non Linux and cygwin.\n\nThanks again.\n\nATB,\nRamsay Jones\n\n\n"}]}