{"thread":{"id":"443","subject":"Re: [PATCH] add git.spec and adapt Makefile for RPM build","startedAt":"2005-05-02T18:58:04Z","lastAt":"2005-09-18T17:32:29Z","messageCount":8,"participants":["Horst von Brand","Paul Jakma","Chris Wright"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"2388","messageId":"200505021858.j42Iw4M1029427@laptop11.inf.utfsm.cl","threadId":"443","inReplyTo":"chrisw@osdl.org","subject":"Re: [PATCH] add git.spec and adapt Makefile for RPM build","fromName":"Horst von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2005-05-02T18:58:04Z","receivedAt":"2005-05-02T18:58:04Z","isPatch":true,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"Chris Wright <chrisw@osdl.org> said:\n> * Horst von Brand (vonbrand@inf.utfsm.cl) wrote:\n> > Kay Sievers <kay.sievers@vrfy.org> said:\n> > > On Mon, May 02, 2005 at 12:23:03PM +0200, Kay Sievers wrote:\n\n> > > This version creates the git.spec from a git.spec.in with the version\n> > > number from the Makefile.\n\n> > Please don't. The spec file /controls/ the building of the package, it\n> > can't be generated as part of the build process.\n\n> It certainly can.\n\nYep. Maybe \"can't\" was a bit too strong. \"Should never be\" is right.\n\n>                   It simply means a structured release process.  IOW,\n> the git.spec would be generated for a release tarball.\n\nCome on, you have to fix the spec file for the changelog and version by\nhand anyway, autoconfiscating it doesn't help one iota there.\n\nAnd yes, I've seen quite a few packages autogenerating the spec file. As a\nresult, you /can't/ build the package from pristine sources, you have to\nunpack and configure to get enough for building. For me that just isn't\nacceptable, as it completely misses the point of RPM.\n\n(You can go \"rpmbuild -ta whatever-2.3.1.tar.bz2\" if the tarball is set up\ncorrectly, your idea prevents that).\n-- \nDr. Horst H. von Brand                   User #22616 counter.li.org\nDepartamento de Informatica                     Fono: +56 32 654431\nUniversidad Tecnica Federico Santa Maria              +56 32 654239\nCasilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513\n"},{"id":"2390","messageId":"Pine.LNX.4.62.0505022005200.14200@sheen.jakma.org","threadId":"443","inReplyTo":"200505021858.j42Iw4M1029427@laptop11.inf.utfsm.cl","subject":"Re: [PATCH] add git.spec and adapt Makefile for RPM build","fromName":"Paul Jakma","fromEmail":"paul@clubi.ie","sentAt":"2005-05-02T19:06:50Z","receivedAt":"2005-05-02T19:06:50Z","isPatch":true,"sender":{"key":"paul@clubi.ie","avatar":null},"body":"On Mon, 2 May 2005, Horst von Brand wrote:\n\n> And yes, I've seen quite a few packages autogenerating the spec \n> file. As a result, you /can't/ build the package from pristine \n> sources, you have to unpack and configure to get enough for \n> building. For me that just isn't acceptable, as it completely \n> misses the point of RPM.\n\nI think maybe you're missing the point of what is sometimes known as \na 'make dist' target. (eg in autoconf type build systems).\n\n> (You can go \"rpmbuild -ta whatever-2.3.1.tar.bz2\" if the tarball is set up\n> correctly, your idea prevents that).\n\nThen the tarball wasn't of distributable (ie end-user buildable) \nsource.\n\nregards,\n-- \nPaul Jakma\tpaul@clubi.ie\tpaul@jakma.org\tKey ID: 64A2FF6A\nFortune:\n\"Now this is a totally brain damaged algorithm.  Gag me with a smurfette.\"\n \t\t-- P. Buhr, Computer Science 354\n"},{"id":"2391","messageId":"20050502190852.GH18917@shell0.pdx.osdl.net","threadId":"443","inReplyTo":"200505021858.j42Iw4M1029427@laptop11.inf.utfsm.cl","subject":"Re: [PATCH] add git.spec and adapt Makefile for RPM build","fromName":"Chris Wright","fromEmail":"chrisw@osdl.org","sentAt":"2005-05-02T19:08:52Z","receivedAt":"2005-05-02T19:08:52Z","isPatch":true,"sender":{"key":"chrisw@sous-sol.org","avatar":null},"body":"* Horst von Brand (vonbrand@inf.utfsm.cl) wrote:\n> Chris Wright <chrisw@osdl.org> said:\n> >                   It simply means a structured release process.  IOW,\n> > the git.spec would be generated for a release tarball.\n> \n> Come on, you have to fix the spec file for the changelog and version by\n> hand anyway, autoconfiscating it doesn't help one iota there.\n\nThat's the point, you don't _have_ to do that.\n\n> And yes, I've seen quite a few packages autogenerating the spec file. As a\n> result, you /can't/ build the package from pristine sources, you have to\n> unpack and configure to get enough for building. For me that just isn't\n> acceptable, as it completely misses the point of RPM.\n> \n> (You can go \"rpmbuild -ta whatever-2.3.1.tar.bz2\" if the tarball is set up\n> correctly, your idea prevents that).\n\nYou just place the generated spec file in a release tarball.  IOW, your\n'release' Makefile target depends on foo.spec, and creates a clean release\ntarball with all you need to do an -ta build.\n\nthanks,\n-chris\n"},{"id":"2392","messageId":"Pine.LNX.4.62.0505022012240.14200@sheen.jakma.org","threadId":"443","inReplyTo":"Pine.LNX.4.62.0505022005200.14200@sheen.jakma.org","subject":"Re: [PATCH] add git.spec and adapt Makefile for RPM build","fromName":"Paul Jakma","fromEmail":"paul@clubi.ie","sentAt":"2005-05-02T19:13:27Z","receivedAt":"2005-05-02T19:13:27Z","isPatch":true,"sender":{"key":"paul@clubi.ie","avatar":null},"body":"On Mon, 2 May 2005, Paul Jakma wrote:\n\n> I think maybe you're missing the point of what is sometimes known as a 'make \n> dist' target. (eg in autoconf type build systems).\n\nApologies: /Or/ the project which provided such a tarball missed the \npoint.\n\nregards,\n-- \nPaul Jakma\tpaul@clubi.ie\tpaul@jakma.org\tKey ID: 64A2FF6A\nFortune:\n\"MacDonald has the gift on compressing the largest amount of words into\nthe smallest amount of thoughts.\"\n \t\t-- Winston Churchill\n"},{"id":"2569","messageId":"200505040100.j4410DYJ004595@laptop11.inf.utfsm.cl","threadId":"443","inReplyTo":"chrisw@osdl.org","subject":"Re: [PATCH 0/3] cogito spec file updates","fromName":"Horst von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2005-05-04T01:00:12Z","receivedAt":"2005-05-04T01:00:12Z","isPatch":true,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"Chris Wright <chrisw@osdl.org> said:\n> * Chris Wright (chrisw@osdl.org) wrote:\n> > Here's the outstanding updates for the spec file, up to 0.8-2 which is\n> > the latest on kernel.org.\n> > \n> > \thttp://www.kernel.org/pub/software/scm/cogito/RPMS/\n> \n> What's your method for creating a release tarball?  If it were formalized\n> (i.e. Makefile rule), then it'd be simple to use VERSION to drive the\n> spec file, and it'd only need updating for real content changes (similar\n> to what Kay did).\n\nIn each case you should add a Changelog entry to the spec file. Said entry\nwill probably mention the version anyway. Updating the version by hand\nwhile at it is no big deal, now is it? Probably even less hassle than doing\nit automatically.\n-- \nDr. Horst H. von Brand                   User #22616 counter.li.org\nDepartamento de Informatica                     Fono: +56 32 654431\nUniversidad Tecnica Federico Santa Maria              +56 32 654239\nCasilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513\n\n"},{"id":"8721","messageId":"200509161944.j8GJijY3019186@inti.inf.utfsm.cl","threadId":"443","inReplyTo":"chrisw@osdl.org","subject":"Re: [PATCH] Update cogito.spec.in","fromName":"Horst von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2005-09-16T19:44:45Z","receivedAt":"2005-09-16T19:44:45Z","isPatch":true,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"Chris Wright <chrisw@osdl.org> wrote:\n> * Petr Baudis (pasky@suse.cz) wrote:\n> > Dear diary, on Fri, Sep 16, 2005 at 08:47:24AM CEST, I got a letter\n> > where Chris Wright <chrisw@osdl.org> told me that...\n\n[...]\n\n> > > -BuildRoot:\t%{_tmppath}/%{name}-%{version}-root\n> > > -Prereq: \tsh-utils, diffutils, rsync, rcs, mktemp >= 1.5, git-core >= 0.99.3\n> > > -BuildArchitectures:\tnoarch\n> > > +BuildRoot:\t%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)\n> > > +Requires: \tgit-core >= 0.99.3\n> > > +BuildArch:\tnoarch\n\n> > Why did you remove all the stuff from Requires? They actually are ending\n> > up adding even trivial stuff like less to it in GIT.\n\n> Primary reason is it now requires git, which has those prereqs.\n\nIt might be useful to say so in a comment.\n-- \nDr. Horst H. von Brand                   User #22616 counter.li.org\nDepartamento de Informatica                     Fono: +56 32 654431\nUniversidad Tecnica Federico Santa Maria              +56 32 654239\nCasilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513\n"},{"id":"8725","messageId":"20050916201901.GF7762@shell0.pdx.osdl.net","threadId":"443","inReplyTo":"200509161944.j8GJijY3019186@inti.inf.utfsm.cl","subject":"[PATCH] Update cogito.spec.in","fromName":"Chris Wright","fromEmail":"chrisw@osdl.org","sentAt":"2005-09-16T20:19:01Z","receivedAt":"2005-09-16T20:19:01Z","isPatch":true,"sender":{"key":"chrisw@sous-sol.org","avatar":null},"body":"* Horst von Brand (vonbrand@inf.utfsm.cl) wrote:\n> It might be useful to say so in a comment.\n\nFair point.\n\nthanks,\n-chris\n--\n\nUpdate cogito.spec.in from feedback given during Fedora Extras review.\n\n- update Buildroot to be more specific\n- reduce Requires to git-core only (which must already satisfy the other reqs)\n- drop Vendor\n- use %{_libdir} macro\n\nSigned-off-by: Chris Wright <chrisw@osdl.org>\n---\n\n cogito.spec.in |   18 ++++++++++++------\n 1 files changed, 12 insertions(+), 6 deletions(-)\n\ne0ca49e6c375a68b3e4b3edfff752fef2cf585f6\ndiff --git a/cogito.spec.in b/cogito.spec.in\n--- a/cogito.spec.in\n+++ b/cogito.spec.in\n@@ -1,15 +1,14 @@\n Name: \t\tcogito\n Version: \t@@VERSION@@\n Release: \t1\n-Vendor: \tPetr Baudis <pasky@suse.cz>\n Summary:  \tThe Cogito Version Control System\n License: \tGPL\n Group: \t\tDevelopment/Tools\n URL: \t\thttp://kernel.org/pub/software/scm/cogito/\n Source: \thttp://kernel.org/pub/software/scm/cogito/%{name}-%{version}.tar.gz\n-BuildRoot:\t%{_tmppath}/%{name}-%{version}-root\n-Prereq: \tsh-utils, diffutils, rsync, rcs, mktemp >= 1.5, git-core >= 0.99.3\n-BuildArchitectures:\tnoarch\n+BuildRoot:\t%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)\n+Requires: \tgit-core >= 0.99.3\n+BuildArch:\tnoarch\n \n %description\n Cogito is a version control system layered on top of the git tree history\n@@ -34,11 +33,18 @@ rm -rf $RPM_BUILD_ROOT\n %files\n %defattr(-,root,root)\n %{_bindir}/*\n-%dir /usr/lib/cogito\n-/usr/lib/cogito/*\n+%dir %{_libdir}/cogito\n+%{_libdir}/cogito/*\n %doc README COPYING Documentation/*\n \n %changelog\n+* Thu Sep 15 2005 Chris Wright <chrisw@osdl.org> 0.14.1-1\n+- Update to 0.14.1\n+\n+* Mon Aug 15 2005 Chris Wright <chrisw@osdl.org> 0.13-3\n+- Update Buildroot, Requires and drop Vendor\n+- use %{_libdir}\n+\n * Wed Aug 10 2005 Pavel Roskin <proski@gnu.org> 0.13-1\n - Update summary and description\n - Make architecture-independent\n"},{"id":"8787","messageId":"20050918173229.GR7762@shell0.pdx.osdl.net","threadId":"443","inReplyTo":"20050917214807.GA3590@pasky.or.cz","subject":"[PATCH] cogito: Fix rpm build for 64bit platforms","fromName":"Chris Wright","fromEmail":"chrisw@osdl.org","sentAt":"2005-09-18T17:32:29Z","receivedAt":"2005-09-18T17:32:29Z","isPatch":true,"sender":{"key":"chrisw@sous-sol.org","avatar":null},"body":"When building last update on 64bit machine, I realized the _libdir\nchange breaks the rpm build there.  This fixes up the issue by ensuring\nthe libdir %install target is same as %files target.\n\nSigned-off-by: Chris Wright <chrisw@osdl.org>\n---\n cogito.spec.in |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/cogito.spec.in b/cogito.spec.in\n--- a/cogito.spec.in\n+++ b/cogito.spec.in\n@@ -25,7 +25,7 @@ make\n \n %install\n rm -rf $RPM_BUILD_ROOT\n-make DESTDIR=$RPM_BUILD_ROOT prefix=%{_prefix} install\n+make DESTDIR=$RPM_BUILD_ROOT prefix=%{_prefix} libdir=%{_libdir}/cogito install\n \n %clean\n rm -rf $RPM_BUILD_ROOT\n@@ -38,6 +38,9 @@ rm -rf $RPM_BUILD_ROOT\n %doc README COPYING Documentation/*\n \n %changelog\n+* Fri Sep 16 2005 Chris Wright <chrisw@osdl.org> 0.14.1-2\n+- fix _libdir breakage on 64-bit, the irony...\n+\n * Thu Sep 15 2005 Chris Wright <chrisw@osdl.org> 0.14.1-1\n - Update to 0.14.1\n \n"}]}