{"thread":{"id":"44294","subject":"[GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation","startedAt":"2016-10-13T18:44:43Z","lastAt":"2016-10-14T00:48:27Z","messageCount":2,"participants":["Alexander Shopov","Pat Thoyts"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"304089","messageId":"20161013184349.42950-1-ash@kambanaria.org","threadId":"44294","inReplyTo":null,"subject":"[GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation","fromName":"Alexander Shopov","fromEmail":"ash@kambanaria.org","sentAt":"2016-10-13T18:43:48Z","receivedAt":"2016-10-13T18:44:43Z","isPatch":false,"sender":{"key":"ash@kambanaria.org","avatar":"https://avatars.githubusercontent.com/u/449359?v=4"},"body":"Signed-off-by: Alexander Shopov <ash@kambanaria.org>\n---\n lib/remote.tcl | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/lib/remote.tcl b/lib/remote.tcl\nindex 4e5c784..26af8ae 100644\n--- a/lib/remote.tcl\n+++ b/lib/remote.tcl\n@@ -250,12 +250,12 @@ proc update_all_remotes_menu_entry {} {\n \n \t\t\t$fetch_m insert end separator\n \t\t\t$fetch_m insert end command \\\n-\t\t\t\t-label \"All\" \\\n+\t\t\t    -label [mc \"All\"] \\\n \t\t\t\t-command fetch_from_all\n \n \t\t\t$prune_m insert end separator\n \t\t\t$prune_m insert end command \\\n-\t\t\t\t-label \"All\" \\\n+\t\t\t    -label [mc \"All\" ]\\\n \t\t\t\t-command prune_from_all\n \t\t}\n \t} else {\n-- \n2.10.1\n\n"},{"id":"304097","messageId":"87a8e73ggb.fsf@red.patthoyts.tk","threadId":"44294","inReplyTo":"20161013184349.42950-1-ash@kambanaria.org","subject":"Re: [GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2016-10-14T00:46:44Z","receivedAt":"2016-10-14T00:48:27Z","isPatch":false,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Alexander Shopov <ash@kambanaria.org> writes:\n\n>Signed-off-by: Alexander Shopov <ash@kambanaria.org>\n>---\n> lib/remote.tcl | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n>diff --git a/lib/remote.tcl b/lib/remote.tcl\n>index 4e5c784..26af8ae 100644\n>--- a/lib/remote.tcl\n>+++ b/lib/remote.tcl\n>@@ -250,12 +250,12 @@ proc update_all_remotes_menu_entry {} {\n> \n> \t\t\t$fetch_m insert end separator\n> \t\t\t$fetch_m insert end command \\\n>-\t\t\t\t-label \"All\" \\\n>+\t\t\t    -label [mc \"All\"] \\\n> \t\t\t\t-command fetch_from_all\n> \n> \t\t\t$prune_m insert end separator\n> \t\t\t$prune_m insert end command \\\n>-\t\t\t\t-label \"All\" \\\n>+\t\t\t    -label [mc \"All\" ]\\\n> \t\t\t\t-command prune_from_all\n> \t\t}\n> \t} else {\n\nOK - this looks fine except the line just above compares the text of\nthis entry so also needs [mc] adding. I've applied it as:\n\n-- a/lib/remote.tcl\n+++ b/lib/remote.tcl\n@@ -246,22 +246,22 @@ proc update_all_remotes_menu_entry {} {\n        if {$have_remote > 1} {\n                make_sure_remote_submenues_exist $remote_m\n                if {[$fetch_m type end] eq \"command\" \\\n-                       && [$fetch_m entrycget end -label] ne \"All\"} {\n+                               && [$fetch_m entrycget end -label] ne [mc \"All\"]} {\n \n                        $fetch_m insert end separator\n                        $fetch_m insert end command \\\n-                               -label \"All\" \\\n+                               -label [mc \"All\"] \\\n                                -command fetch_from_all\n \n                        $prune_m insert end separator\n                        $prune_m insert end command \\\n-                               -label \"All\" \\\n+                               -label [mc \"All\"] \\\n                                -command prune_from_all\n                }\n        } else {\n                if {[winfo exists $fetch_m]} {\n                        if {[$fetch_m type end] eq \"command\" \\\n-                               && [$fetch_m entrycget end -label] eq \"All\"} {\n+                                       && [$fetch_m entrycget end -label] eq [mc \"All\"]} {\n \n                                delete_from_menu $fetch_m end\n                                delete_from_menu $fetch_m end\n\n\n-- \nPat Thoyts                            http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD\n"}]}